[clang] [llvm] [mlir] Fix typo "tranpose" (PR #124929)
https://github.com/jayfoad closed https://github.com/llvm/llvm-project/pull/124929 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [mlir] Fix typo "tranpose" (PR #124929)
https://github.com/aartbik approved this pull request. https://github.com/llvm/llvm-project/pull/124929 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [mlir] Fix typo "tranpose" (PR #124929)
@@ -1269,7 +1269,7 @@ struct LinalgOpRewriter : public
OpRewritePattern {
AffineExpr i, j, k;
bindDims(getContext(), i, j, k);
-// TODO: more robust patterns, tranposed versions, more kernels,
+// TODO: more robust patterns, transposed versions, more kernels,
aartbik wrote:
When I saw the title, I just knew it would also involve a sparse file, since I
always seem to make this typo ;-)
LGTM
https://github.com/llvm/llvm-project/pull/124929
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [mlir] Fix typo "tranpose" (PR #124929)
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/124929 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [mlir] Fix typo "tranpose" (PR #124929)
https://github.com/MacDue approved this pull request. https://github.com/llvm/llvm-project/pull/124929 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [mlir] Fix typo "tranpose" (PR #124929)
llvmbot wrote:
@llvm/pr-subscribers-backend-x86
Author: Jay Foad (jayfoad)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/124929.diff
16 Files Affected:
- (modified) clang/lib/Headers/amxtf32transposeintrin.h (+1-1)
- (modified) llvm/lib/Target/Hexagon/HexagonISelDAGToDAGHVX.cpp (+1-1)
- (modified) mlir/docs/Canonicalization.md (+1-1)
- (modified)
mlir/include/mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.td (+1-1)
- (modified) mlir/include/mlir/Dialect/Vector/IR/VectorOps.td (+2-2)
- (modified) mlir/lib/Conversion/VectorToArmSME/VectorToArmSME.cpp (+1-1)
- (modified) mlir/lib/Conversion/VectorToXeGPU/VectorToXeGPU.cpp (+1-1)
- (modified) mlir/lib/Dialect/ArmSME/Transforms/VectorLegalization.cpp (+2-2)
- (modified) mlir/lib/Dialect/LLVMIR/IR/NVVMDialect.cpp (+1-1)
- (modified) mlir/lib/Dialect/Linalg/IR/LinalgInterfaces.cpp (+1-1)
- (modified) mlir/lib/Dialect/Linalg/Transforms/TransposeConv2D.cpp (+1-1)
- (modified) mlir/lib/Dialect/SparseTensor/Transforms/SparseGPUCodegen.cpp
(+1-1)
- (modified) mlir/lib/Dialect/Vector/IR/VectorOps.cpp (+2-2)
- (modified) mlir/lib/Dialect/Vector/Transforms/VectorDropLeadUnitDim.cpp
(+7-7)
- (modified) mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp (+2-2)
- (modified) mlir/test/Dialect/Vector/vector-unroll-options.mlir (+2-2)
``diff
diff --git a/clang/lib/Headers/amxtf32transposeintrin.h
b/clang/lib/Headers/amxtf32transposeintrin.h
index 60336f953ecb7a..e1b90c1adfb22a 100644
--- a/clang/lib/Headers/amxtf32transposeintrin.h
+++ b/clang/lib/Headers/amxtf32transposeintrin.h
@@ -8,7 +8,7 @@
*/
#ifndef __IMMINTRIN_H
#error
\
-"Never use directly; include
instead."
+"Never use directly; include
instead."
#endif // __IMMINTRIN_H
#ifndef __AMX_TF32TRANSPOSEINTRIN_H
diff --git a/llvm/lib/Target/Hexagon/HexagonISelDAGToDAGHVX.cpp
b/llvm/lib/Target/Hexagon/HexagonISelDAGToDAGHVX.cpp
index db9aa7e18f5e7a..cfb552c65e0c6f 100644
--- a/llvm/lib/Target/Hexagon/HexagonISelDAGToDAGHVX.cpp
+++ b/llvm/lib/Target/Hexagon/HexagonISelDAGToDAGHVX.cpp
@@ -2269,7 +2269,7 @@ OpRef HvxSelector::perfect(ShuffleMask SM, OpRef Va,
ResultStack &Results) {
// For example, with the inputs as above, the result will be:
// 0 8 2 A 4 C 6 E
// 1 9 3 B 5 D 7 F
- // Now, this result can be tranposed again, but with the group size of 2:
+ // Now, this result can be transposed again, but with the group size of 2:
// 08 19 4C 5D
// 2A 3B 6E 7F
// If we then transpose that result, but with the group size of 4, we get:
diff --git a/mlir/docs/Canonicalization.md b/mlir/docs/Canonicalization.md
index 03fd174229afe9..6e59a4128093a2 100644
--- a/mlir/docs/Canonicalization.md
+++ b/mlir/docs/Canonicalization.md
@@ -71,7 +71,7 @@ For example, a pattern that transform
outs(%init1 : tensor<2x1x3xf32>)
dimensions = [1, 0, 2]
%out = linalg.transpose
- ins(%tranpose: tensor<2x1x3xf32>)
+ ins(%transpose: tensor<2x1x3xf32>)
outs(%init2 : tensor<3x1x2xf32>)
permutation = [2, 1, 0]
```
diff --git
a/mlir/include/mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.td
b/mlir/include/mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.td
index 081bf9b6d3b239..e86d1754897759 100644
--- a/mlir/include/mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.td
+++ b/mlir/include/mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.td
@@ -1007,7 +1007,7 @@ def PackTransposeOp : Op` type($res)";
}
-/// Vector dialect matrix tranposition op that operates on flattened 1-D
+/// Vector dialect matrix transposition op that operates on flattened 1-D
/// MLIR vectors. This is the counterpart of llvm.matrix.transpose in MLIR.
/// This may seem redundant with vector.transpose but it serves the purposes of
/// more progressive lowering and localized type conversion on the path:
@@ -2799,7 +2799,7 @@ def Vector_FlatTransposeOp : Vector_Op<"flat_transpose",
[Pure,
let description = [{
This is the counterpart of llvm.matrix.transpose in MLIR. It serves
the purposes of more progressive lowering and localized type conversion.
-Higher levels typically lower matrix tranpositions into 'vector.transpose'
+Higher levels typically lower matrix transpositions into 'vector.transpose'
operations. Subsequent rewriting rule progressively lower these operations
into 'vector.flat_transpose' operations to bring the operations closer
to the hardware ISA.
diff --git a/mlir/lib/Conversion/VectorToArmSME/VectorToArmSME.cpp
b/mlir/lib/Conversion/VectorToArmSME/VectorToArmSME.cpp
index 55965d9c2a531d..4be0fffe8b7285 100644
--- a/mlir/lib/Conversion/VectorToArmSME/VectorToArmSME.cpp
+++ b/mlir/lib/Conversion/VectorToArmSME/VectorToArmSME.cpp
@@ -332,7 +332,7 @@ struct SplatOpToArmSMELowering : public
OpRewritePattern {
/// %transposed_src = arm_sme.tile_load %alloca[%c0, %c0]
///
[clang] [llvm] [mlir] Fix typo "tranpose" (PR #124929)
https://github.com/jayfoad created
https://github.com/llvm/llvm-project/pull/124929
None
>From 03ea8ad4f2a7b6589539dbc137c356455225fc15 Mon Sep 17 00:00:00 2001
From: Jay Foad
Date: Wed, 29 Jan 2025 14:49:05 +
Subject: [PATCH] Fix typo "tranpose"
---
clang/lib/Headers/amxtf32transposeintrin.h | 2 +-
llvm/lib/Target/Hexagon/HexagonISelDAGToDAGHVX.cpp | 2 +-
mlir/docs/Canonicalization.md | 2 +-
.../Linalg/TransformOps/LinalgTransformOps.td | 2 +-
mlir/include/mlir/Dialect/Vector/IR/VectorOps.td | 4 ++--
.../Conversion/VectorToArmSME/VectorToArmSME.cpp | 2 +-
.../lib/Conversion/VectorToXeGPU/VectorToXeGPU.cpp | 2 +-
.../ArmSME/Transforms/VectorLegalization.cpp | 4 ++--
mlir/lib/Dialect/LLVMIR/IR/NVVMDialect.cpp | 2 +-
mlir/lib/Dialect/Linalg/IR/LinalgInterfaces.cpp| 2 +-
.../Dialect/Linalg/Transforms/TransposeConv2D.cpp | 2 +-
.../SparseTensor/Transforms/SparseGPUCodegen.cpp | 2 +-
mlir/lib/Dialect/Vector/IR/VectorOps.cpp | 4 ++--
.../Vector/Transforms/VectorDropLeadUnitDim.cpp| 14 +++---
.../Dialect/Vector/Transforms/VectorTransforms.cpp | 4 ++--
.../test/Dialect/Vector/vector-unroll-options.mlir | 4 ++--
16 files changed, 27 insertions(+), 27 deletions(-)
diff --git a/clang/lib/Headers/amxtf32transposeintrin.h
b/clang/lib/Headers/amxtf32transposeintrin.h
index 60336f953ecb7a..e1b90c1adfb22a 100644
--- a/clang/lib/Headers/amxtf32transposeintrin.h
+++ b/clang/lib/Headers/amxtf32transposeintrin.h
@@ -8,7 +8,7 @@
*/
#ifndef __IMMINTRIN_H
#error
\
-"Never use directly; include
instead."
+"Never use directly; include
instead."
#endif // __IMMINTRIN_H
#ifndef __AMX_TF32TRANSPOSEINTRIN_H
diff --git a/llvm/lib/Target/Hexagon/HexagonISelDAGToDAGHVX.cpp
b/llvm/lib/Target/Hexagon/HexagonISelDAGToDAGHVX.cpp
index db9aa7e18f5e7a..cfb552c65e0c6f 100644
--- a/llvm/lib/Target/Hexagon/HexagonISelDAGToDAGHVX.cpp
+++ b/llvm/lib/Target/Hexagon/HexagonISelDAGToDAGHVX.cpp
@@ -2269,7 +2269,7 @@ OpRef HvxSelector::perfect(ShuffleMask SM, OpRef Va,
ResultStack &Results) {
// For example, with the inputs as above, the result will be:
// 0 8 2 A 4 C 6 E
// 1 9 3 B 5 D 7 F
- // Now, this result can be tranposed again, but with the group size of 2:
+ // Now, this result can be transposed again, but with the group size of 2:
// 08 19 4C 5D
// 2A 3B 6E 7F
// If we then transpose that result, but with the group size of 4, we get:
diff --git a/mlir/docs/Canonicalization.md b/mlir/docs/Canonicalization.md
index 03fd174229afe9..6e59a4128093a2 100644
--- a/mlir/docs/Canonicalization.md
+++ b/mlir/docs/Canonicalization.md
@@ -71,7 +71,7 @@ For example, a pattern that transform
outs(%init1 : tensor<2x1x3xf32>)
dimensions = [1, 0, 2]
%out = linalg.transpose
- ins(%tranpose: tensor<2x1x3xf32>)
+ ins(%transpose: tensor<2x1x3xf32>)
outs(%init2 : tensor<3x1x2xf32>)
permutation = [2, 1, 0]
```
diff --git
a/mlir/include/mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.td
b/mlir/include/mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.td
index 081bf9b6d3b239..e86d1754897759 100644
--- a/mlir/include/mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.td
+++ b/mlir/include/mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.td
@@ -1007,7 +1007,7 @@ def PackTransposeOp : Op` type($res)";
}
-/// Vector dialect matrix tranposition op that operates on flattened 1-D
+/// Vector dialect matrix transposition op that operates on flattened 1-D
/// MLIR vectors. This is the counterpart of llvm.matrix.transpose in MLIR.
/// This may seem redundant with vector.transpose but it serves the purposes of
/// more progressive lowering and localized type conversion on the path:
@@ -2799,7 +2799,7 @@ def Vector_FlatTransposeOp : Vector_Op<"flat_transpose",
[Pure,
let description = [{
This is the counterpart of llvm.matrix.transpose in MLIR. It serves
the purposes of more progressive lowering and localized type conversion.
-Higher levels typically lower matrix tranpositions into 'vector.transpose'
+Higher levels typically lower matrix transpositions into 'vector.transpose'
operations. Subsequent rewriting rule progressively lower these operations
into 'vector.flat_transpose' operations to bring the operations closer
to the hardware ISA.
diff --git a/mlir/lib/Conversion/VectorToArmSME/VectorToArmSME.cpp
b/mlir/lib/Conversion/VectorToArmSME/VectorToArmSME.cpp
index 55965d9c2a531d..4be0fffe8b7285 100644
--- a/mlir/lib/Conversion/VectorToArmSME/VectorToArmSME.cpp
+++ b/mlir/lib/Conversion/VectorToArmSME/VectorToArmSME.cpp
@@ -332,7 +332,7 @@ struct SplatOpToArmSMELowering : public
OpRewritePattern {
/// %transposed_src = arm_sme.tile_load %alloca[%c0, %c0]
/// layout : memref, vector<[4]x[4]xi32>
///
-/// NOTE: Tranposing v
