Re: [clang-tools-extra] r325097 - [clangd] Configure clangd tracing with CLANGD_TRACE env instead of -trace flag

2018-02-15 Thread Ilya Biryukov via cfe-commits
On Thu, Feb 15, 2018 at 8:29 AM Sam McCall wrote: > On Wed, Feb 14, 2018 at 10:45 AM Ilya Biryukov > wrote: > >> Personally, I'm not a big fan of environment variables. There are harder >> to discover than command-line flags and I still have to change editor >> config often to switch between dif

Re: [clang-tools-extra] r325097 - [clangd] Configure clangd tracing with CLANGD_TRACE env instead of -trace flag

2018-02-14 Thread Sam McCall via cfe-commits
On Wed, Feb 14, 2018 at 10:45 AM Ilya Biryukov wrote: > Personally, I'm not a big fan of environment variables. There are harder > to discover than command-line flags and I still have to change editor > config often to switch between different builds of clangd. > I know it may sound weird, but ma

Re: [clang-tools-extra] r325097 - [clangd] Configure clangd tracing with CLANGD_TRACE env instead of -trace flag

2018-02-14 Thread Ilya Biryukov via cfe-commits
Personally, I'm not a big fan of environment variables. There are harder to discover than command-line flags and I still have to change editor config often to switch between different builds of clangd. I know it may sound weird, but maybe we could have both the flag and the environment variables? (

[clang-tools-extra] r325097 - [clangd] Configure clangd tracing with CLANGD_TRACE env instead of -trace flag

2018-02-13 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue Feb 13 19:20:07 2018 New Revision: 325097 URL: http://llvm.org/viewvc/llvm-project?rev=325097&view=rev Log: [clangd] Configure clangd tracing with CLANGD_TRACE env instead of -trace flag Modified: clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp clang-tools-e