Author: zinovy.nis
Date: Sat Apr 7 04:22:01 2018
New Revision: 329495
URL: http://llvm.org/viewvc/llvm-project?rev=329495&view=rev
Log:
[clang-tidy] Fix compilation for MSVS@PSP4 for ParentVirtualCallCheck.cpp
There's an error for PSP4 platform only:
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE\algorithm(95):
error C2719: '_Pred': formal parameter with requested alignment of 8 won't be
aligned
Modified:
clang-tools-extra/trunk/clang-tidy/bugprone/ParentVirtualCallCheck.cpp
Modified: clang-tools-extra/trunk/clang-tidy/bugprone/ParentVirtualCallCheck.cpp
URL:
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/bugprone/ParentVirtualCallCheck.cpp?rev=329495&r1=329494&r2=329495&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/bugprone/ParentVirtualCallCheck.cpp
(original)
+++ clang-tools-extra/trunk/clang-tidy/bugprone/ParentVirtualCallCheck.cpp Sat
Apr 7 04:22:01 2018
@@ -27,14 +27,13 @@ static bool isParentOf(const CXXRecordDe
const CXXRecordDecl &ThisClass) {
if (Parent.getCanonicalDecl() == ThisClass.getCanonicalDecl())
return true;
- const auto ClassIter = std::find_if(
- ThisClass.bases().begin(), ThisClass.bases().end(),
- [=](const CXXBaseSpecifier &Base) {
- auto *BaseDecl = Base.getType()->getAsCXXRecordDecl();
- assert(BaseDecl);
- return Parent.getCanonicalDecl() == BaseDecl->getCanonicalDecl();
- });
- return ClassIter != ThisClass.bases_end();
+ for (const CXXBaseSpecifier &Base : ThisClass.bases()) {
+ auto *BaseDecl = Base.getType()->getAsCXXRecordDecl();
+ assert(BaseDecl);
+ if (Parent.getCanonicalDecl() == BaseDecl->getCanonicalDecl())
+ return true;
+ }
+ return false;
}
static BasesVector getParentsByGrandParent(const CXXRecordDecl &GrandParent,
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
