Author: ericwf
Date: Fri Oct 14 16:30:35 2016
New Revision: 284282
URL: http://llvm.org/viewvc/llvm-project?rev=284282&view=rev
Log:
Clarify XFAIL comments
Modified:
libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/delete_align_val_t_replace.pass.cpp
libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/delete_align_val_t_replace.pass.cpp
Modified:
libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/delete_align_val_t_replace.pass.cpp
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/delete_align_val_t_replace.pass.cpp?rev=284282&r1=284281&r2=284282&view=diff
==============================================================================
---
libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/delete_align_val_t_replace.pass.cpp
(original)
+++
libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/delete_align_val_t_replace.pass.cpp
Fri Oct 14 16:30:35 2016
@@ -17,7 +17,7 @@
// None of the current GCC compilers support this.
// XFAIL: gcc-4, gcc-5, gcc-6
-// UBSAN replaces certain new/delete functions which makes this test fail
+// TODO Investigate why UBSAN prevents new from calling our replacement.
// XFAIL: ubsan
#include <new>
@@ -60,6 +60,7 @@ struct alignas(std::max_align_t) B {};
int main()
{
+ reset();
{
B *x = new B[2];
assert(0 == unsized_delete_called);
Modified:
libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/delete_align_val_t_replace.pass.cpp
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/delete_align_val_t_replace.pass.cpp?rev=284282&r1=284281&r2=284282&view=diff
==============================================================================
---
libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/delete_align_val_t_replace.pass.cpp
(original)
+++
libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/delete_align_val_t_replace.pass.cpp
Fri Oct 14 16:30:35 2016
@@ -17,7 +17,7 @@
// None of the current GCC compilers support this.
// XFAIL: gcc-4, gcc-5, gcc-6
-// UBSAN replaces certain new/delete functions which makes this test fail
+// TODO Investigate why UBSAN prevents new from calling our replacement.
// XFAIL: ubsan
#include <new>
@@ -60,6 +60,7 @@ struct alignas(std::max_align_t) B {};
int main()
{
+ reset();
{
B *x = new B;
assert(0 == unsized_delete_called);
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
