Re: [PATCH] D19029: Always use --eh-frame-hdr on FreeBSD, even for -static

2016-04-12 Thread Davide Italiano via cfe-commits 
davide added a subscriber: davide.
davide added a comment.

LGTM.


Repository:
  rL LLVM

http://reviews.llvm.org/D19029



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19029: Always use --eh-frame-hdr on FreeBSD, even for -static

2016-04-12 Thread Davide Italiano via cfe-commits 
LGTM.

On Tue, Apr 12, 2016 at 2:17 PM, Ed Maste  wrote:
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL266123: Always use --eh-frame-hdr on FreeBSD, even for 
> -static (authored by emaste).
>
> Changed prior to commit:
>   http://reviews.llvm.org/D19029?vs=53452=53460#toc
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D19029
>
> Files:
>   cfe/trunk/lib/Driver/Tools.cpp
>   cfe/trunk/test/Driver/freebsd.c
>
> Index: cfe/trunk/test/Driver/freebsd.c
> ===
> --- cfe/trunk/test/Driver/freebsd.c
> +++ cfe/trunk/test/Driver/freebsd.c
> @@ -82,6 +82,7 @@
>  // RUN: %clang -no-canonical-prefixes -target x86_64-pc-freebsd8 -static %s \
>  // RUN:   --sysroot=%S/Inputs/multiarch_freebsd64_tree -### 2>&1 \
>  // RUN:   | FileCheck --check-prefix=CHECK-STATIC %s
> +// CHECK-STATIC: ld{{.*}}" "--eh-frame-hdr" "-Bstatic"
>  // CHECK-STATIC: crt1.o
>  // CHECK-STATIC: crtbeginT.o
>
> Index: cfe/trunk/lib/Driver/Tools.cpp
> ===
> --- cfe/trunk/lib/Driver/Tools.cpp
> +++ cfe/trunk/lib/Driver/Tools.cpp
> @@ -8197,12 +8197,12 @@
>if (IsPIE)
>  CmdArgs.push_back("-pie");
>
> +  CmdArgs.push_back("--eh-frame-hdr");
>if (Args.hasArg(options::OPT_static)) {
>  CmdArgs.push_back("-Bstatic");
>} else {
>  if (Args.hasArg(options::OPT_rdynamic))
>CmdArgs.push_back("-export-dynamic");
> -CmdArgs.push_back("--eh-frame-hdr");
>  if (Args.hasArg(options::OPT_shared)) {
>CmdArgs.push_back("-Bshareable");
>  } else {
>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19029: Always use --eh-frame-hdr on FreeBSD, even for -static

2016-04-12 Thread Ed Maste via cfe-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266123: Always use --eh-frame-hdr on FreeBSD, even for 
-static (authored by emaste).

Changed prior to commit:
  http://reviews.llvm.org/D19029?vs=53452=53460#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D19029

Files:
  cfe/trunk/lib/Driver/Tools.cpp
  cfe/trunk/test/Driver/freebsd.c

Index: cfe/trunk/test/Driver/freebsd.c
===
--- cfe/trunk/test/Driver/freebsd.c
+++ cfe/trunk/test/Driver/freebsd.c
@@ -82,6 +82,7 @@
 // RUN: %clang -no-canonical-prefixes -target x86_64-pc-freebsd8 -static %s \
 // RUN:   --sysroot=%S/Inputs/multiarch_freebsd64_tree -### 2>&1 \
 // RUN:   | FileCheck --check-prefix=CHECK-STATIC %s
+// CHECK-STATIC: ld{{.*}}" "--eh-frame-hdr" "-Bstatic"
 // CHECK-STATIC: crt1.o
 // CHECK-STATIC: crtbeginT.o
 
Index: cfe/trunk/lib/Driver/Tools.cpp
===
--- cfe/trunk/lib/Driver/Tools.cpp
+++ cfe/trunk/lib/Driver/Tools.cpp
@@ -8197,12 +8197,12 @@
   if (IsPIE)
 CmdArgs.push_back("-pie");
 
+  CmdArgs.push_back("--eh-frame-hdr");
   if (Args.hasArg(options::OPT_static)) {
 CmdArgs.push_back("-Bstatic");
   } else {
 if (Args.hasArg(options::OPT_rdynamic))
   CmdArgs.push_back("-export-dynamic");
-CmdArgs.push_back("--eh-frame-hdr");
 if (Args.hasArg(options::OPT_shared)) {
   CmdArgs.push_back("-Bshareable");
 } else {


Index: cfe/trunk/test/Driver/freebsd.c
===
--- cfe/trunk/test/Driver/freebsd.c
+++ cfe/trunk/test/Driver/freebsd.c
@@ -82,6 +82,7 @@
 // RUN: %clang -no-canonical-prefixes -target x86_64-pc-freebsd8 -static %s \
 // RUN:   --sysroot=%S/Inputs/multiarch_freebsd64_tree -### 2>&1 \
 // RUN:   | FileCheck --check-prefix=CHECK-STATIC %s
+// CHECK-STATIC: ld{{.*}}" "--eh-frame-hdr" "-Bstatic"
 // CHECK-STATIC: crt1.o
 // CHECK-STATIC: crtbeginT.o
 
Index: cfe/trunk/lib/Driver/Tools.cpp
===
--- cfe/trunk/lib/Driver/Tools.cpp
+++ cfe/trunk/lib/Driver/Tools.cpp
@@ -8197,12 +8197,12 @@
   if (IsPIE)
 CmdArgs.push_back("-pie");
 
+  CmdArgs.push_back("--eh-frame-hdr");
   if (Args.hasArg(options::OPT_static)) {
 CmdArgs.push_back("-Bstatic");
   } else {
 if (Args.hasArg(options::OPT_rdynamic))
   CmdArgs.push_back("-export-dynamic");
-CmdArgs.push_back("--eh-frame-hdr");
 if (Args.hasArg(options::OPT_shared)) {
   CmdArgs.push_back("-Bshareable");
 } else {
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19029: Always use --eh-frame-hdr on FreeBSD, even for -static

2016-04-12 Thread Rafael Ávila de Espíndola via cfe-commits 
rafael added a subscriber: rafael.
rafael accepted this revision.
rafael added a reviewer: rafael.
rafael added a comment.
This revision is now accepted and ready to land.

LGTM


http://reviews.llvm.org/D19029



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits