hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D21856
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
ABataev added a comment.
LG
https://reviews.llvm.org/D21856
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao updated this revision to Diff 72125.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21856
Files:
include/clang/Driver/Action.h
include/clang/Driver/ToolChain.h
lib/Driver/Action.cpp
lib/Driver/ToolChain.cpp
lib/Driver/Tools.cpp
lib/Driver/Tools.h
test/Driver/
sfantao updated this revision to Diff 66028.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21856
Files:
include/clang/Driver/Action.h
include/clang/Driver/ToolChain.h
lib/Driver/Action.cpp
lib/Driver/ToolChain.cpp
lib/Driver/Tools.cpp
lib/Driver/Tools.h
test/Driver/
sfantao updated this revision to Diff 62590.
sfantao added a comment.
- Start static function name with caps.
http://reviews.llvm.org/D21856
Files:
include/clang/Driver/Action.h
include/clang/Driver/ToolChain.h
lib/Driver/Action.cpp
lib/Driver/ToolChain.cpp
lib/Driver/Tools.cpp
lib/
sfantao updated this revision to Diff 62567.
sfantao added a comment.
- Use StringRef instead of std::string, fix comments and mark class final.
http://reviews.llvm.org/D21856
Files:
include/clang/Driver/Action.h
include/clang/Driver/ToolChain.h
lib/Driver/Action.cpp
lib/Driver/ToolChai
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: lib/Driver/Action.cpp:133
@@ +132,3 @@
+/// we assume 'host'.
+std::string Action::getOffloadKindName(OffloadKind Kind) {
+ switch (Kind) {
ABataev wrote:
> 1. Maybe it is enough to return
sfantao updated this revision to Diff 62561.
sfantao marked 3 inline comments as done.
sfantao added a comment.
- Use StringRef instead of string and mark bundler tool as final.
http://reviews.llvm.org/D21856
Files:
include/clang/Driver/Action.h
include/clang/Driver/ToolChain.h
lib/Driver
ABataev added inline comments.
Comment at: include/clang/Driver/Action.h:158
@@ -157,1 +157,3 @@
std::string getOffloadingFileNamePrefix(StringRef NormalizedTriple) const;
+ /// \brief Return a string containing a offload kind name.
+ static std::string getOffloadKindName(Off
