Re: [PATCH] D24599: Add 'inline' but not _LIBCPP_INLINE_VISIBILITY to basic_string's destructor

2016-09-28 Thread Aditya Kumar via cfe-commits
hiraditya added a comment. I think now the original patch can be re-applied now that the bug: https://llvm.org/bugs/show_bug.cgi?id=30341 has been fixed in https://reviews.llvm.org/D24682 https://reviews.llvm.org/D24599 ___ cfe-commits mailing

Re: [PATCH] D24599: Add 'inline' but not _LIBCPP_INLINE_VISIBILITY to basic_string's destructor

2016-09-16 Thread Aditya Kumar via cfe-commits
hiraditya added a comment. Please also see: https://reviews.llvm.org/D24682 https://reviews.llvm.org/D24599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24599: Add 'inline' but not _LIBCPP_INLINE_VISIBILITY to basic_string's destructor

2016-09-15 Thread Eric Fiselier via cfe-commits
EricWF added a comment. In https://reviews.llvm.org/D24599#543849, @mclow.lists wrote: > Any reason we shouldn't just revert r280944, wait for the LLVM bug to be > fixed, and then re-apply it? I would like to put some time between fixing the Clang bug and re-introducing the reproducer into

Re: [PATCH] D24599: Add 'inline' but not _LIBCPP_INLINE_VISIBILITY to basic_string's destructor

2016-09-15 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. Any reason we shouldn't just revert r280944, wait for the LLVM bug to be fixed, and then re-apply it? https://reviews.llvm.org/D24599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org