This revision was automatically updated to reflect the committed changes.
Closed by commit rL281819: When replacements have the same offset, make
replacements with smaller length… (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D24663?vs=71730=71731#toc
Repository:
ioeric updated this revision to Diff 71730.
ioeric added a comment.
- Format code properly.
https://reviews.llvm.org/D24663
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replacement.cpp
Index: lib/Tooling/Core/Replacement.cpp
ioeric updated this revision to Diff 71729.
ioeric marked an inline comment as done.
ioeric added a comment.
- Use auto.
https://reviews.llvm.org/D24663
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replacement.cpp
Index: lib/Tooling/Core/Replacement.cpp
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
Comment at: lib/Tooling/Core/Replacement.cpp:407
@@ -409,3 +406,3 @@
bool Result = true;
- for (Replacements::const_iterator I = Replaces.begin(),
-
ioeric added a comment.
In https://reviews.llvm.org/D24663#544993, @klimek wrote:
> Test? Why are we doing this (should go into the CL description)?
There is no behavioral change intended, and the goal here is not to break any
test. A test for this change can be having an insertion and a
klimek added a comment.
Test? Why are we doing this (should go into the CL description)?
https://reviews.llvm.org/D24663
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
