daphnediane added a comment.
In https://reviews.llvm.org/D24703#545917, @djasper wrote:
> Looks good. Thank you!
Thanks. Are there additional steps I need to get it commited or do I just wait
for a commiter to notice?
https://reviews.llvm.org/D24703
___
daphnediane updated this revision to Diff 71767.
daphnediane added a comment.
Adds test case, changes to suggested fix allowing break after template opener
that is not immediately followed by template closer.
https://reviews.llvm.org/D24703
Files:
lib/Format/TokenAnnotator.cpp
unittests/Fo
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good. Thank you!
https://reviews.llvm.org/D24703
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
daphnediane added a comment.
In https://reviews.llvm.org/D24703#545706, @djasper wrote:
> I think, this is the wrong fix. Instead, a
>
> || (Left.is(TT_TemplateOpener) && !Right.is(TT_TemplateCloser))
>
>
> should be added to the last return statement of this function.
>
> Also, could you pl
djasper added a comment.
I think, this is the wrong fix. Instead, a
|| (Left.is(TT_TemplateOpener) && !Right.is(TT_TemplateCloser))
should be added to the last return statement of this function.
Also, could you please add a test in unittests/Format/FormatTest.cpp.
https://reviews.llvm.org/D
