MatzeB updated this revision to Diff 72376.
MatzeB marked an inline comment as done.
MatzeB added a comment.
Thanks for the reviews.
Addressed comments.
Repository:
rL LLVM
https://reviews.llvm.org/D24820
Files:
docs/CommandGuide/clang.rst
include/clang/Basic/DiagnosticFrontendKinds.td
bruno added a comment.
Maybe add some docs to explain the new flags?
Comment at: lib/Driver/Tools.cpp:6102
@@ +6101,3 @@
+StatsFile.assign(Output.getFilename());
+llvm::sys::path::remove_filename(StatsFile);
+ }
MatzeB wrote:
> bruno wrote:
MatzeB added inline comments.
Comment at: lib/Driver/Tools.cpp:6102
@@ +6101,3 @@
+StatsFile.assign(Output.getFilename());
+llvm::sys::path::remove_filename(StatsFile);
+ }
bruno wrote:
> Why removing StatsFile here? IIUC, at this point
bruno added inline comments.
Comment at: lib/Driver/Tools.cpp:6102
@@ +6101,3 @@
+StatsFile.assign(Output.getFilename());
+llvm::sys::path::remove_filename(StatsFile);
+ }
Why removing StatsFile here? IIUC, at this point StatsFile is still
aprantl added inline comments.
Comment at: include/clang/Basic/DiagnosticFrontendKinds.td:111
@@ -110,1 +110,3 @@
+def warn_fe_unable_to_open_stats_file : Warning<
+"unable to open statistic output file '%0': '%1'">;
def err_fe_no_pch_in_dir : Error<
