Re: [PATCH] D45109: Remove -cc1 option "-backend-option"

2018-04-12 Thread Friedman, Eli via cfe-commits
The test wasn't checking anything useful; the clang driver never passes "-arm-long-calls" to clang -cc1.  See https://reviews.llvm.org/rL241565 . -Eli On 4/12/2018 3:55 PM, George Karpenkov wrote: Hi Eli, The commit makes sense, but I’m not sure about your change to the `test/Driver/apple-ke

Re: [PATCH] D45109: Remove -cc1 option "-backend-option"

2018-04-12 Thread George Karpenkov via cfe-commits
Hi Eli, The commit makes sense, but I’m not sure about your change to the `test/Driver/apple-kext-mkernel.c ` file: instead of changing the run lines to use -mllvm you have removed them. Was there a reason for the remo