Re: [PATCH] D45109: Remove -cc1 option "-backend-option"

[Friedman, Eli via cfe-commits]

The test wasn't checking anything useful; the clang driver never passes 
"-arm-long-calls" to clang -cc1.  See https://reviews.llvm.org/rL241565 .


-Eli

On 4/12/2018 3:55 PM, George Karpenkov wrote:

Hi Eli,

The commit makes sense, but I’m not sure about your change to the 
`test/Driver/apple-kext-mkernel.c 
` 
file:

instead of changing the run lines to use -mllvm you have removed them.
Was there a reason for the removal?

Regards,
George

On Apr 12, 2018, at 3:25 PM, Eli Friedman via Phabricator via 
llvm-commits > wrote:


This revision was automatically updated to reflect the committed changes.
Closed by commit rL329965: Remove -cc1 option 
"-backend-option". (authored by efriedma, committed by ).

Herald added a subscriber: llvm-commits.

Changed prior to commit:
https://reviews.llvm.org/D45109?vs=140484&id=142277#toc

Repository:
 rL LLVM

https://reviews.llvm.org/D45109

Files:
 cfe/trunk/include/clang/Driver/CC1Options.td
 cfe/trunk/include/clang/Frontend/CodeGenOptions.h
 cfe/trunk/lib/CodeGen/BackendUtil.cpp
 cfe/trunk/lib/Driver/ToolChains/Clang.cpp
 cfe/trunk/lib/Frontend/CompilerInvocation.cpp
 cfe/trunk/test/CodeGen/thinlto-backend-option.ll
 cfe/trunk/test/CodeGenCUDA/link-device-bitcode.cu
 cfe/trunk/test/Driver/aarch64-fix-cortex-a53-835769.c
 cfe/trunk/test/Driver/apple-kext-mkernel.c
 cfe/trunk/test/Driver/arm-restrict-it.c
 cfe/trunk/test/Driver/debug-options.c
 cfe/trunk/test/Driver/mglobal-merge.c
 cfe/trunk/test/Driver/woa-restrict-it.c
 cfe/trunk/test/Frontend/backend-option.c

___
llvm-commits mailing list
llvm-comm...@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits




--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux 
Foundation Collaborative Project

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D45109: Remove -cc1 option "-backend-option"

[George Karpenkov via cfe-commits]

Hi Eli,

The commit makes sense, but I’m not sure about your change to the 
`test/Driver/apple-kext-mkernel.c 
` 
file:
instead of changing the run lines to use -mllvm you have removed them.
Was there a reason for the removal?

Regards,
George

> On Apr 12, 2018, at 3:25 PM, Eli Friedman via Phabricator via llvm-commits 
>  wrote:
> 
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL329965: Remove -cc1 option "-backend-option". 
> (authored by efriedma, committed by ).
> Herald added a subscriber: llvm-commits.
> 
> Changed prior to commit:
>  https://reviews.llvm.org/D45109?vs=140484&id=142277#toc
> 
> Repository:
>  rL LLVM
> 
> https://reviews.llvm.org/D45109
> 
> Files:
>  cfe/trunk/include/clang/Driver/CC1Options.td
>  cfe/trunk/include/clang/Frontend/CodeGenOptions.h
>  cfe/trunk/lib/CodeGen/BackendUtil.cpp
>  cfe/trunk/lib/Driver/ToolChains/Clang.cpp
>  cfe/trunk/lib/Frontend/CompilerInvocation.cpp
>  cfe/trunk/test/CodeGen/thinlto-backend-option.ll
>  cfe/trunk/test/CodeGenCUDA/link-device-bitcode.cu
>  cfe/trunk/test/Driver/aarch64-fix-cortex-a53-835769.c
>  cfe/trunk/test/Driver/apple-kext-mkernel.c
>  cfe/trunk/test/Driver/arm-restrict-it.c
>  cfe/trunk/test/Driver/debug-options.c
>  cfe/trunk/test/Driver/mglobal-merge.c
>  cfe/trunk/test/Driver/woa-restrict-it.c
>  cfe/trunk/test/Frontend/backend-option.c
> 
> ___
> llvm-commits mailing list
> llvm-comm...@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits