Thanks. Any idea why AtomicChange.cpp's inclusion of
clang/Tooling/ReplacementsYaml.h
doesn't cause the same problem?
https://github.com/llvm/llvm-project/blob/master/clang/lib/Tooling/Refactoring/AtomicChange.cpp
On Wed, Apr 3, 2019 at 2:11 PM Alexey Bataev wrote:
> The problem is that
Alexey, thanks for reverting the change. Can you expand on why a dependency
from libToolingRefactor to libTooling causes a cycle in the dep graph? In
particular, I can't find the reverse dependency libTooling ->
libToolingRefactor. If you can expand on that (I presume its a chain rather
than a
I'll revert the change.
On Wed, Apr 3, 2019 at 1:00 PM Yitzhak Mandelbaum
wrote:
> https://reviews.llvm.org/D60213 for the record
>
> On Wed, Apr 3, 2019 at 12:55 PM Yitzhak Mandelbaum
> wrote:
>
>> Thanks. Do you have build command I can run before/after to verify my
>> fix before I submit?
https://reviews.llvm.org/D60213 for the record
On Wed, Apr 3, 2019 at 12:55 PM Yitzhak Mandelbaum
wrote:
> Thanks. Do you have build command I can run before/after to verify my fix
> before I submit?
>
> On Wed, Apr 3, 2019 at 12:43 PM Alexey Bataev via Phabricator <
>
Thanks. Do you have build command I can run before/after to verify my fix
before I submit?
On Wed, Apr 3, 2019 at 12:43 PM Alexey Bataev via Phabricator <
revi...@reviews.llvm.org> wrote:
> ABataev added a comment.
>
> Patch breaks the build with the shared libraries, for example,
>