Re: [PATCH] D74704: Support -fuse-ld=lld for riscv

On Wed, Feb 26, 2020 at 08:08:49PM +, Leonard Chan via Phabricator wrote: > leonardchan added a comment. > > Unsure if my reply was sent over email so copying it here. > > Yup, adding `// REQUIRES: platform-linker` to both `*-extra.c` files seems to > fix it. Thanks. Will you be sending out

Re: [PATCH] D74704: Support -fuse-ld=lld for riscv

Yup, I added it to both *-extra.c files and it seemed to fix the tests. On Wed, Feb 26, 2020 at 11:37 AM Serge Guelton wrote: > Does adding > > // REQUIRES: platform-linker > > to Driver/riscv32-toolchain-extra.c fixes your issue? > > > On Wed, Feb 26, 2020 at 06:25:39PM +, Leonard Chan via

Re: [PATCH] D74704: Support -fuse-ld=lld for riscv

Will you be sending out the patch for this? On Wed, Feb 26, 2020 at 12:05 PM Leonard Chan wrote: > Yup, I added it to both *-extra.c files and it seemed to fix the tests. > > On Wed, Feb 26, 2020 at 11:37 AM Serge Guelton > wrote: > >> Does adding >> >> // REQUIRES: platform-linker >> >> to

Re: [PATCH] D74704: Support -fuse-ld=lld for riscv

Does adding // REQUIRES: platform-linker to Driver/riscv32-toolchain-extra.c fixes your issue? On Wed, Feb 26, 2020 at 06:25:39PM +, Leonard Chan via Phabricator wrote: > leonardchan added a comment. > > Hi again, I think e058667a2e017d3225a9bb067dbac7f2159576f7 >

Re: [PATCH] D74704: Support -fuse-ld=lld for riscv

On Wed, Feb 26, 2020 at 06:25:39PM +, Leonard Chan via Phabricator wrote: > leonardchan added a comment. > > Hi again, I think e058667a2e017d3225a9bb067dbac7f2159576f7 > > might've broken our toolchain again: s***t. Can