Re: [clang-tools-extra] r347675 - [clangd] textDocument/SymbolInfo extension

2018-11-28 Thread Jan Korous via cfe-commits
You are very welcome. Sorry for the trouble! Jan > On 28 Nov 2018, at 11:47, Tom Weaver via cfe-commits > wrote: > > thanks for the fix! > > TomW > > On Wed, 28 Nov 2018 at 11:33, Yvan Roux via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > On Wed, 28 Nov 2018 at 12:28, Yvan

Re: [clang-tools-extra] r347675 - [clangd] textDocument/SymbolInfo extension

2018-11-28 Thread Tom Weaver via cfe-commits
thanks for the fix! TomW On Wed, 28 Nov 2018 at 11:33, Yvan Roux via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Wed, 28 Nov 2018 at 12:28, Yvan Roux wrote: > > > > On Wed, 28 Nov 2018 at 11:16, Mikael Holmén > wrote: > > > > > > > > > > > > On 11/28/18 11:09 AM, Jan Korous wrote: >

Re: [clang-tools-extra] r347675 - [clangd] textDocument/SymbolInfo extension

2018-11-28 Thread Yvan Roux via cfe-commits
On Wed, 28 Nov 2018 at 12:28, Yvan Roux wrote: > > On Wed, 28 Nov 2018 at 11:16, Mikael Holmén > wrote: > > > > > > > > On 11/28/18 11:09 AM, Jan Korous wrote: > > > Thanks for the notice and sorry for the delay! I somehow missed the > > > failure mails before I went offline yesterday. > > > >

Re: [clang-tools-extra] r347675 - [clangd] textDocument/SymbolInfo extension

2018-11-28 Thread Yvan Roux via cfe-commits
On Wed, 28 Nov 2018 at 11:16, Mikael Holmén wrote: > > > > On 11/28/18 11:09 AM, Jan Korous wrote: > > Thanks for the notice and sorry for the delay! I somehow missed the > > failure mails before I went offline yesterday. > > > > I am just running tests on my fix now and hopefully pushing

Re: [clang-tools-extra] r347675 - [clangd] textDocument/SymbolInfo extension

2018-11-28 Thread Mikael Holmén via cfe-commits
On 11/28/18 11:09 AM, Jan Korous wrote: > Thanks for the notice and sorry for the delay! I somehow missed the > failure mails before I went offline yesterday. > > I am just running tests on my fix now and hopefully pushing shortly. > > Since I didn’t know we are using old compilers for these

Re: [clang-tools-extra] r347675 - [clangd] textDocument/SymbolInfo extension

2018-11-28 Thread Jan Korous via cfe-commits
Thanks for the notice and sorry for the delay! I somehow missed the failure mails before I went offline yesterday. I am just running tests on my fix now and hopefully pushing shortly. Since I didn’t know we are using old compilers for these builds I am now curious why. Is that intentional? For

Re: [clang-tools-extra] r347675 - [clangd] textDocument/SymbolInfo extension

2018-11-28 Thread Yvan Roux via cfe-commits
On Wed, 28 Nov 2018 at 09:56, Mikael Holmén via cfe-commits wrote: > > Hi Jan, > > This code doesn't compile with clang 3.6.0: And broke ARM bots, logs available here: http://lab.llvm.org:8011/builders/clang-cmake-armv7-quick/builds/5582/steps/build%20stage%201/logs/stdio Cheers, Yvan >

Re: [clang-tools-extra] r347675 - [clangd] textDocument/SymbolInfo extension

2018-11-28 Thread Mikael Holmén via cfe-commits
Hi Jan, This code doesn't compile with clang 3.6.0: ../tools/clang/tools/extra/clangd/Protocol.cpp:456:10: error: no viable conversion from 'json::Object' to 'llvm::json::Value' return result; ^~ ../include/llvm/Support/JSON.h:291:3: note: candidate constructor not viable: no