Re: r284335 - [analyzer] Make MallocChecker more robust against custom redeclarations

2016-10-16 Thread Devin Coughlin via cfe-commits
> On Oct 16, 2016, at 12:53 PM, Renato Golin wrote: > > On 16 October 2016 at 20:36, Devin Coughlin wrote: >> Reverted in r284340. > > Hi Devin, > > Sometimes Clang patches break on stage 2 or test-suite, but this is > not the case. I dug deeper

Re: r284335 - [analyzer] Make MallocChecker more robust against custom redeclarations

2016-10-16 Thread Renato Golin via cfe-commits
On 16 October 2016 at 20:36, Devin Coughlin wrote: > Reverted in r284340. Hi Devin, Sometimes Clang patches break on stage 2 or test-suite, but this is not the case. I dug deeper and found that there was another commit, not showing on that range (it should have, but that's

Re: r284335 - [analyzer] Make MallocChecker more robust against custom redeclarations

2016-10-16 Thread Devin Coughlin via cfe-commits
> On Oct 16, 2016, at 12:12 PM, Devin Coughlin via cfe-commits > wrote: > >> >> On Oct 16, 2016, at 12:04 PM, Renato Golin wrote: >> >> On 16 October 2016 at 18:26, Devin Coughlin via cfe-commits >> wrote: >>>

Re: r284335 - [analyzer] Make MallocChecker more robust against custom redeclarations

2016-10-16 Thread Devin Coughlin via cfe-commits
> On Oct 16, 2016, at 12:04 PM, Renato Golin wrote: > > On 16 October 2016 at 18:26, Devin Coughlin via cfe-commits > wrote: >> Author: dcoughlin >> Date: Sun Oct 16 12:26:06 2016 >> New Revision: 284335 >> >> URL:

Re: r284335 - [analyzer] Make MallocChecker more robust against custom redeclarations

2016-10-16 Thread Renato Golin via cfe-commits
On 16 October 2016 at 18:26, Devin Coughlin via cfe-commits wrote: > Author: dcoughlin > Date: Sun Oct 16 12:26:06 2016 > New Revision: 284335 > > URL: http://llvm.org/viewvc/llvm-project?rev=284335=rev > Log: > [analyzer] Make MallocChecker more robust against custom