Re: r293518 - [ASTMatchers] Sprinkle some constexpr on the global matcher constructors.

Adrian has filed PR 31860 at https://llvm.org/bugs/show_bug.cgi?id=31860 . On 3 February 2017 at 23:10, Duncan P. N. Exon Smith wrote: > Note that this also failed on Linux: > http://lab.llvm.org:8011/builders/clang-x86_64-linux- > selfhost-modules/builds/2728 > > This

Re: r293518 - [ASTMatchers] Sprinkle some constexpr on the global matcher constructors.

Note that this also failed on Linux: http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules/builds/2728 This looks like a modules compiler bug, as opposed to a problem in the commit itself. Alex, can you file a PR for this? > On 2017-Feb-01, at 07:35, Alex L via cfe-commits

Re: r293518 - [ASTMatchers] Sprinkle some constexpr on the global matcher constructors.

I've narrowed the problem down to the difference in the linkage type for "clang::ast_matchers::recordDecl" between the module and non-module build: Module: @_ZN5clang12ast_matchersL10recordDeclE = external global %"class.clang::ast_matchers::internal::VariadicDynCastAllOfMatcher.847", align 1

Re: r293518 - [ASTMatchers] Sprinkle some constexpr on the global matcher constructors.

Hi Benjamin, This commit has caused a linking in our stage 2 modules buildbot at http://lab.llvm.org:8080/green/job/clang-stage2-cmake-modulesRDA/. Specifically, after this commit 'clang-reorder-fields' gets the following linking error: FAILED: bin/clang-reorder-fields : &&