Re: r295150 - [Sema] Disallow returning a __block variable via a move.

2017-02-15 Thread Hans Wennborg via cfe-commits
On Wed, Feb 15, 2017 at 12:17 PM, Richard Smith wrote: > On 15 February 2017 at 11:50, Hans Wennborg wrote: >> >> +Richard for risk/reward analysis. > > > This is an extremely safe change, and fixes what amounts to a subtle > miscompile. I think we

Re: r295150 - [Sema] Disallow returning a __block variable via a move.

2017-02-15 Thread Richard Smith via cfe-commits
On 15 February 2017 at 11:50, Hans Wennborg wrote: > +Richard for risk/reward analysis. > This is an extremely safe change, and fixes what amounts to a subtle miscompile. I think we should take it. > r274291 was also in 3.9, so this isn't strictly speaking a regression. > >

Re: r295150 - [Sema] Disallow returning a __block variable via a move.

2017-02-15 Thread Hans Wennborg via cfe-commits
+Richard for risk/reward analysis. r274291 was also in 3.9, so this isn't strictly speaking a regression. On Wed, Feb 15, 2017 at 11:43 AM, Akira Hatanaka wrote: > Hans, > > Can this be merged to 4.0 too? > >> On Feb 14, 2017, at 9:15 PM, Akira Hatanaka via cfe-commits >>

Re: r295150 - [Sema] Disallow returning a __block variable via a move.

2017-02-15 Thread Akira Hatanaka via cfe-commits
Hans, Can this be merged to 4.0 too? > On Feb 14, 2017, at 9:15 PM, Akira Hatanaka via cfe-commits > wrote: > > Author: ahatanak > Date: Tue Feb 14 23:15:28 2017 > New Revision: 295150 > > URL: http://llvm.org/viewvc/llvm-project?rev=295150=rev > Log: > [Sema]