Re: r309226 - Headers: improve ARM EHABI coverage of unwind.h

I've reverted this (along with r309327) from the 5.0 branch in r311597. On Tue, Aug 22, 2017 at 11:10 AM, Hans Wennborg wrote: > Is there a bug filed? Since this was merged to 5.0.0, I'd like to know > if we broke something and if that is something that needs to be fixed. > >

Re: r309226 - Headers: improve ARM EHABI coverage of unwind.h

I believe that it is merely a compile-time issue (warning), it doesn't prevent the use of compiler-rt on ARM as a libgcc replacement. I need to understand why my attempt to remove the `struct` modifier failed on one of the buildbots. On Tue, Aug 22, 2017 at 2:45 PM, Evgenii Stepanov

Re: r309226 - Headers: improve ARM EHABI coverage of unwind.h

No. I don't have a easy way of reproducing this. On Tue, Aug 22, 2017 at 11:10 AM, Hans Wennborg wrote: > Is there a bug filed? Since this was merged to 5.0.0, I'd like to know > if we broke something and if that is something that needs to be fixed. > > On Tue, Aug 22, 2017 at

Re: r309226 - Headers: improve ARM EHABI coverage of unwind.h

Is there a bug filed? Since this was merged to 5.0.0, I'd like to know if we broke something and if that is something that needs to be fixed. On Tue, Aug 22, 2017 at 10:46 AM, Evgenii Stepanov wrote: > As I understand, using compiler-rt as libgcc replacement on ARM is

Re: r309226 - Headers: improve ARM EHABI coverage of unwind.h

As I understand, using compiler-rt as libgcc replacement on ARM is currently broken because of this change, but I have not looked since my last message. On Mon, Aug 21, 2017 at 4:56 PM, Hans Wennborg wrote: > Is there something we need for 5.0.0 here? > > On Sat, Aug 12, 2017

Re: r309226 - Headers: improve ARM EHABI coverage of unwind.h

Is there something we need for 5.0.0 here? On Sat, Aug 12, 2017 at 9:58 PM, Saleem Abdulrasool wrote: > Yeah, we should adjust that. Technically, it is `_Unwind_Control_Block on > ARM EHABI. However, _Unwind_Exception is aliased to that, which is why we > can use that in

Re: r309226 - Headers: improve ARM EHABI coverage of unwind.h

Yeah, we should adjust that. Technically, it is `_Unwind_Control_Block on ARM EHABI. However, _Unwind_Exception is aliased to that, which is why we can use that in the personality routine. We should adjust the sources for the personality routine. On Fri, Aug 11, 2017 at 1:12 PM, Evgenii

Re: r309226 - Headers: improve ARM EHABI coverage of unwind.h

Hi, I've noticed that the code in compiler-rt/lib/builtins/gcc_personality_v0.c refers to _Unwind_Exception as "struct _Unwind_Exception". With this change, it is not a struct anymore on ARM. Should that code be fixed, or is it a problem in this change?

Re: r309226 - Headers: improve ARM EHABI coverage of unwind.h

Merged to 5.0 in r309290. On Wed, Jul 26, 2017 at 3:55 PM, Saleem Abdulrasool via cfe-commits wrote: > Author: compnerd > Date: Wed Jul 26 15:55:23 2017 > New Revision: 309226 > > URL: http://llvm.org/viewvc/llvm-project?rev=309226=rev > Log: > Headers: improve ARM