Re: r310403 - Thread Safety Analysis: warn on nonsensical attributes.

Thanks! On Fri, Aug 11, 2017 at 4:56 PM Josh Gao wrote: > Reverted in r310698. > > On Fri, Aug 11, 2017 at 12:51 AM, Josh Gao wrote: > >> Sorry for the breakage, I'm reverting the patch that caused this now. >> >> On Fri, Aug 11, 2017 at 12:36 AM, NAKAMURA

Re: r310403 - Thread Safety Analysis: warn on nonsensical attributes.

Reverted in r310698. On Fri, Aug 11, 2017 at 12:51 AM, Josh Gao wrote: > Sorry for the breakage, I'm reverting the patch that caused this now. > > On Fri, Aug 11, 2017 at 12:36 AM, NAKAMURA Takumi > wrote: > >> It causes failure in check-libcxx with

Re: r310403 - Thread Safety Analysis: warn on nonsensical attributes.

Sorry for the breakage, I'm reverting the patch that caused this now. On Fri, Aug 11, 2017 at 12:36 AM, NAKAMURA Takumi wrote: > It causes failure in check-libcxx with just-built clang. > > http://bb.pgr.jp/builders/bootstrap-clang-libcxx-lld-i686-linux/builds/758 > > > On

Re: r310403 - Thread Safety Analysis: warn on nonsensical attributes.

It causes failure in check-libcxx with just-built clang. http://bb.pgr.jp/builders/bootstrap-clang-libcxx-lld-i686-linux/builds/758 On Wed, Aug 9, 2017 at 4:45 AM Josh Gao via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: jmgao > Date: Tue Aug 8 12:44:35 2017 > New Revision:

Re: r310403 - Thread Safety Analysis: warn on nonsensical attributes.

Sorry, I meant bin/clang -Wthread-safety-attributes -Wthread-safety-analysis /tmp/tc.cpp -std=c++17 -c -o/dev/null (had -Wthread-safety-attributes twice in the email) George On Thu, Aug 10, 2017 at 4:08 PM, George Burgess IV wrote: > Hello! > > It looks like this

Re: r310403 - Thread Safety Analysis: warn on nonsensical attributes.

Hello! It looks like this is causing buildbot failures related to libc++'s lock_guard and scoped_lock: http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan_check/4070/consoleFull Here's a reduced test-case (from libc++'s __mutex_base): struct __attribute__((capability("mutex"))) mutex {