RE: r324991 - Fix for PR32992. Static const classes not exported.

uel...@intel.com> Cc: cfe-commits <cfe-commits@lists.llvm.org> Subject: Re: r324991 - Fix for PR32992. Static const classes not exported. The problem is that your patch caused the reproducer to trigger an assert, which it didn't do before, causing our builds to break. Your patch seems like

Re: r324991 - Fix for PR32992. Static const classes not exported.

oposed. > > > > Your thoughts? > > > > Thanks. > > -Zahira > > > > > > -Original Message- > From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans > Wennborg > Sent: Monday, February 19, 2018 5:11 AM > To: cfe-comm

RE: r324991 - Fix for PR32992. Static const classes not exported.

ans Wennborg Sent: Monday, February 19, 2018 5:11 AM To: cfe-commits <cfe-commits@lists.llvm.org>; Ammarguellat, Zahira <zahira.ammarguel...@intel.com> Subject: Re: r324991 - Fix for PR32992. Static const classes not exported. Reduced repro: $ clang -cc1 -triple i386-pc-windows-msvc19

Re: r324991 - Fix for PR32992. Static const classes not exported.

Reduced repro: $ clang -cc1 -triple i386-pc-windows-msvc19.11.0 -emit-pch -fms-extensions -fms-compatibility -fms-compatibility-version=19.11 -std=c++14 -fdelayed-template-parsing -x c++-header a.ii -o /dev/null a.ii: namespace a { enum b { c }; } template class d { static constexpr a::b e =

Re: r324991 - Fix for PR32992. Static const classes not exported.

I ended up having to revert this in r325133 as it broke the Chromium build. Please see https://bugs.chromium.org/p/chromium/issues/detail?id=812231#c1 for a reproducer. On Tue, Feb 13, 2018 at 10:19 AM, Hans Wennborg via cfe-commits wrote: > Author: hans > Date: Tue