RE: r325850 - [Darwin] Add a test to check clang produces accelerator tables.

2018-02-23 Thread via cfe-commits 
Hi Davide,
Clang does not have end-to-end tests like this.  To verify we produce the
apple accelerator tables, you want a .ll source in llvm/test/CodeGen/X86.
In the meantime I've reverted the commit in r325920.
Thanks,
--paulr

> -Original Message-
> From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
> Yvan Roux via cfe-commits
> Sent: Friday, February 23, 2018 5:34 AM
> To: Davide Italiano
> Cc: cfe-commits
> Subject: Re: r325850 - [Darwin] Add a test to check clang produces
> accelerator tables.
> 
> Hi Davide,
> 
> 
> This patch broke ARM and AArch64 bots (x86_64 apple targets are not
> available on these bots).
> Logs are available here:
> http://lab.llvm.org:8011/builders/clang-cmake-armv7-
> a15/builds/15940/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Adebug-
> info-section-macho.c
> 
> Thanks
> Yvan
> 
> On 23 February 2018 at 02:25, Davide Italiano via cfe-commits
> <cfe-commits@lists.llvm.org> wrote:
> > Author: davide
> > Date: Thu Feb 22 17:25:03 2018
> > New Revision: 325850
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=325850=rev
> > Log:
> > [Darwin] Add a test to check clang produces accelerator tables.
> >
> > This test was previously in lldb, and was only checking that clang
> > was emitting the correct section. So, it belongs here and not
> > in the debugger.
> >
> > Added:
> > cfe/trunk/test/CodeGen/debug-info-section-macho.c
> >
> > Added: cfe/trunk/test/CodeGen/debug-info-section-macho.c
> > URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/debug-
> info-section-macho.c?rev=325850=auto
> >
> ==
> 
> > --- cfe/trunk/test/CodeGen/debug-info-section-macho.c (added)
> > +++ cfe/trunk/test/CodeGen/debug-info-section-macho.c Thu Feb 22
> 17:25:03 2018
> > @@ -0,0 +1,16 @@
> > +// Test that clang produces the __apple accelerator tables,
> > +// e.g., __apple_types, correctly.
> > +// RUN: %clang %s -target x86_64-apple-macosx10.13.0 -c -g -o %t-ex
> > +// RUN: llvm-objdump -section-headers %t-ex | FileCheck %s
> > +
> > +int main (int argc, char const *argv[]) { return argc; }
> > +
> > +// CHECK: __debug_str
> > +// CHECK-NEXT: __debug_abbrev
> > +// CHECK-NEXT: __debug_info
> > +// CHECK-NEXT: __debug_ranges
> > +// CHECK-NEXT: __debug_macinfo
> > +// CHECK-NEXT: __apple_names
> > +// CHECK-NEXT: __apple_objc
> > +// CHECK-NEXT: __apple_namespac
> > +// CHECK-NEXT: __apple_types
> >
> >
> > ___
> > cfe-commits mailing list
> > cfe-commits@lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> ___
> cfe-commits mailing list
> cfe-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r325850 - [Darwin] Add a test to check clang produces accelerator tables.

2018-02-23 Thread Davide Italiano via cfe-commits 
Apologies, I'm taking a look now.

On Fri, Feb 23, 2018 at 5:33 AM, Yvan Roux  wrote:
> Hi Davide,
>
>
> This patch broke ARM and AArch64 bots (x86_64 apple targets are not
> available on these bots).
> Logs are available here:
> http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15/builds/15940/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Adebug-info-section-macho.c
>
> Thanks
> Yvan
>
> On 23 February 2018 at 02:25, Davide Italiano via cfe-commits
>  wrote:
>> Author: davide
>> Date: Thu Feb 22 17:25:03 2018
>> New Revision: 325850
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=325850=rev
>> Log:
>> [Darwin] Add a test to check clang produces accelerator tables.
>>
>> This test was previously in lldb, and was only checking that clang
>> was emitting the correct section. So, it belongs here and not
>> in the debugger.
>>
>> Added:
>> cfe/trunk/test/CodeGen/debug-info-section-macho.c
>>
>> Added: cfe/trunk/test/CodeGen/debug-info-section-macho.c
>> URL: 
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/debug-info-section-macho.c?rev=325850=auto
>> ==
>> --- cfe/trunk/test/CodeGen/debug-info-section-macho.c (added)
>> +++ cfe/trunk/test/CodeGen/debug-info-section-macho.c Thu Feb 22 17:25:03 
>> 2018
>> @@ -0,0 +1,16 @@
>> +// Test that clang produces the __apple accelerator tables,
>> +// e.g., __apple_types, correctly.
>> +// RUN: %clang %s -target x86_64-apple-macosx10.13.0 -c -g -o %t-ex
>> +// RUN: llvm-objdump -section-headers %t-ex | FileCheck %s
>> +
>> +int main (int argc, char const *argv[]) { return argc; }
>> +
>> +// CHECK: __debug_str
>> +// CHECK-NEXT: __debug_abbrev
>> +// CHECK-NEXT: __debug_info
>> +// CHECK-NEXT: __debug_ranges
>> +// CHECK-NEXT: __debug_macinfo
>> +// CHECK-NEXT: __apple_names
>> +// CHECK-NEXT: __apple_objc
>> +// CHECK-NEXT: __apple_namespac
>> +// CHECK-NEXT: __apple_types
>>
>>
>> ___
>> cfe-commits mailing list
>> cfe-commits@lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits



-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r325850 - [Darwin] Add a test to check clang produces accelerator tables.

2018-02-23 Thread Yvan Roux via cfe-commits 
Hi Davide,


This patch broke ARM and AArch64 bots (x86_64 apple targets are not
available on these bots).
Logs are available here:
http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15/builds/15940/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Adebug-info-section-macho.c

Thanks
Yvan

On 23 February 2018 at 02:25, Davide Italiano via cfe-commits
 wrote:
> Author: davide
> Date: Thu Feb 22 17:25:03 2018
> New Revision: 325850
>
> URL: http://llvm.org/viewvc/llvm-project?rev=325850=rev
> Log:
> [Darwin] Add a test to check clang produces accelerator tables.
>
> This test was previously in lldb, and was only checking that clang
> was emitting the correct section. So, it belongs here and not
> in the debugger.
>
> Added:
> cfe/trunk/test/CodeGen/debug-info-section-macho.c
>
> Added: cfe/trunk/test/CodeGen/debug-info-section-macho.c
> URL: 
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/debug-info-section-macho.c?rev=325850=auto
> ==
> --- cfe/trunk/test/CodeGen/debug-info-section-macho.c (added)
> +++ cfe/trunk/test/CodeGen/debug-info-section-macho.c Thu Feb 22 17:25:03 2018
> @@ -0,0 +1,16 @@
> +// Test that clang produces the __apple accelerator tables,
> +// e.g., __apple_types, correctly.
> +// RUN: %clang %s -target x86_64-apple-macosx10.13.0 -c -g -o %t-ex
> +// RUN: llvm-objdump -section-headers %t-ex | FileCheck %s
> +
> +int main (int argc, char const *argv[]) { return argc; }
> +
> +// CHECK: __debug_str
> +// CHECK-NEXT: __debug_abbrev
> +// CHECK-NEXT: __debug_info
> +// CHECK-NEXT: __debug_ranges
> +// CHECK-NEXT: __debug_macinfo
> +// CHECK-NEXT: __apple_names
> +// CHECK-NEXT: __apple_objc
> +// CHECK-NEXT: __apple_namespac
> +// CHECK-NEXT: __apple_types
>
>
> ___
> cfe-commits mailing list
> cfe-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits