On Wed, Apr 11, 2018 at 10:16 AM Haojian Wu via cfe-commits < cfe-commits@lists.llvm.org> wrote:
> Author: hokein > Date: Wed Apr 11 01:13:07 2018 > New Revision: 329784 > ... > > ============================================================================== > --- cfe/trunk/include/clang/Tooling/Execution.h (original) > +++ cfe/trunk/include/clang/Tooling/Execution.h Wed Apr 11 01:13:07 2018 > > @@ -45,20 +46,30 @@ class ToolResults { > public: > virtual ~ToolResults() = default; > virtual void addResult(StringRef Key, StringRef Value) = 0; > - virtual std::vector<std::pair<std::string, std::string>> AllKVResults() > = 0; > + virtual std::vector<std::pair<llvm::StringRef, llvm::StringRef>> > + AllKVResults() = 0; > I would add a comment re: lifetime of the strings pointed by the return value.
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits