Re: r334418 - Enable crash recovery tests on Windows, globs work in the lit internal shell now

2018-06-12 Thread Reid Kleckner via cfe-commits
On Tue, Jun 12, 2018 at 4:43 AM Hans Wennborg wrote: > Actually, maybe switching the order from "not env ... %clang" to "env > ... not %clang" might work... > Thanks, I was going to try that next. ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r334418 - Enable crash recovery tests on Windows, globs work in the lit internal shell now

2018-06-12 Thread Hans Wennborg via cfe-commits
On Tue, Jun 12, 2018 at 1:43 PM, Hans Wennborg wrote: > I've reverted in r334493 in the meantime. > > When I run the tests locally, they fail with: > > # command stderr: > C:\src\llvm\tools\clang\test\Driver\crash-report.c:17:11: error: > expected string not found in input > // CHECK: Preprocessed

Re: r334418 - Enable crash recovery tests on Windows, globs work in the lit internal shell now

2018-06-12 Thread Hans Wennborg via cfe-commits
r...@google.com >> Cc: cfe-commits@lists.llvm.org >> Subject: RE: r334418 - Enable crash recovery tests on Windows, globs >> work in the lit internal shell now >> >> Hi Reid, >> >> I don't know if you noticed, but one of the tests you changed with this >

RE: r334418 - Enable crash recovery tests on Windows, globs work in the lit internal shell now

2018-06-11 Thread via cfe-commits
s-boun...@lists.llvm.org] On Behalf > Of via cfe-commits > Sent: Monday, June 11, 2018 18:37 > To: r...@google.com > Cc: cfe-commits@lists.llvm.org > Subject: RE: r334418 - Enable crash recovery tests on Windows, globs > work in the lit internal shell now > > Hi Reid, &g

RE: r334418 - Enable crash recovery tests on Windows, globs work in the lit internal shell now

2018-06-11 Thread via cfe-commits
Hi Reid, I don't know if you noticed, but one of the tests you changed with this commit is failing on the PS4 Windows bot. Can you take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/17695/ FAIL: Clang :: Driver/crash-report-modules.m (7229 of