Re: r343285 - [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only

2018-10-04 Thread Stephan Bergmann via cfe-commits
On 04/10/2018 01:14, Richard Smith wrote: On Tue, 2 Oct 2018 at 01:18, Stephan Bergmann via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: On 28/09/2018 03:16, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Thu Sep 27 18:16:43 2018 > New Revision:

Re: r343285 - [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only

2018-10-03 Thread Richard Smith via cfe-commits
On Tue, 2 Oct 2018 at 01:18, Stephan Bergmann via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On 28/09/2018 03:16, Richard Smith via cfe-commits wrote: > > Author: rsmith > > Date: Thu Sep 27 18:16:43 2018 > > New Revision: 343285 > > > > URL:

Re: r343285 - [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only

2018-10-02 Thread Hans Wennborg via cfe-commits
On Tue, Oct 2, 2018 at 12:02 PM, Hans Wennborg wrote: > I'm confused about what implicitly deleted means. In this code for example: > > struct S { > S(const S&) = default; > S& operator=(const S&) = default; > const int x; > }; > > void f(S ) { > S t = s; > } > > Clang will warn that

Re: r343285 - [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only

2018-10-02 Thread Hans Wennborg via cfe-commits
I'm confused about what implicitly deleted means. In this code for example: struct S { S(const S&) = default; S& operator=(const S&) = default; const int x; }; void f(S ) { S t = s; } Clang will warn that operator= is implicitly deleted. But it seems the code still works fine, whereas

Re: r343285 - [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only

2018-10-02 Thread Stephan Bergmann via cfe-commits
On 28/09/2018 03:16, Richard Smith via cfe-commits wrote: Author: rsmith Date: Thu Sep 27 18:16:43 2018 New Revision: 343285 URL: http://llvm.org/viewvc/llvm-project?rev=343285=rev Log: [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only render the function deleted instead of

Re: r343285 - [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only

2018-09-28 Thread Vitaly Buka via cfe-commits
https://reviews.llvm.org/rL343369 On Fri, Sep 28, 2018 at 4:51 PM Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello Richard, > > This commit broke couple of our builders: > > http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/12924 >

Re: r343285 - [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only

2018-09-28 Thread Galina Kistanova via cfe-commits
Hello Richard, This commit broke couple of our builders: http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/12924 http://lab.llvm.org:8011/builders/clang-with-lto-ubuntu/builds/10475 . . . FAILED:

r343285 - [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only

2018-09-27 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Sep 27 18:16:43 2018 New Revision: 343285 URL: http://llvm.org/viewvc/llvm-project?rev=343285=rev Log: [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only render the function deleted instead of rendering the program ill-formed. This change also adds an