Re: r361033 - Add a Visit overload for DynTypedNode to ASTNodeTraverser

2019-05-17 Thread Nico Weber via cfe-commits
*From: *Stephen Kelly via cfe-commits *Date: *Fri, May 17, 2019 at 1:56 PM *To: *Yitzhak Mandelbaum *Cc: *cfe-commits Hmm, thanks for letting me know! > > Is that an old compiler? > > I'm not near a computer for the weekend. > > Can someone fix or revert? > Sure, reverted in 361059. > >

r361059 - Revert r361033 "Add a Visit overload for DynTypedNode to ASTNodeTraverser"

2019-05-17 Thread Nico Weber via cfe-commits
Author: nico Date: Fri May 17 11:31:24 2019 New Revision: 361059 URL: http://llvm.org/viewvc/llvm-project?rev=361059=rev Log: Revert r361033 "Add a Visit overload for DynTypedNode to ASTNodeTraverser" It fails to build on some bots. Also revert follow-up r361055. Removed:

Re: r361033 - Add a Visit overload for DynTypedNode to ASTNodeTraverser

2019-05-17 Thread Yitzhak Mandelbaum via cfe-commits
i'll see if i can repro on my build and fix if so. On Fri, May 17, 2019 at 1:56 PM Stephen Kelly wrote: > Hmm, thanks for letting me know! > > Is that an old compiler? > > I'm not near a computer for the weekend. > > Can someone fix or revert? > > Thanks, > > Stephen. > > On Fri 17 May 2019,

Re: r361033 - Add a Visit overload for DynTypedNode to ASTNodeTraverser

2019-05-17 Thread Stephen Kelly via cfe-commits
Hmm, thanks for letting me know! Is that an old compiler? I'm not near a computer for the weekend. Can someone fix or revert? Thanks, Stephen. On Fri 17 May 2019, 17:11 Yitzhak Mandelbaum, wrote: > Looks like this caused a breakage: >

Re: r361033 - Add a Visit overload for DynTypedNode to ASTNodeTraverser

2019-05-17 Thread Yitzhak Mandelbaum via cfe-commits
Looks like this caused a breakage: http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/18641/steps/ninja%20check%201/logs/stdio On Fri, May 17, 2019 at 9:52 AM Stephen Kelly via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: steveire > Date: Fri May 17 06:55:28 2019 >

r361033 - Add a Visit overload for DynTypedNode to ASTNodeTraverser

2019-05-17 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Fri May 17 06:55:28 2019 New Revision: 361033 URL: http://llvm.org/viewvc/llvm-project?rev=361033=rev Log: Add a Visit overload for DynTypedNode to ASTNodeTraverser Reviewers: aaron.ballman Subscribers: cfe-commits Tags: #clang Differential Revision: