Re: /about redirected to /about/

2015-08-13 Thread Daniel Reichelt
Hi Jason, Please let me know if this poses any problems. I'm afraid, it does here: Requesting a document works, however a request to /cgit/$repo.git/about/ gets 301'd to /cgit/$repo.git/about/ until firefox throws up. I added some debug printing to cmd.c:about_pre():

Re: /about redirected to /about/

2015-08-13 Thread Jason A. Donenfeld
Hey Daniel, Can you hop on IRC and debug this interactively with me? #cgit on freenode. I'm zx2c4. Jason ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH] add new option atom-root

2015-08-13 Thread Daniel Reichelt
You yourself got me thinking about this (see previous archive link) :) The problem is, we don't know how different browsers would call external feed reader programs a) with the correctly assembled feed url b) dumb as hell with just the relative part...

Re: [PATCH] add new option atom-root

2015-08-13 Thread Jason A. Donenfeld
Wouldn't it be better to just use a relative URL? ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

[PATCH 8/8] filter: don't use dlsym unnecessarily

2015-08-13 Thread John Keeping
We only need to hook write() if Lua filter's are in use. If support has been disabled, remove the dependency on dlsym(). Signed-off-by: John Keeping j...@keeping.me.uk --- filter.c | 78 ++-- 1 file changed, 42 insertions(+), 36

[PATCH 4/8] configfile.c: don't include system headers directly

2015-08-13 Thread John Keeping
git-compat-util.h may define various values that affect the interpretation of system headers. In most places we include cgit.h first, which pulls in git-compat-util.h, but this file does not depend on anything else in CGit, so use git-compat-util.h directly. Signed-off-by: John Keeping

[PATCH 0/8] Portability fixes

2015-08-13 Thread John Keeping
This is a collection of vaguely-related changes that make us take fuller advantage of git.git's support for a variety of platform so that we build more reliably out of the box. The header ordering issue is definitely painful on Solaris where the system headers define _FILE_OFFSET_BITS=32 if it's

[PATCH 7/8] ui-tree: use sane isgraph()

2015-08-13 Thread John Keeping
Git's git-compat-util.h defines a sane ctype that does not use locale information and works with signed chars, but it does not include isgraph() so we have included ctype.h ourselves. However, this means we have to include a system header before git-compat-util.h which may lead to the system

[PATCH 1/8] tests: allow shell to be overridden

2015-08-13 Thread John Keeping
On some systems (e.g. Solaris), /bin/sh is not a POSIX shell. Git already provides suitable overrides in its config.mak.uname file and we provide cgit.conf to allow the user to further change this. The code for this is taken from Git's t/Makefile, meaning that we now invoke the tests in the same

[PATCH 5/8] cache.c: fix header order

2015-08-13 Thread John Keeping
git-compat-util.h may define values that affect how system headers are interpreted, so move sys/sendfile.h after cgit.h (which includes git-compat-util.h). Signed-off-by: John Keeping j...@keeping.me.uk --- cache.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cache.c

[PATCH 3/8] Remove redundant includes

2015-08-13 Thread John Keeping
These are all included in git-compat-util.h (when necessary), which we include in cgit.h. Signed-off-by: John Keeping j...@keeping.me.uk --- filter.c | 6 -- html.c| 6 -- shared.c | 1 - ui-plain.c| 1 - ui-repolist.c | 1 - ui-summary.c | 1 - 6 files changed, 16

[PATCH 3/3] ui-shared: show full date in tooltip if longer ago than max_relative

2015-08-13 Thread John Keeping
Commit caed6cb (ui-shared: show absolute time in tooltip for relative dates, 2014-12-20) added a toolip when we show a relative time. However, in some cases we show a short date (that is, the date but not the time) if an event was sufficiently far in the past and that commit did not update that

Re: Fwd: Build failed in Jenkins: cgit - upstream - get-git - master #190 - remotes/origin/master - a360666

2015-08-13 Thread Ferry Huberts
Maybe you guys can check my build server after merging commits? :-) It runs Fedora 22, x86_64 On 13/08/15 16:28, Ferry Huberts wrote: Forwarded Message Subject:Build failed in Jenkins: cgit - upstream - get-git - master #190 - remotes/origin/master - a360666 Date:

Fwd: Build failed in Jenkins: cgit - upstream - get-git - master #190 - remotes/origin/master - a360666

2015-08-13 Thread Ferry Huberts
Forwarded Message Subject: Build failed in Jenkins: cgit - upstream - get-git - master #190 - remotes/origin/master - a360666 Date: Thu, 13 Aug 2015 15:43:11 +0200 (CEST) From: Pelagic Jenkins (Public) nore...@jenkins-public.pelagic.nl To: ferry.hube...@pelagic.nl

Re: [PATCH 0/8] Portability fixes

2015-08-13 Thread Jason A. Donenfeld
Merged, thanks. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: Build failed in Jenkins: cgit - upstream - get-git - master #190 - remotes/origin/master - a360666

2015-08-13 Thread Jason A. Donenfeld
Thanks for the fix John. All set now. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: Build failed in Jenkins: cgit - upstream - get-git - master #190 - remotes/origin/master - a360666

2015-08-13 Thread Ferry Huberts
I've talked to Jason and from now on my build server will also send email to the cgit-dev list upon build failures. That might give some noise when I'm fiddling with the build server, but I'll try to avoid that. On 13/08/15 17:05, Jason A. Donenfeld wrote: Thanks for the fix John. All set