Coverity + Jenkins

Hey Ferry, As you probably noticed, I've added cgit to Coverity's scanner. I'm still waiting for them to "approve" it as an authentic grass-fed no-GMO open source project, but once that happens, we'll have a host of bugs to inspect. It appears they've got some scripts and things for automating

Re: Coverity + Jenkins

On 08/10/15 22:56, Christian Hesse wrote: "Jason A. Donenfeld" on Thu, 2015/10/08 16:33: As you probably noticed, I've added cgit to Coverity's scanner. I'm still waiting for them to "approve" it as an authentic grass-fed no-GMO open source project, but once that happens,

[PATCH 0/4] Initial Coverity fixes

All of the issues addressed here are harmless, but it will let us see what happens when we fix problems identified by Coverity. I also marked a couple of problems as false positives in the interface, but someone should double-check those. John Keeping (4): cgit.c: remove useless null check

[PATCH 1/4] cgit.c: remove useless null check

Everywhere else in this function we do not check whether the value is null and parse_configfile() never passes a null value to this callback. Coverity-id: 13846 Signed-off-by: John Keeping --- cgit.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 3/4] ui-blob: remove useless null check

We have already called strlen() on "path" by the time we get here, so we know it can't be null. Coverity-id: 13954 Signed-off-by: John Keeping --- ui-blob.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui-blob.c b/ui-blob.c index b333f86..d3c3a10

[PATCH 4/4] ui-refs: remove useless null check

There is no way that "tag" can be null here. Coverity-id: 13950 Signed-off-by: John Keeping --- ui-refs.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui-refs.c b/ui-refs.c index be3572c..295a4c7 100644 --- a/ui-refs.c +++ b/ui-refs.c @@ -135,7

Re: Coverity + Jenkins

The majority of them are from git. There's a way to organize the code into modules so that we don't have to look at the git bugs though. I'll investigate this tomorrow, unless someone beats me to it. ___ CGit mailing list CGit@lists.zx2c4.com