Re: [PATCH v5 6/6] line-range-highlight: copy URL to clipboard UI

2018-06-27 Thread Andy Green
On 06/28/2018 07:30 AM, Jason A. Donenfeld wrote: On Thu, Jun 28, 2018 at 1:24 AM Andy Green wrote: Can you help me understand what is "clearly superior" and "right way" about the [...] menu in github? Since you seem to be asking me to implement it? What put me off it was there's only one

Re: [PATCH v5 6/6] line-range-highlight: copy URL to clipboard UI

2018-06-27 Thread Jason A. Donenfeld
On Thu, Jun 28, 2018 at 1:24 AM Andy Green wrote: > Can you help me understand what is "clearly superior" and "right way" > about the [...] menu in github? > > Since you seem to be asking me to implement it? > > What put me off it was there's only one useful option on it, and it > requires and

Re: [PATCH v5 6/6] line-range-highlight: copy URL to clipboard UI

2018-06-27 Thread Andy Green
On 06/28/2018 02:07 AM, Jason A. Donenfeld wrote: Nack. If we're going to add something like this, the github GUI for it is clearly superior and the right way of going about things, with the elegant [...] menu. "Nack"... Can you help me understand what is "clearly superior" and "right way"

Re: [PATCH v5 6/6] line-range-highlight: copy URL to clipboard UI

2018-06-27 Thread Jason A. Donenfeld
Nack. If we're going to add something like this, the github GUI for it is clearly superior and the right way of going about things, with the elegant [...] menu. Jason ___ CGit mailing list CGit@lists.zx2c4.com

[PATCH v5 6/6] line-range-highlight: copy URL to clipboard UI

2018-06-26 Thread Andy Green
Clicking on the line numbers to control the highlight now causes a clipboard icon to appear to the left of the line for 5s. Clicking this will copy the highlight URL to the clipboard, and cause the icon to grow, blur and fade to acknowledge the click. After 5s the clipboard icon will fade out...