Re: RFC: snapshot tarball information in refs/notes/snapshots

2018-03-30 Thread Konstantin Ryabitsev
On Fri, Mar 30, 2018 at 05:38:29PM +0100, John Keeping wrote: > > One other way I'd thought about doing this is via a post-update hook > > that would read the configuration from an object in the repo into a file > > cgit could read, but I didn't want to write out into .git/config. > > > > That mig

Re: RFC: snapshot tarball information in refs/notes/snapshots

2018-03-30 Thread John Keeping
On Fri, Mar 30, 2018 at 11:38:38AM -0400, Konstantin Ryabitsev wrote: > On Fri, Mar 30, 2018 at 12:53:57PM +0100, John Keeping wrote: > > Unfortunately there is one big gotcha I encountered doing this, which is > > that we don't have the repository set up when we are scanning this > > configuration

Re: RFC: snapshot tarball information in refs/notes/snapshots

2018-03-30 Thread Konstantin Ryabitsev
On Fri, Mar 30, 2018 at 12:53:57PM +0100, John Keeping wrote: > Unfortunately there is one big gotcha I encountered doing this, which is > that we don't have the repository set up when we are scanning this > configuration, because this is done when building the repository list > not just for loadin

Re: RFC: snapshot tarball information in refs/notes/snapshots

2018-03-30 Thread John Keeping
On Wed, Mar 21, 2018 at 10:03:11AM -0400, Konstantin Ryabitsev wrote: > It would be easy to load and parse refs/notes/cgitrc, and the security > implications shouldn't be much different than loading the same from > gitconfig. Based on this comment, I had a go at just wiring up config parsing to th

Re: RFC: snapshot tarball information in refs/notes/snapshots

2018-03-21 Thread Konstantin Ryabitsev
On Wed, Mar 21, 2018 at 09:38:02AM -0300, Jason A. Donenfeld wrote: That sounds like a potentially good idea. Though it does point to the larger question: should notes be used in general for configuring more parts of cgit in an ad-hoc manner? Is there a useful generalization of this mechanism we

Re: RFC: snapshot tarball information in refs/notes/snapshots

2018-03-21 Thread Jason A. Donenfeld
Hey Konstantin, That sounds like a potentially good idea. Though it does point to the larger question: should notes be used in general for configuring more parts of cgit in an ad-hoc manner? Is there a useful generalization of this mechanism we should consider? We already have four different confi

RFC: snapshot tarball information in refs/notes/snapshots

2018-03-20 Thread Konstantin Ryabitsev
Hi, all: I'd like to propose a feature in CGit that would allow providing additional information within the repository to better create the tarball, when snapshot downloads are enabled. Let's take for example: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git I would like