Re: [PATCH] ui-patch: Flush stdout after outputting data

2014-06-11 Thread John Keeping
On Wed, Jun 11, 2014 at 04:28:26PM -0400, Konstantin Ryabitsev wrote: > On 11/06/14 04:01 PM, John Keeping wrote: > > Since the "html" functions use raw write(2) to STDIO_FILENO, we don't > > notice problems with most pages, but raw patches write using printf(3). > > This is fine if we're outputtin

Re: [PATCH] ui-patch: Flush stdout after outputting data

2014-06-11 Thread Konstantin Ryabitsev
On 11/06/14 04:01 PM, John Keeping wrote: > Since the "html" functions use raw write(2) to STDIO_FILENO, we don't > notice problems with most pages, but raw patches write using printf(3). > This is fine if we're outputting straight to stdout since the buffers > are flushed on exit, but we close the

[PATCH] ui-patch: Flush stdout after outputting data

2014-06-11 Thread John Keeping
Since the "html" functions use raw write(2) to STDIO_FILENO, we don't notice problems with most pages, but raw patches write using printf(3). This is fine if we're outputting straight to stdout since the buffers are flushed on exit, but we close the cache output before this, so the cached output en

Cache bug: cached patches truncated to nearest 1024-byte boundary

2014-06-11 Thread Konstantin Ryabitsev
Hi, all: It looks like cached patches are truncated to the nearest 1024-byte boundary in the patch body. E.g.: > mricon@nikko:[/tmp]$ wget -O no-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=6e1b4fdad5157bb9e88777d525704aba24389bee"; ... > 2014-06-11 15:34:51