On Fri, Jan 10, 2014 at 3:11 AM, Jason A. Donenfeld wrote:
> Problems abound. This has race condition issues, where the parent
> process will SIGSTOP the child before the child can write its output.
> This could be fixed with a more complicated signaling protocol, but
> that's more complex than I'
On Fri, Jan 10, 2014 at 2:41 AM, Jason A. Donenfeld wrote:
> and does its thing per usual. At the end, however, it does not exit.
> Instead of waitpid()ing on it in close filter, we SIGSTOP it, put the
> fds back in place, etc. Then the next time that filter is called, we
> SIGCONT it, it reads th
On Thu, Jan 9, 2014 at 11:58 PM, John Keeping wrote:
>
> That interface doesn't really match the way the current filters work.
Yes, hence the post.
> We could swap out write with a function pointer
> into the filter, but I don't think we guarantee that all of the data is
> written in one go whi
On Thu, Jan 09, 2014 at 10:34:26PM +0100, Jason A. Donenfeld wrote:
> I'm thinking about this filtering situation w.r.t. gravatar and
> potentially running multiple filters on one page. Something I've been
> considering is implementing a simple dlopen() mechanism for filters,
> if the filter filena
On 09/01/14 22:34, Jason A. Donenfeld wrote:
Hey folks,
I'm thinking about this filtering situation w.r.t. gravatar and
potentially running multiple filters on one page. Something I've been
considering is implementing a simple dlopen() mechanism for filters,
if the filter filename starts with
Hey folks,
I'm thinking about this filtering situation w.r.t. gravatar and
potentially running multiple filters on one page. Something I've been
considering is implementing a simple dlopen() mechanism for filters,
if the filter filename starts with "soname:" or "lib:" or similar, so
as to avoid th
- Switched back to python2 according to a problem in pygments with python3.
With the next release of pygments this problem should be fixed.
Issue see here:
https://bitbucket.org/birkenfeld/pygments-main/issue/901/problems-with-python3
- Just read the stdin, decode it to utf-8 and ignore unkno
On Thu, Jan 09, 2014 at 08:26:24PM +0100, Lukas Fleischer wrote:
> On Thu, 09 Jan 2014 at 19:01:42, John Keeping wrote:
> > On Thu, Jan 09, 2014 at 04:13:08PM +0100, Jason A. Donenfeld wrote:
> > > On Thu, Jan 9, 2014 at 8:30 AM, Lukas Fleischer
> > > wrote:
> > > > We depend on Git in the test s
Am 08.01.2014 17:28, schrieb Jason A. Donenfeld:
>> What do you want to de with the CSS definitions? Just put them into the
>> default cgit CSS file or maybe include it seperately?
>
> We already handle that on line 34 of [1], so no need to do anything
> differently. Please base your work off [1]
On Wed, 08 Jan 2014 at 15:34:10, Jason A. Donenfeld wrote:
> Hey folks,
>
> To speed things up with the merges and reviews of patches on this
> list, I've given Lukas Fleischer commit access. He's going to be
> helping me maintain the project. We'll each be merging and committing
> patches to jd/s
On Thu, 09 Jan 2014 at 20:23:04, John Keeping wrote:
> [...]
> Presumably this would just pass the "A. U. Thor "
> string to the filter and we could just map that to the output.
> [...]
> We could take an incremental approach like git-check-attr and friends do
> when GIT_FLUSH=1, but I'm not sure h
On Thu, 09 Jan 2014 at 19:01:42, John Keeping wrote:
> On Thu, Jan 09, 2014 at 04:13:08PM +0100, Jason A. Donenfeld wrote:
> > On Thu, Jan 9, 2014 at 8:30 AM, Lukas Fleischer wrote:
> > > We depend on Git in the test suite. Maybe this should be changed to use
> > > the binary from the Git submodul
On Thu, Jan 09, 2014 at 07:59:27PM +0100, Jason A. Donenfeld wrote:
> On Thu, Jan 9, 2014 at 7:07 PM, John Keeping wrote:
> > It feels to me like it might be better to allow a filter to be applied
> > here. That way we don't put the Gravatar code in CGit itself but can
> > distribute an example s
On Thu, Jan 9, 2014 at 7:07 PM, John Keeping wrote:
> It feels to me like it might be better to allow a filter to be applied
> here. That way we don't put the Gravatar code in CGit itself but can
> distribute an example script that does apply Gravatar links to email
> addresses.
>
> I'm not sure
Merged.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
* Remove the dependency on Git (which can be obtained automatically when
building, using either the Git submodule or `make get-git`).
* Use proper upstream names of dependencies.
Signed-off-by: Lukas Fleischer
---
README | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
On Thu, Jan 09, 2014 at 06:50:29PM +0100, Jason A. Donenfeld wrote:
> On Thu, Jan 9, 2014 at 4:21 PM, Konstantin Ryabitsev
> wrote:
> > That's pretty nifty.
>
> Cool. Would you consider enabling this on kernel.org? I'll probably
> merge it in a few days (still working out some bugs). Seems like
On Thu, Jan 09, 2014 at 04:13:08PM +0100, Jason A. Donenfeld wrote:
> On Thu, Jan 9, 2014 at 8:30 AM, Lukas Fleischer wrote:
> > We depend on Git in the test suite. Maybe this should be changed to use
> > the binary from the Git submodule instead?
>
> I think we discussed the possibility of this
On Thu, Jan 9, 2014 at 4:21 PM, Konstantin Ryabitsev wrote:
> That's pretty nifty.
Cool. Would you consider enabling this on kernel.org? I'll probably
merge it in a few days (still working out some bugs). Seems like the
kind of thing that might give cgit a lot of positive attention...
> That rem
On 08/01/14 12:29 PM, Jason A. Donenfeld wrote:
> It's being previewed on http://git.zx2c4.com/cgit/
>
> What do you think?
Hi, all:
That's pretty nifty. That reminds me -- I'm working on a web-of-trust
site for kernel.org and something I wouldn't mind having is a way to
link from cgit to the we
On Thu, Jan 9, 2014 at 10:18 AM, Christian Hesse wrote:
> You modified the code to make the icon match the font size, which is 10pt by
> default. This is hard coded to the css file. Please note the URL includes a
> size argument. Does it make sense to just retrieve a 10x10 pixel image?
Generally,
On Thu, Jan 9, 2014 at 9:52 AM, Christian Hesse wrote:
>
> Looks like you have applied this with your changes to jd/zx2c4-deployment. I
> am fine with that. Or do you want an updated patch from me?
It's okay; I've got it handled.
___
CGit mailing list
C
On Thu, Jan 9, 2014 at 8:30 AM, Lukas Fleischer wrote:
> We depend on Git in the test suite. Maybe this should be changed to use
> the binary from the Git submodule instead?
I think we discussed the possibility of this a while ago with John.
This would make most sense to me, though we are using g
"Jason A. Donenfeld" on Wed, 2014/01/08 18:29:
> It's being previewed on http://git.zx2c4.com/cgit/
>
> What do you think?
You modified the code to make the icon match the font size, which is 10pt by
default. This is hard coded to the css file. Please note the URL includes a
size argument. Does
"Jason A. Donenfeld" on Wed, 2014/01/08 17:00:
> Sorry for the extended nitpicks
>
> On Wed, Jan 8, 2014 at 4:23 PM, Christian Hesse wrote:
> > +char *cgit_get_gravatar(const char *email)
> > +{
> > +
> > + /* duplicate to lower and skip brackets! */
> > + lower = strdup(email +
"Jason A. Donenfeld" on Wed, 2014/01/08 16:56:
> On Wed, Jan 8, 2014 at 4:23 PM, Christian Hesse wrote:
> > + gravatar = malloc(strlen(GRAVATAR_URL) + MD5_DIGEST_LENGTH * 2 +
> > 1);
>
> xmalloc
>
> > + lower = strdup(email + 1);
>
> xstrdup
Looks like you have applied this with y
26 matches
Mail list logo
