Re: cgit-lua: to jit or not to jit

2014-01-14 Thread Justin Cormack
On 14 Jan 2014 03:52, Andrew Starks andrew.sta...@trms.com wrote: On Monday, January 13, 2014, Jason A. Donenfeld wrote: On Tue, Jan 14, 2014 at 3:37 AM, Andrew Starks andrew.sta...@trms.com wrote: I don't have LuaJit installed and would not install it (and migrate everything I do over

Re: lua vs luajit vs both

2014-01-14 Thread John Keeping
On Tue, Jan 14, 2014 at 02:02:40AM +0100, Jason A. Donenfeld wrote: I've gone ahead and merged the lua work to master, for testing and subsequent cleanup before release. Regarding to jit or not to jit, I currently have this fancy autodetection logic:

[PATCH 1/1] fix UTF-8 with email-gravatar.py

2014-01-14 Thread Christian Hesse
--- filters/email-gravatar.py | 4 1 file changed, 4 insertions(+) diff --git a/filters/email-gravatar.py b/filters/email-gravatar.py index f90b87d..5d08ea8 100755 --- a/filters/email-gravatar.py +++ b/filters/email-gravatar.py @@ -20,6 +20,7 @@ import sys import hashlib +import codecs

[PATCH 1/1] fix email-gravatar.lua for lua 5.2

2014-01-14 Thread Christian Hesse
--- filters/email-gravatar.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/filters/email-gravatar.lua b/filters/email-gravatar.lua index 982e030..9feb611 100644 --- a/filters/email-gravatar.lua +++ b/filters/email-gravatar.lua @@ -7,7 +7,7 @@ --

Re: [PATCH v3 2/2] filters: Choose 'trac' theme in pygments

2014-01-14 Thread Stefan Tatschner
Am 14.01.2014 02:33, schrieb Jason A. Donenfeld: Personally, I think the trac colors are a bit ugly. I like pastie best. But this is just preference. I personally also like the 'default' theme it is pretty much the same as 'pastie' but it does not add a background color to strings. This

Idle time in project overview

2014-01-14 Thread Stefan Tatschner
I don't know if it is a bug or a feature but I think on this nice mailing list I could ask without being shot or mutilated. :) If I have a git repository with multiple branches and I push to another branch as 'master' the idle time on the project overview is not updated. I think this behaviour is

[PATCH/RFC] tests/: Add t0111-filter.sh

2014-01-14 Thread Lukas Fleischer
This adds basic tests for all types of exec filters. Signed-off-by: Lukas Fleischer c...@cryptocrack.de --- This only includes tests for exec filters so far. I will send another patch for Lua filters once this one is merged. tests/filters/capitalize-argv1.sh | 3 +++

[PATCH 1/1] fix html syntax in email-gravatar.*

2014-01-14 Thread Christian Hesse
* make ampersand a html entity * add required alt attribute * add required img end tag --- filters/email-gravatar.lua | 2 +- filters/email-gravatar.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/filters/email-gravatar.lua b/filters/email-gravatar.lua index

Re: Idle time in project overview

2014-01-14 Thread John Keeping
On Tue, Jan 14, 2014 at 11:50:23AM +0100, Stefan Tatschner wrote: I don't know if it is a bug or a feature but I think on this nice mailing list I could ask without being shot or mutilated. :) If I have a git repository with multiple branches and I push to another branch as 'master' the idle

Re: [PATCH 1/1] fix email-gravatar.lua for lua 5.2

2014-01-14 Thread Jason A. Donenfeld
Merged, thanks. What exactly is the reason for this change in Lua 5.2? ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/1] fix UTF-8 with email-gravatar.py

2014-01-14 Thread Jason A. Donenfeld
Ahhh Python... *sigh* Merged. Thanks for this. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/1] fix html syntax in email-gravatar.*

2014-01-14 Thread Jason A. Donenfeld
Good catch with amp;. Merged. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH/RFC] tests/: Add t0111-filter.sh

2014-01-14 Thread Jason A. Donenfeld
Terrific! I was hoping something like this would come about. Looking forward to seeing the lua side of things. There's another change I'm going to be pushing later today that involves being able to do meaningful things with the cgit_filter_close() exit code. I'll then be using this to /maybe/

[PATCH] filter: refactor cgit_new_filter()

2014-01-14 Thread Jason A. Donenfeld
From: Lukas Fleischer c...@cryptocrack.de Use prefixcmp() as a preparation for using strip_prefix() later. Also, interpret the command as a file name if it contains a colon but none of the filter prefixes matches instead of bailing out and adding a special check for Windows. Signed-off-by: Lukas

Re: cgit-lua: to jit or not to jit

2014-01-14 Thread Jason A. Donenfeld
On Tue, Jan 14, 2014 at 4:51 AM, Andrew Starks andrew.sta...@trms.com wrote: I also just remembered this: https://github.com/jmckaskill/luaffi Which is a luajit compatible FFI extension for Lua 5.1 and Lua 5.2, but 5.2 is listed as beta. It might be worth a shot, if it lets you gain some of

[PATCH 1/1] filter: fix lua function name

2014-01-14 Thread Christian Hesse
--- filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/filter.c b/filter.c index 44af434..0cce7bb 100644 --- a/filter.c +++ b/filter.c @@ -319,7 +319,7 @@ static int close_lua_filter(struct cgit_filter *base) error_lua_filter(filter); ret

Re: [PATCH 1/1] fix email-gravatar.lua for lua 5.2

2014-01-14 Thread Christian Hesse
Jason A. Donenfeld ja...@zx2c4.com on Tue, 2014/01/14 13:48: Merged, thanks. What exactly is the reason for this change in Lua 5.2? No idea. Just noticed it is broken and fixed it. ;) -- Schoene Gruesse Chris O ascii ribbon campaign stop html mail

Re: [PATCH 1/1] filter: fix lua function name

2014-01-14 Thread Jason A. Donenfeld
Wow you're quick. I pushed and then [improperly] rebased within a matter of 15 seconds. But I guess you caught this anyway. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [RESEND PATCH 1/1] enable cgit to show gravatar for author, committer and tagger

2014-01-14 Thread Jason A. Donenfeld
On Tue, Jan 14, 2014 at 6:22 PM, Christian Hesse l...@eworm.de wrote: Looks better, though not perfect. At least firefox still scales the image a bit. Can you investigate the whole px to pt situation, line-height, and the best way to manage this? ___

Re: [RESEND PATCH 1/1] enable cgit to show gravatar for author, committer and tagger

2014-01-14 Thread Christian Hesse
Jason A. Donenfeld ja...@zx2c4.com on Tue, 2014/01/14 18:23: On Tue, Jan 14, 2014 at 6:22 PM, Christian Hesse l...@eworm.de wrote: Looks better, though not perfect. At least firefox still scales the image a bit. Can you investigate the whole px to pt situation, line-height, and the best

Re: [RESEND PATCH 1/1] enable cgit to show gravatar for author, committer and tagger

2014-01-14 Thread René Neumann
Am 14.01.2014 18:35, schrieb Christian Hesse: Jason A. Donenfeld ja...@zx2c4.com on Tue, 2014/01/14 18:23: On Tue, Jan 14, 2014 at 6:22 PM, Christian Hesse l...@eworm.de wrote: Looks better, though not perfect. At least firefox still scales the image a bit. Can you investigate the whole px

Re: [RESEND PATCH 1/1] enable cgit to show gravatar for author, committer and tagger

2014-01-14 Thread Jason A. Donenfeld
On Tue, Jan 14, 2014 at 6:35 PM, Christian Hesse l...@eworm.de wrote: Probably the only way to not have this is to use pixel only for images. Want a patch? I think I have it handled. Would you look at git.zx2c4.com/cgit/log/ and tell me if that looks better to you?

Re: [RESEND PATCH 1/1] enable cgit to show gravatar for author, committer and tagger

2014-01-14 Thread Christian Hesse
Jason A. Donenfeld ja...@zx2c4.com on Tue, 2014/01/14 18:51: On Tue, Jan 14, 2014 at 6:35 PM, Christian Hesse l...@eworm.de wrote: Probably the only way to not have this is to use pixel only for images. Want a patch? I think I have it handled. Would you look at git.zx2c4.com/cgit/log/ and

Re: [RESEND PATCH 1/1] enable cgit to show gravatar for author, committer and tagger

2014-01-14 Thread Jason A. Donenfeld
On Tue, Jan 14, 2014 at 6:58 PM, Christian Hesse l...@eworm.de wrote: Looks good to me. Though this may result in images that do not fit font size if dpi is a lot more or less than 96 as René pointed. Anybody want to try with a fancy retina iPad or the like?

Re: lua vs luajit vs both

2014-01-14 Thread Jason A. Donenfeld
On Tue, Jan 14, 2014 at 10:08 AM, John Keeping j...@keeping.me.uk wrote: It was more of a there doesn't seem much overhead to supporting both, since the API is the same. I think the Makefile should take an approach more like this though: ifdef NO_LUA CGIT_CFLAGS +=

Re: cgit-lua: to jit or not to jit

2014-01-14 Thread Florian Weimer
* Jason A. Donenfeld: On Tue, Jan 14, 2014 at 3:10 AM, demetri demetri.spa...@gmail.com wrote: 1) PUC Lua works on more machines/architectures (though Mike has substantially closed the gap for most architectures people care about in a non-embedded non-mobile environment) Do you know what

[PATCH 1/2] t0111: Prepare for other filter prefixes

2014-01-14 Thread Lukas Fleischer
Rename the filter repository to filter-exec. The Git repository itself is not renamed since it can be shared amongst all filter types. Signed-off-by: Lukas Fleischer c...@cryptocrack.de --- tests/setup.sh| 2 +- tests/t0111-filter.sh | 22 +++--- 2 files changed, 12

[PATCH 2/2] t0111: Add basic tests for Lua filters

2014-01-14 Thread Lukas Fleischer
Signed-off-by: Lukas Fleischer c...@cryptocrack.de --- tests/filters/capitalize-buffer.lua | 14 ++ tests/setup.sh | 9 + tests/t0111-filter.sh | 32 3 files changed, 55 insertions(+) create mode 100644

Re: [PATCH] filter: refactor cgit_new_filter()

2014-01-14 Thread John Keeping
On Tue, Jan 14, 2014 at 02:00:48PM +0100, Jason A. Donenfeld wrote: From: Lukas Fleischer c...@cryptocrack.de Use prefixcmp() as a preparation for using strip_prefix() later. Also, interpret the command as a file name if it contains a colon but none of the filter prefixes matches instead of

Re: cgit-lua: to jit or not to jit

2014-01-14 Thread Eric Wing
But perhaps there are some obvious downsides to this approach that I also am missing. Here are a few more potential downsides not mentioned so far. One is that iOS and Windows Store policies disallow JIT. While you can disable this part in LuaJIT, most of the performance advantages disappear

Re: cgit-lua: to jit or not to jit

2014-01-14 Thread Coda Highland
On Tue, Jan 14, 2014 at 12:50 PM, Coda Highland chighl...@gmail.com wrote: On Tue, Jan 14, 2014 at 12:41 PM, Eric Wing ewmail...@gmail.com wrote: But perhaps there are some obvious downsides to this approach that I also am missing. Here are a few more potential downsides not mentioned so far.

ssh clone config

2014-01-14 Thread Doug Carter
Hi All, Sorry if this is already an answered question, but I've been through the docs and the mailing list archives but couldn't find anything. I have a local, in house gitolite repo with the latest cgit up and running. Since it's private and open to all engineers, I'd like to create a some ssl

[PATCH v2 1/3] t0111: Prepare for other filter prefixes

2014-01-14 Thread Lukas Fleischer
* Validate the email filter by manipulating stdin. Additional checks for all the arguments can be added in a later patch. * Add the exec prefix to all informational messages. * Rename the filter repository to filter-exec. The Git repository itself is not renamed since it can be shared

Re: [PATCH] filter: refactor cgit_new_filter()

2014-01-14 Thread John Keeping
On Tue, Jan 14, 2014 at 09:54:21PM +0100, Jason A. Donenfeld wrote: On Tue, Jan 14, 2014 at 9:39 PM, John Keeping j...@keeping.me.uk wrote: I like the simplification, but I'm not sure the result is better. Even without the rest we should replace the strncmp with prefixcmp though. Agreed.

Re: lua vs luajit vs both

2014-01-14 Thread John Keeping
On Tue, Jan 14, 2014 at 07:06:34PM +0100, Jason A. Donenfeld wrote: On Tue, Jan 14, 2014 at 10:08 AM, John Keeping j...@keeping.me.uk wrote: It was more of a there doesn't seem much overhead to supporting both, since the API is the same. I think the Makefile should take an approach

Re: cgit-lua: to jit or not to jit

2014-01-14 Thread malkia
One more thing for luajit vs. lua - If you ship a plugin (.so, .dll, .dylib) using luajit, then the host application might not always work with it. If I'm not mistaken the lower 2GB (or 4GB?) must be allocated to luajit, (so even in 64-bit app, it needs the lower 32-bit address space - for lua