support the rel-vcs microformat?

2014-08-01 Thread Paul Wise
Hi all, Would it be possible to support the rel-vcs microformat? https://joeyh.name/rfc/rel-vcs/ [Please CC me if you want me to read replies] -- bye, pabs http://bonedaddy.net/pabs3/ signature.asc Description: This is a digitally signed message part

Re: support the rel-vcs microformat?

2014-08-01 Thread Paul Wise
On Fri, 2014-08-01 at 09:12 +0100, John Keeping wrote: Can you provide some more details about where you expect CGit to apply this? I'm guessing that when on a repo page of any sort the link rel=vcs-git ... / element should be used and the rel=vcs-git attribute should be added to the clone

Re: commit-filter not being applied on log page

2014-08-01 Thread John Keeping
On Thu, Jul 31, 2014 at 10:27:19AM -0400, Chris Burroughs wrote: I'm trying to write a commit-filter to hyperlink references to our bug tracker. It seems to work fine for commit detailed pages, but not at all for the log view. Since our developers often make brief messages like fixes

Re: [PATCH] ui-tree.c: check source filter if set globally

2014-08-01 Thread Jason A. Donenfeld
I would be okay with both scan-path deferment or simply augmenting the documentation. I don't like the commit of this thread though. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

[PATCH] filter: add support for owner-filter

2014-08-01 Thread Chris Burroughs
Followup and attempt at implementation of an owner filter as described in http://lists.zx2c4.com/pipermail/cgit/2014-July/002163.html. There are two parts I am unsure of: * Is there an advantage (performance?) to passing the owner as an argument instead of using CGIT_REPO_OWNER? * I passed

Re: commit-filter not being applied on log page

2014-08-01 Thread Chris Burroughs
On 08/01/2014 05:44 AM, John Keeping wrote: On Thu, Jul 31, 2014 at 10:27:19AM -0400, Chris Burroughs wrote: I'm trying to write a commit-filter to hyperlink references to our bug tracker. It seems to work fine for commit detailed pages, but not at all for the log view. Since our developers

Re: [PATCH] filter: add support for owner-filter

2014-08-01 Thread Chris Burroughs
On 08/01/2014 02:18 PM, John Keeping wrote: On Fri, Aug 01, 2014 at 01:54:46PM -0400, Chris Burroughs wrote: This isn't really acting as a filter, you're taking the argument from the function call and then just appending something based on that from the default generated by the C code. I think

Re: [PATCH] filter: add support for owner-filter

2014-08-01 Thread John Keeping
On Fri, Aug 01, 2014 at 04:01:53PM -0400, Chris Burroughs wrote: revised patch This type of comment should go below the --- line below, since it's not intended to be part of the commit message in the permanent history. Also filter in the subject doesn't really identify a code area. How about

[PATCH 2/3] ui-summary: add rel='vcs-git' to clone URL links

2014-08-01 Thread John Keeping
This is described in the rel-vcs microformat[1]. [1] https://joeyh.name/rfc/rel-vcs/ Signed-off-by: John Keeping j...@keeping.me.uk --- ui-summary.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ui-summary.c b/ui-summary.c index 70ea908..46ca713 100644 ---

[PATCH 1/3] Extract clone URL printing to ui-shared.c

2014-08-01 Thread John Keeping
This will allow us to reuse the same logic to add clone URL link/ elements to the header of all repo-specific pages in order to support the rel-vcs microformat. Signed-off-by: John Keeping j...@keeping.me.uk --- ui-shared.c | 37 + ui-shared.h | 2 ++

[PATCH 3/3] ui-shared: add rel-vcs microformat links to HTML header

2014-08-01 Thread John Keeping
As described at https://joeyh.name/rfc/rel-vcs/. Signed-off-by: John Keeping j...@keeping.me.uk --- ui-shared.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/ui-shared.c b/ui-shared.c index 5bae02d..9ac65ab 100644 --- a/ui-shared.c +++ b/ui-shared.c @@ -661,6 +661,15 @@ void