Compile cGit 2.0.4

2014-08-11 Thread Jorge Bastos
Hi, Trying to compile cgit last git head cgit (2.0.4) to see if one charset problem is solved, but got this: Peixe:/usr/local/src/cgit/cgit# make SUBDIR git ./gen-version.sh: line 2: $'\r': command not found ./gen-version.sh: line 5: $'\r': command not found ./gen-version.sh: line

Re: Compile cGit 2.0.4

2014-08-11 Thread John Keeping
On Mon, Aug 11, 2014 at 08:40:53PM +0100, Jorge Bastos wrote: Trying to compile cgit last git head cgit (2.0.4) to see if one charset problem is solved, but got this: Peixe:/usr/local/src/cgit/cgit# make SUBDIR git ./gen-version.sh: line 2: $'\r': command not found ./gen-version.sh:

RE: Compile cGit 2.0.4

2014-08-11 Thread Jorge Bastos
Do you have a weird CGIT_VERSION defined in your environment? The string $'\r' doesn't appear in gen-version.sh so I don't understand where that error can be coming from. Alternatively do you have a weird (non-POSIX) /bin/sh? What operating system are you using? I've always compiled cgit

[PATCH] Handle If-None-Match HTTP header in plain view

2014-08-11 Thread Damián Nohales
We are sending Etag to clients but this header is basically unusefulness if the server doesn't tell the client if the content has been changed or not for a given Path/Etag pair. Signed-off-by: Damián Nohales damiannoha...@gmail.com --- cgit.c | 1 + cgit.h | 1 + ui-plain.c | 41

Re: [PATCH] Handle If-None-Match HTTP header in plain view

2014-08-11 Thread John Keeping
On Mon, Aug 11, 2014 at 05:53:23PM -0300, Damián Nohales wrote: We are sending Etag to clients but this header is basically unusefulness if the server doesn't tell the client if the content has been changed or not for a given Path/Etag pair. Signed-off-by: Damián Nohales

Re: [PATCH] Handle If-None-Match HTTP header in plain view

2014-08-11 Thread Damián Nohales
(Sorry, I forgot to include the list address in my response.) This does not interact with CGit's cache at all, this interacts with client side cache. If the client sends an Etag it means Hey, I have the content cached for this URL in the client and its Etag is abc123, so, for a given URL, if