Re: Origin URL in patch view?

2014-12-28 Thread Paul Wise
On Sun, 2014-12-28 at 12:15 +, John Keeping wrote: > I don't think this is likely to happen because the patch view is > intended to match the output of git-format-patch(1) and it appears that > the origin is intended as a "trailer" (to use Git terminology) that > appears at the bottom of the c

Re: [PATCH 2/2] ui-patch: match git-format-patch(1) output

2014-12-28 Thread Jason A. Donenfeld
Excellent, thank you. Merged. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/2] t0108: modernize style

2014-12-28 Thread Jason A. Donenfeld
Merged, thanks. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

[PATCH 2/2] ui-patch: match git-format-patch(1) output

2014-12-28 Thread John Keeping
Using (DIFF_FORMAT_DIFFSTAT | DIFF_FORMAT_PATCH) causes Git to emit a "---" line between the commit message and the body of the patch, which fixes a regression introduced in commit 455b598 (ui-patch.c: Use log_tree_commit() to generate diffs, 2013-08-20), prior to which we inserted the "---" line o

[PATCH 1/2] t0108: modernize style

2014-12-28 Thread John Keeping
* &&-chaining * use test_cmp instead of cmp * use strip_headers instead of knowing how many lines there will be Signed-off-by: John Keeping --- tests/t0108-patch.sh | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/tests/t0108-patch.sh b/tests/t0108-patch

Re: Origin URL in patch view?

2014-12-28 Thread John Keeping
On Sun, Dec 28, 2014 at 07:45:29PM +0800, Paul Wise wrote: > I no longer remember enough C to implement this, but it would be great > to have the patch UI contain an Origin header with the URL to the patch. > I suggest an Origin header as the Debian patch guidelines suggest it: > > http://dep.debi

Origin URL in patch view?

2014-12-28 Thread Paul Wise
Hi, I no longer remember enough C to implement this, but it would be great to have the patch UI contain an Origin header with the URL to the patch. I suggest an Origin header as the Debian patch guidelines suggest it: http://dep.debian.net/deps/dep3/ -- bye, pabs http://bonedaddy.net/pabs3/