Re: [PATCH] ui-commit: display commit notes as 'raw'

2015-03-20 Thread John Keeping
On Fri, Mar 20, 2015 at 05:39:53PM +0100, Stefan Naewe wrote:
> When the git function format_display_notes() is called
> with a value != 0 as the last argument ('raw') the notes text
> gets displayed w/o an additional 'Notes:' header. This seems
> to be better suited for our needs since we're already displaying
> a similar header.

What happens when there are multiple display notes refs?  It seems that
without "raw", format_note() puts the name of the ref in the header it
prints (if it's not the default notes ref).

It's possible that the correct answer is that we don't care about that
case, but it is potentially a regression for people who want to display
multiple notes.

> Signed-off-by: Stefan Naewe 
> ---
>  ui-commit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ui-commit.c b/ui-commit.c
> index d5a888d..4b40133 100644
> --- a/ui-commit.c
> +++ b/ui-commit.c
> @@ -37,7 +37,7 @@ void cgit_print_commit(char *hex, const char *prefix)
>   }
>   info = cgit_parse_commit(commit);
>  
> - format_display_notes(sha1, ¬es, PAGE_ENCODING, 0);
> + format_display_notes(sha1, ¬es, PAGE_ENCODING, 1);
>  
>   load_ref_decorations(DECORATE_FULL_REFS);
>  
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit


[PATCH] ui-commit: display commit notes as 'raw'

2015-03-20 Thread Stefan Naewe
When the git function format_display_notes() is called
with a value != 0 as the last argument ('raw') the notes text
gets displayed w/o an additional 'Notes:' header. This seems
to be better suited for our needs since we're already displaying
a similar header.

Signed-off-by: Stefan Naewe 
---
 ui-commit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui-commit.c b/ui-commit.c
index d5a888d..4b40133 100644
--- a/ui-commit.c
+++ b/ui-commit.c
@@ -37,7 +37,7 @@ void cgit_print_commit(char *hex, const char *prefix)
}
info = cgit_parse_commit(commit);
 
-   format_display_notes(sha1, ¬es, PAGE_ENCODING, 0);
+   format_display_notes(sha1, ¬es, PAGE_ENCODING, 1);
 
load_ref_decorations(DECORATE_FULL_REFS);
 
-- 
2.3.3

___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit