Re: [PATCH 1/2] ui-shared: add homepage to tabs

2016-02-22 Thread Peter Colberg
Hi Jason, Thank you for this patch, this is indeed a very useful feature. Would you reconsider opening the homepage link in the current tab by default? This way visitors have the option to open the homepage in new tab if they like (e.g., using middle-click), but they are not forced to do so. Reg

Re: Killing plaintext git:// in favor of https:// cloning

2016-02-22 Thread Eric Wong
"Jason A. Donenfeld" wrote: > On Tue, Feb 23, 2016 at 2:19 AM, Eric Wong wrote: > > git already has plenty of integrity checking built-in and > > getting the proper hashes for the heads/tags over a > > trusted-enough medium is enough (or reading the fine code). > > No, git's built-in integrity p

Build failed in Jenkins: cgit-master #20 - origin/master - 438c038

2016-02-22 Thread Pelagic Jenkins (Public)
See Changes: [Jason] md2html: Do syntax highlighting too -- [...truncated 562 lines...] 307 translated messages. Generating catalog po/hu.msg msgfmt --statistics --tcl po/hu.po -l hu -d po

Re: Killing plaintext git:// in favor of https:// cloning

2016-02-22 Thread Jason A. Donenfeld
On Tue, Feb 23, 2016 at 2:19 AM, Eric Wong wrote: > I suggest keeping git:// running as automated mirrors may not be > monitored very closely or easily updated. That's a good point. I'd forgotten about automated mirrors. I'll keep logs of the git:// pulls for a month or so and see if there are an

Re: Killing plaintext git:// in favor of https:// cloning

2016-02-22 Thread Jason A. Donenfeld
On Mon, Feb 22, 2016 at 9:43 PM, Joe Anakata wrote: > (Also it was mentioned this would only work for people making a fresh > clone; anyone with an existing clone would almost certainly know > something was up.) No, definitely a MITM attack is feasible that would be fast forwardable just fine for

Re: Killing plaintext git:// in favor of https:// cloning

2016-02-22 Thread Jason A. Donenfeld
On Mon, Feb 22, 2016 at 8:57 PM, Eclipse Webmaster (Denis Roy) wrote: > > Everything is possible "in theory" ... But folks really need to stop > thinking that https is the impenetrable solution to everything. Are you aware of some attack on TLS 1.2 that I'm not? __

Re: [PATCH 1/1] git: update to v2.7.2

2016-02-22 Thread Jason A. Donenfeld
Merged, thanks. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: cgit: [PATCH] timegm() compat for non-Linux and non-BSD

2016-02-22 Thread Jason A. Donenfeld
On Tue, Feb 23, 2016 at 3:15 AM, Jason A. Donenfeld wrote: > Subject: [PATCH] timegm() compat for non-Linux and non-BSD What platform, specifically, do you have in mind? ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/

Re: cgit: [PATCH] timegm() compat for non-Linux and non-BSD

2016-02-22 Thread Jason A. Donenfeld
>From 34e1cfd7f56e20c577cebba31e8235e101f95972 Mon Sep 17 00:00:00 2001 From: Brad Forschinger Date: Tue, 23 Feb 2016 10:18:34 +1100 Subject: [PATCH] timegm() compat for non-Linux and non-BSD --- cgit.mk| 9 + ui-stats.c | 19 +++ 2 files changed, 28 insertions(+) d

Fwd: cgit: [PATCH] timegm() compat for non-Linux and non-BSD

2016-02-22 Thread Jason A. Donenfeld
-- Forwarded message -- From: Brad Forschinger Date: Tue, Feb 23, 2016 at 12:27 AM Subject: cgit: [PATCH] timegm() compat for non-Linux and non-BSD To: ja...@zx2c4.com Hi Jason, I almost know that gmail will mangle the e-mail, so I'll include it as an attachment. Brad From 34e1

Re: Killing plaintext git:// in favor of https:// cloning

2016-02-22 Thread Jason A. Donenfeld
https://git.zx2c4.com/git-daemon-dummy/about/ I just wrote this. Will consider whether or not to deploy it. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: Killing plaintext git:// in favor of https:// cloning

2016-02-22 Thread Eric Wong
"Jason A. Donenfeld" wrote: > Now that git.zx2c4.com runs over HTTPS, I'm considering getting rid of > the plaintext git:// endpoint for cloning. > Does anybody have any objections or comments? I suggest keeping git:// running as automated mirrors may not be monitored very closely or easily upda

[PATCH 1/1] git: update to v2.7.2

2016-02-22 Thread Christian Hesse
From: Christian Hesse Update to git version v2.7.2, no changes required. Signed-off-by: Christian Hesse --- Makefile | 2 +- git | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 8bd7a0e..c01701c 100644 --- a/Makefile +++ b/Makefile @@ -14,7

Re: Killing plaintext git:// in favor of https:// cloning

2016-02-22 Thread Joe Anakata
"Eclipse Webmaster (Denis Roy)" Proclaimed Thus: >Everything is possible "in theory" ... But folks really need to stop >thinking that https is the impenetrable solution to everything. HTTPS is definitely not the impenetrable solution to everything, but there's no question it makes things *hard

Re: Killing plaintext git:// in favor of https:// cloning

2016-02-22 Thread Ferry Huberts
On 22/02/16 20:50, Joe Anakata wrote: On 22/02/16 19:16, Jason A. Donenfeld wrote: Now that git.zx2c4.com runs over HTTPS, I'm considering getting rid of the plaintext git:// endpoint for cloning. Ferry Huberts Proclaimed Thus: Yes, why? What's the point? The repos are public, so clonin

Re: Killing plaintext git:// in favor of https:// cloning

2016-02-22 Thread Eclipse Webmaster (Denis Roy)
On 22/02/16 02:50 PM, Joe Anakata wrote: Yes, why? What's the point? The repos are public, so cloning them over https bring nothing, except extra overhead and server load. While pretty unlikely, in theory someone could MITM a git:// clone and send the user a hax0red branch of cgit with integrat

Re: Killing plaintext git:// in favor of https:// cloning

2016-02-22 Thread Jason A. Donenfeld
On Mon, Feb 22, 2016 at 8:18 PM, Ferry Huberts wrote: > Yes, why? > What's the point? So that the contents of the repository cannot be modified in transit. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: Killing plaintext git:// in favor of https:// cloning

2016-02-22 Thread Joe Anakata
On 22/02/16 19:16, Jason A. Donenfeld wrote: >> Now that git.zx2c4.com runs over HTTPS, I'm considering getting rid of >> the plaintext git:// endpoint for cloning. Ferry Huberts Proclaimed Thus: >Yes, why? >What's the point? > >The repos are public, so cloning them over https bring nothing, e

Re: Killing plaintext git:// in favor of https:// cloning

2016-02-22 Thread Ferry Huberts
On 22/02/16 19:16, Jason A. Donenfeld wrote: Hello projects-with-mailing-lists, Now that git.zx2c4.com runs over HTTPS, I'm considering getting rid of the plaintext git:// endpoint for cloning. This means: git clone git://git.zx2c4.com/cgit --> git clone https://git.zx2c4.com/cgit git clone

Re: Killing plaintext git:// in favor of https:// cloning

2016-02-22 Thread Jason A. Donenfeld
Well, uh oh speghettio! Looks like somebody has published in paper the git:// URI: https://books.google.fr/books?id=kJsQAwAAQBAJ&pg=PA314&lpg=PA314&dq=git://git.zx2c4.com&source=bl&ots=W6M9TlYzCY&sig=g-PY0glN2ddWygtFDLiHgbiC69I&hl=en&sa=X&redir_esc=y#v=onepage&q=git%3A%2F%2Fgit.zx2c4.com&f=false

Killing plaintext git:// in favor of https:// cloning

2016-02-22 Thread Jason A. Donenfeld
Hello projects-with-mailing-lists, Now that git.zx2c4.com runs over HTTPS, I'm considering getting rid of the plaintext git:// endpoint for cloning. This means: git clone git://git.zx2c4.com/cgit --> git clone https://git.zx2c4.com/cgit git clone git://git.zx2c4.com/password-store --> git clone

Next release will be 1.0

2016-02-22 Thread Jason A. Donenfeld
Hi guys, We'll switch to semver. Why not? Our current versioning situation doesn't make much sense. That means the next release oughta be a nice one. Thoughts? Jason ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cg

Re: [PATCH] ui-plain: fix to show a repo's root directory listing in plain view

2016-02-22 Thread Jason A. Donenfeld
Merged! https://git.zx2c4.com/cgit/commit/?id=de6098be6a65a4758ff8eac6359bd6fd30ba7bd3 Thanks. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/2] ui-shared: add homepage to tabs

2016-02-22 Thread Jason A. Donenfeld
Here we go: https://git.zx2c4.com/cgit/commit/?h=jd/zx2c4-deployment&id=e160fa1fe7efbae91ff04992df0b3464f43a4426 You can see it in action here: https://git.zx2c4.com/password-store/ ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailma

Re: [PATCH 1/2] ui-shared: add homepage to tabs

2016-02-22 Thread Jason A. Donenfeld
Hi John, I actually started doing that initially, with the base64 src of that exact image, but then found that it looked bad with custom CSS, since a PNG, unlike a font, embeds the color. But, adding it into the CSS instead makes lots of sense. Great thinking. Jason On Mon, Feb 22, 2016 at 6:03

Re: [PATCH 1/2] ui-shared: add homepage to tabs

2016-02-22 Thread John Keeping
On Mon, Feb 22, 2016 at 04:42:12PM +0100, Jason A. Donenfeld wrote: > Seems like a very useful feature. I'd like some feedback on ➦ though. > > It'd be nice to have this: > http://fortawesome.github.io/Font-Awesome/icon/external-link/ > or this: > http://www.fileformat.info/info/unicode/char/1f517

Re: [PATCH 1/2] ui-shared: add homepage to tabs

2016-02-22 Thread Jason A. Donenfeld
Seems like a very useful feature. I'd like some feedback on ➦ though. It'd be nice to have this: http://fortawesome.github.io/Font-Awesome/icon/external-link/ or this: http://www.fileformat.info/info/unicode/char/1f517/index.htm But the former is overhead I won't accept and the latter isn't avail

[PATCH 1/2] ui-shared: add homepage to tabs

2016-02-22 Thread Jason A. Donenfeld
Signed-off-by: Jason A. Donenfeld --- cgit.c | 4 cgit.h | 1 + cgitrc.5.txt | 13 - scan-tree.c | 2 ++ shared.c | 1 + ui-shared.c | 5 + 6 files changed, 21 insertions(+), 5 deletions(-) diff --git a/cgit.c b/cgit.c index 7f83a2d..fc482be 100644 ---

[PATCH 2/2] cmd: redirect empty about/ to homepage or summary

2016-02-22 Thread Jason A. Donenfeld
Signed-off-by: Jason A. Donenfeld --- cmd.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/cmd.c b/cmd.c index 3093c62..0375c5a 100644 --- a/cmd.c +++ b/cmd.c @@ -47,8 +47,17 @@ static void about_fn(void) cgit_redirect(redirect, true);