Re: [PATCH 3/5] Revert "ui-shared: add rel-vcs microformat links to HTML header"

On Wed, May 11, 2016 at 07:45:34PM +0100, John Keeping wrote: > On Wed, May 11, 2016 at 06:04:16PM +, Juuso Lapinlampi wrote: > > See: a24995bf8c55114044d6baf32ad5e8c3a04d924d > > You can't do this, the commit hash will be different when the patch is > applied from an email. Oops. Sometimes

Re: [PATCH 1/1] ui-shared: Use CRLF in HTTP headers as per RFC 7230

On Wed, May 11, 2016 at 08:57:52PM +0100, John Keeping wrote: > "generally recognized" is a bit nebulous, which is why a blanket policy > is safer as well as much simpler to police. Guess we are going to wait for this bit to rot here over a silly blanket policy then, as I have established my

Re: [PATCH 1/5] ui-shared: HTML-ize DOCTYPE and

On Wed, May 11, 2016 at 07:56:19PM +0100, John Keeping wrote: > I think we need to fix all of those as well if we're going to claim to > be HTML rather than XHTML. I suspect that would be a bit big to review > as a single patch, but I certainly think that it should be applied as a > single patch

Re: [PATCH 5/5] ui-shared: Remove a name attribute with an empty value

On Wed, May 11, 2016 at 06:04:18PM +, Juuso Lapinlampi wrote: > The name attribute is optional in an input element, but it must not be > an empty value. > > See: https://html.spec.whatwg.org/#attr-fe-name > See: https://html.spec.whatwg.org/#the-input-element Again, sign-off is needed, but

Re: [PATCH 3/5] Revert "ui-shared: add rel-vcs microformat links to HTML header"

On Wed, May 11, 2016 at 06:04:16PM +, Juuso Lapinlampi wrote: > See: a24995bf8c55114044d6baf32ad5e8c3a04d924d You can't do this, the commit hash will be different when the patch is applied from an email. > This reverts commit 3c53ebfb57a5dba8fc65b2f99ebbfb635e34. Same comments apply as

Re: [PATCH 2/5] Revert "ui-summary: add "rel='vcs-git'" to clone URL links"

On Wed, May 11, 2016 at 06:04:15PM +, Juuso Lapinlampi wrote: > vcs-git is not a registered keyword. This microformat does not seem to > be very popular and will throw errors in HTML validators. > > Because the element leaves us with no sensible rel attribute to > use, there's no reason to

Re: [PATCH 1/1] ui-shared: Simplify cgit_print_error_page() logic

On Wed, May 11, 2016 at 05:50:09PM +, Juuso Lapinlampi wrote: > --- > This may be a little controversial, but right now is there a reason not > to do this? No, I think this makes sense (although again we need your signed-off-by). Reviewed-by: John Keeping > ui-shared.c

[PATCH 3/5] Revert "ui-shared: add rel-vcs microformat links to HTML header"

See: a24995bf8c55114044d6baf32ad5e8c3a04d924d This reverts commit 3c53ebfb57a5dba8fc65b2f99ebbfb635e34. --- ui-shared.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/ui-shared.c b/ui-shared.c index 1ded2d6..ba11c55 100644 --- a/ui-shared.c +++ b/ui-shared.c @@ -703,15

[PATCH 0/5] Convert to HTML, fix HTML validation issues

Feel free to cherry-pick some commits. Some are bug fixes, some are changes in functionality. This branch is still incomplete, but I'd like to hear feedback on it. Juuso Lapinlampi (5): ui-shared: HTML-ize DOCTYPE and Revert "ui-summary: add "rel='vcs-git'" to clone URL links" Revert

[PATCH 4/5] ui: Fix bad value for attribute action on form elements

The action attribute must "a valid non-empty URL potentially surrounded by spaces." See: https://html.spec.whatwg.org/#the-form-element --- ui-shared.c | 2 +- ui-stats.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ui-shared.c b/ui-shared.c index 9a38aa9..0b7fdec

[PATCH 2/5] Revert "ui-summary: add "rel='vcs-git'" to clone URL links"

vcs-git is not a registered keyword. This microformat does not seem to be very popular and will throw errors in HTML validators. Because the element leaves us with no sensible rel attribute to use, there's no reason to keep this. For future consideration, microdata should be marked with

[PATCH 1/5] ui-shared: HTML-ize DOCTYPE and

Get rid of the XHTML headers, bringing cgit slowly to the modern age of HTML. --- ui-shared.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ui-shared.c b/ui-shared.c index 9a38aa9..1ded2d6 100644 --- a/ui-shared.c +++ b/ui-shared.c @@ -12,8 +12,7 @@ #include "html.h"

[PATCH 1/1] ui-shared: Simplify cgit_print_error_page() logic

--- This may be a little controversial, but right now is there a reason not to do this? ui-shared.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ui-shared.c b/ui-shared.c index 9a38aa9..d9541f0 100644 --- a/ui-shared.c +++ b/ui-shared.c @@ -792,13 +792,11 @@ void