Re: [PATCH 1/5] ui-shared: HTML-ize DOCTYPE and

2016-05-12 Thread Jason A. Donenfeld
This is live on git.zx2c4.com . So far it looks good to me. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/5] ui-shared: HTML-ize DOCTYPE and

2016-05-12 Thread Juuso Lapinlampi
On Thu, May 12, 2016 at 05:32:32PM +0200, Jason A. Donenfeld wrote: > Merged! > > It's time we grow up. > > If this causes rendering errors due to compatibility modes the prior > XHTML header was triggering, we can fix those up in subsequent > commits. Note that I will be unable to work on

Re: [PATCH 2/5] Revert "ui-summary: add "rel='vcs-git'" to clone URL links"

2016-05-12 Thread Paul Wise
John Keeping wrote: > we had a request to add support [1]  I was the one who requested it. > Now, admittedly, vcs-git isn't registered there ... > Anyone is free to edit the microformats wiki existing-rel-values > page at any time to add a type. I've now registered vcs-* on that

Re: [PATCH 1/1] ui-shared: Use CRLF in HTTP headers as per RFC 7230

2016-05-12 Thread Jason A. Donenfeld
On Wed, May 11, 2016 at 7:48 PM, Juuso Lapinlampi wrote: > CRLF is explicitly defined as the line break in the HTTP protocol > specifications: RFC 2616 (obsolete) and RFC 7230. But this is CGI, not HTTP. ___ CGit mailing list

Re: [PATCH 5/5] ui-shared: Remove a name attribute with an empty value

2016-05-12 Thread Jason A. Donenfeld
Merged, thanks. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 4/5] ui: Fix bad value for attribute action on form elements

2016-05-12 Thread Jason A. Donenfeld
Could we instead just remove action? Does this work both in the case of path/to/page and path/to/page/ ? Or in the former will this wind up requesting path/to/.? ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/5] ui-shared: HTML-ize DOCTYPE and

2016-05-12 Thread Jason A. Donenfeld
On Wed, May 11, 2016 at 8:56 PM, John Keeping wrote: > This seems like a reasonable aim, but don't we need to actually *be* > HTML(5?) as well in order to do this? Currently we close and > tags even though HTML is explicit that this shouldn't be done. No, in HTML5 you can

Re: [PATCH 1/5] ui-shared: HTML-ize DOCTYPE and

2016-05-12 Thread Jason A. Donenfeld
On Wed, May 11, 2016 at 8:04 PM, Juuso Lapinlampi wrote: > > static const char cgit_doctype[] = > -" -" \"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd\;>\n"; > +""\n"; Not syntactically valid C either. Test your commits before you submit.

Re: [PATCH 1/1] ui-shared: Simplify cgit_print_error_page() logic

2016-05-12 Thread Jason A. Donenfeld
On Wed, May 11, 2016 at 7:50 PM, Juuso Lapinlampi wrote: > - cgit_print_docstart(); > - cgit_print_pageheader(); > + cgit_print_layout_start() > va_start(ap, fmt); You forgot a semicolon. Please test your commits before you submit. Otherwise you waste

Build failed in Jenkins: cgit-master #28 - origin/master - 6d13089

2016-05-12 Thread Pelagic Jenkins (Public)
See Changes: [Jason] git: update to v2.8.2 [Jason] ui-shared: Simplify cgit_print_error_page() logic [Jason] ui-shared: HTML-ize DOCTYPE and -- Started by an SCM change Building in

Re: [PATCH 2/5] Revert "ui-summary: add "rel='vcs-git'" to clone URL links"

2016-05-12 Thread Jason A. Donenfeld
Hi Paul, We added vcs-git per your request [1]. Now there's talk of removing it. Could you give full justification for its existence? How is it useful? What uses it? Thanks, Jason ___ CGit mailing list CGit@lists.zx2c4.com

Build failed in Jenkins: cgit-master-get-git #30 - origin/master - 6d13089

2016-05-12 Thread Pelagic Jenkins (Public)
See Changes: [Jason] git: update to v2.8.2 [Jason] ui-shared: Simplify cgit_print_error_page() logic [Jason] ui-shared: HTML-ize DOCTYPE and -- Started by an SCM change

Re: [PATCH 1/5] ui-shared: HTML-ize DOCTYPE and

2016-05-12 Thread Jason A. Donenfeld
Merged! It's time we grow up. If this causes rendering errors due to compatibility modes the prior XHTML header was triggering, we can fix those up in subsequent commits. ___ CGit mailing list CGit@lists.zx2c4.com

Re: [PATCH 1/1] ui-shared: Simplify cgit_print_error_page() logic

2016-05-12 Thread Jason A. Donenfeld
Merged, thanks. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH v4] ui-shared: allow to split the repository link

2016-05-12 Thread Jason A. Donenfeld
Can you rename this from "summary-enable-split-repo-link" to "split-summary-repo-link"? ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/1] git: update to v2.8.2

2016-05-12 Thread Jason A. Donenfeld
Merged, thanks. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 2/2] ui-log: Simplify decoration code

2016-05-12 Thread Jason A. Donenfeld
Merged, thanks. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/2] ui-log: Do not always emit decoration span

2016-05-12 Thread Jason A. Donenfeld
Merged, thanks. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/1] ui-shared: Use CRLF in HTTP headers as per RFC 7230

2016-05-12 Thread John Keeping
On Wed, May 11, 2016 at 08:15:27PM +, Juuso Lapinlampi wrote: > On Wed, May 11, 2016 at 08:57:52PM +0100, John Keeping wrote: > > "generally recognized" is a bit nebulous, which is why a blanket policy > > is safer as well as much simpler to police. > > Guess we are going to wait for this bit