Re: [PATCH v5 6/6] line-range-highlight: copy URL to clipboard UI

On 06/28/2018 07:30 AM, Jason A. Donenfeld wrote: On Thu, Jun 28, 2018 at 1:24 AM Andy Green wrote: Can you help me understand what is "clearly superior" and "right way" about the [...] menu in github? Since you seem to be asking me to implement it? What put me off it was there's only one u

Re: [PATCH v5 6/6] line-range-highlight: copy URL to clipboard UI

On Thu, Jun 28, 2018 at 1:24 AM Andy Green wrote: > Can you help me understand what is "clearly superior" and "right way" > about the [...] menu in github? > > Since you seem to be asking me to implement it? > > What put me off it was there's only one useful option on it, and it > requires and ext

Re: [PATCH v5 6/6] line-range-highlight: copy URL to clipboard UI

On 06/28/2018 02:07 AM, Jason A. Donenfeld wrote: Nack. If we're going to add something like this, the github GUI for it is clearly superior and the right way of going about things, with the elegant [...] menu. "Nack"... Can you help me understand what is "clearly superior" and "right way"

Re: [PATCH v4 00/16] Render READMEs inline in tree view

Hey John, Thanks tons for your input, as always. On Wed, Jun 27, 2018 at 9:51 PM John Keeping wrote: > - It is desirable to have the existing source view in addition to the > rendered content, preferably with syntax highlighting via the source > filter; for example Markdown, HTML or SVG can

Re: [PATCH v4 00/16] Render READMEs inline in tree view

On 06/28/2018 06:46 AM, Jason A. Donenfeld wrote: Hi Andy, I'm happy to engage technically here in order to find the best way of going about this. However, Nobody is paying me to do it and I don't have an endless budget of time to lavish on it (and it seems, neither do you...). If cgit can'

Re: [PATCH v4 00/16] Render READMEs inline in tree view

On 06/28/2018 03:51 AM, John Keeping wrote: Hi Jason, On Wed, Jun 27, 2018 at 07:18:57PM +0200, Jason A. Donenfeld wrote: With the current state of this series, cgit would have the following options: - render. - inline-readme - render-filter This one is only a concept, not a configuration

Re: [PATCH v4 00/16] Render READMEs inline in tree view

Hi Andy, I'm happy to engage technically here in order to find the best way of going about this. However, > Nobody is paying me to do it and I don't have an endless budget of time > to lavish on it (and it seems, neither do you...). > If cgit can't do what I need in a reasonable timescale, even w

Re: [PATCH v4 00/16] Render READMEs inline in tree view

On 06/28/2018 01:18 AM, Jason A. Donenfeld wrote: Hey Andy, Thanks for this patchset. It looks like this is shaping up into a nice direction. However, I'm a bit concerned about our nobs becoming slightly overlapping and incoherent, and I think that with this series, we should also unify how w

Re: [PATCH v4 16/16] md2html: change css name to not conflict with highlight

On 06/28/2018 01:37 AM, Jason A. Donenfeld wrote: Hi Andy, This seems like an obvious thing to merge, but I'm actually not so certain I understand its necessity. md2html uses the highlight class. Our css uses the highlight class. You're saying this conflicts with something? From where? Third-

Re: [PATCH v5 2/6] cgit.js: line range highlight: introduce javascript

On 06/28/2018 02:02 AM, Jason A. Donenfeld wrote: Hi Andy, I'm super hesitant about the Pandora's box that introducing javascript implies, but perhaps there's no use in fighting the future. The "fighting the future" bus left the station ten years ago when github was founded. Worrying abou

Re: [PATCH v3 1/1] snapshot: support tar signature for compressed tar

On Wed, Jun 27, 2018 at 06:34:56PM +0200, Jason A. Donenfeld wrote: > I've merged all the surrounding changes, but I'm not quite satisfied > with the implementation of this one. > > > + for (f_tar = cgit_snapshot_formats; strcmp(f_tar->suffix, ".tar") > > != 0; f_tar++) > > +

Re: Fancier Source view [Was: Re: [PATCH v4 00/16] Render READMEs inline in tree view]

On Wed, Jun 27, 2018 at 07:26:13PM +0200, Jason A. Donenfeld wrote: > Splitting out this issue into a different thread, because I think it's > orthogonal to the other topic. > > On Wed, Jun 27, 2018 at 7:18 PM Jason A. Donenfeld wrote: > > In adding rendering of arbitrary files in blob view, this

Re: [PATCH v4 11/16] md2html: add asset mapping

On Wed, Jun 27, 2018 at 07:32:56PM +0200, Jason A. Donenfeld wrote: > On Wed, Jun 20, 2018 at 12:13 PM Andy Green wrote: > > > md2html > > > The trailing "/" is important. > > Can we make it not important? That is, if the type is always > explicitly a directory, treat it as such using t

Re: [PATCH v4 00/16] Render READMEs inline in tree view

Hi Jason, On Wed, Jun 27, 2018 at 07:18:57PM +0200, Jason A. Donenfeld wrote: > With the current state of this series, cgit would have the following options: > > - render. > - inline-readme > - render-filter This one is only a concept, not a configuration value (just a note since I couldn't reme

Re: [PATCH v5 6/6] line-range-highlight: copy URL to clipboard UI

Nack. If we're going to add something like this, the github GUI for it is clearly superior and the right way of going about things, with the elegant [...] menu. Jason ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgi

Re: [PATCH v5 2/6] cgit.js: line range highlight: introduce javascript

Hi Andy, I'm super hesitant about the Pandora's box that introducing javascript implies, but perhaps there's no use in fighting the future. A few notes: - Your js needs the copyright line like the rest of the project. - Rather than awkwardly namespacing global methods, wrap everything inside a b

Jenkins build is back to normal : cgit-master #179 - origin/master - c4fbb99

See ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Jenkins build is back to normal : cgit-master-get-git #178 - origin/master - c4fbb99

See ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH v4 13/16] ui-shared: deduplicate some code in repolink

And, reverted. The code is not the same; this broke tests. html_url_arg != html_url_path. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH v4 16/16] md2html: change css name to not conflict with highlight

Hi Andy, This seems like an obvious thing to merge, but I'm actually not so certain I understand its necessity. md2html uses the highlight class. Our css uses the highlight class. You're saying this conflicts with something? From where? Third-party CSS? If that's the case, and if it's a serious pr

Re: [PATCH v4 11/16] md2html: add asset mapping

On Wed, Jun 20, 2018 at 12:13 PM Andy Green wrote: > md2html > The trailing "/" is important. Can we make it not important? That is, if the type is always explicitly a directory, treat it as such using the usual file name joining logic. Alternatively, and perhaps better, don't introduc

Re: [PATCH v4 13/16] ui-shared: deduplicate some code in repolink

Merged, thanks. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH v4 01/16] manpage: fix sorting order

Merged, thanks. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH v4 02/16] Use string list strdup_strings for mimetypes

Thanks John, merged. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Fancier Source view [Was: Re: [PATCH v4 00/16] Render READMEs inline in tree view]

Splitting out this issue into a different thread, because I think it's orthogonal to the other topic. On Wed, Jun 27, 2018 at 7:18 PM Jason A. Donenfeld wrote: > In adding rendering of arbitrary files in blob view, this is > essentially a fancy source view, with the one caveat of our > interestin

Re: [PATCH v4 00/16] Render READMEs inline in tree view

Hey Andy, Thanks for this patchset. It looks like this is shaping up into a nice direction. However, I'm a bit concerned about our nobs becoming slightly overlapping and incoherent, and I think that with this series, we should also unify how we handle rendering. With the current state of this ser

Re: [PATCH v3 1/1] snapshot: support tar signature for compressed tar

Hey Christian, I've merged all the surrounding changes, but I'm not quite satisfied with the implementation of this one. > + for (f_tar = cgit_snapshot_formats; strcmp(f_tar->suffix, ".tar") != > 0; f_tar++) > + /* nothing */ ; > + > + } else if (starts_with(f->