add favicon to cgit

2013-05-29 Thread Christian Hesse
)*42);} From b156bd6789e46503306a0ec663aee6a6d6f731b5 Mon Sep 17 00:00:00 2001 From: Christian Hesse m...@eworm.de Date: Wed, 29 May 2013 10:16:06 +0200 Subject: [PATCH] add favicon This adds a favicon to cgit. It is not enabled by default, though. The file contains two icons, 16x16 and 32x32 pixels

Re: [PATCH 1/1] enable cgit to show gravatar for author, committer and tagger

2013-11-27 Thread Christian Hesse
Peter Wu lekenst...@gmail.com on Wed, 2013/11/27 23:11: On Wednesday 27 November 2013 22:14:22 Christian Hesse wrote: +char * cgit_get_gravatar(const char *email) { + unsigned char digest[16]; + char hex[33], *lower, *tmp; + char *gravatar; + + gravatar

[PATCH 1/1] git: update to 1.8.5

2013-11-27 Thread Christian Hesse
Everything works just bumping the version in Makefile and commit hash in submodule. No code changes required. --- Makefile | 2 +- git | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 82d5b58..9930570 100644 --- a/Makefile +++ b/Makefile @@

[RESEND PATCH 1/1] enable cgit to show gravatar for author, committer and tagger

2014-01-08 Thread Christian Hesse
--- cgit.c | 3 +++ cgit.h | 8 cgitrc.5.txt | 4 parsing.c| 51 +++ shared.c | 23 +++ ui-commit.c | 10 ++ ui-log.c | 5 + ui-refs.c| 10 ++ ui-tag.c | 5

Re: [RESEND PATCH 1/1] enable cgit to show gravatar for author, committer and tagger

2014-01-13 Thread Christian Hesse
Jason A. Donenfeld ja...@zx2c4.com on Thu, 2014/01/09 16:19: On Thu, Jan 9, 2014 at 10:18 AM, Christian Hesse l...@eworm.de wrote: You modified the code to make the icon match the font size, which is 10pt by default. This is hard coded to the css file. Please note the URL includes a size

[PATCH 1/1] fix UTF-8 with email-gravatar.py

2014-01-14 Thread Christian Hesse
--- filters/email-gravatar.py | 4 1 file changed, 4 insertions(+) diff --git a/filters/email-gravatar.py b/filters/email-gravatar.py index f90b87d..5d08ea8 100755 --- a/filters/email-gravatar.py +++ b/filters/email-gravatar.py @@ -20,6 +20,7 @@ import sys import hashlib +import codecs

[PATCH 1/1] fix html syntax in email-gravatar.*

2014-01-14 Thread Christian Hesse
* make ampersand a html entity * add required alt attribute * add required img end tag --- filters/email-gravatar.lua | 2 +- filters/email-gravatar.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/filters/email-gravatar.lua b/filters/email-gravatar.lua index

[PATCH 1/1] filter: fix lua function name

2014-01-14 Thread Christian Hesse
--- filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/filter.c b/filter.c index 44af434..0cce7bb 100644 --- a/filter.c +++ b/filter.c @@ -319,7 +319,7 @@ static int close_lua_filter(struct cgit_filter *base) error_lua_filter(filter); ret

Re: [PATCH 1/1] fix email-gravatar.lua for lua 5.2

2014-01-14 Thread Christian Hesse
Jason A. Donenfeld ja...@zx2c4.com on Tue, 2014/01/14 13:48: Merged, thanks. What exactly is the reason for this change in Lua 5.2? No idea. Just noticed it is broken and fixed it. ;) -- Schoene Gruesse Chris O ascii ribbon campaign stop html mail

Re: [RESEND PATCH 1/1] enable cgit to show gravatar for author, committer and tagger

2014-01-14 Thread Christian Hesse
Jason A. Donenfeld ja...@zx2c4.com on Tue, 2014/01/14 18:23: On Tue, Jan 14, 2014 at 6:22 PM, Christian Hesse l...@eworm.de wrote: Looks better, though not perfect. At least firefox still scales the image a bit. Can you investigate the whole px to pt situation, line-height, and the best

Re: [RESEND PATCH 1/1] enable cgit to show gravatar for author, committer and tagger

2014-01-14 Thread Christian Hesse
Jason A. Donenfeld ja...@zx2c4.com on Tue, 2014/01/14 18:51: On Tue, Jan 14, 2014 at 6:35 PM, Christian Hesse l...@eworm.de wrote: Probably the only way to not have this is to use pixel only for images. Want a patch? I think I have it handled. Would you look at git.zx2c4.com/cgit/log

Re: maintenance release coming soon

2014-02-20 Thread Christian Hesse
Jason A. Donenfeld ja...@zx2c4.com on Thu, 2014/02/20 20:10: Hey guys, Last release was huge. A handful of little commits fixing small bugs has been piling up since our last big feature release. So I think sometime toward the end of next week, I'm going to release a 0.10.1 for bug fixes.

Re: Images on about page

2014-04-17 Thread Christian Hesse
Christian Hesse l...@eworm.de on Thu, 2014/04/17 12:13: Hello everybody, I have some README files in markdown that include images. The page itself is generated as expected, but the images fail: cgit returns a html page with binary data included. Any chance to just return the binary data

Re: [PATCH 1/1] filters: in markdown get images from their plain url

2014-04-17 Thread Christian Hesse
Jason A. Donenfeld ja...@zx2c4.com on Thu, 2014/04/17 12:57: Clever solution. But this breaks if we're ever including an image by an absolute URL. You are right... Maybe we should simply document that git-relative images should be linked via ../plain/ and leave it to the markdown author?

Re: [PATCH 1/1] filters: in markdown get images from their plain url

2014-04-17 Thread Christian Hesse
Jason A. Donenfeld ja...@zx2c4.com on Thu, 2014/04/17 13:44: Hmm still not perfect though. Let's say I want a relative URL that is out of the cgit root but still on the same domain... Probably it's better to do it right... The best solution would be to have cgit itself handle it. Looking at the

[PATCH 1/1] about: return images in plain mode

2014-04-17 Thread Christian Hesse
--- cgit.h | 2 ++ cmd.c | 52 shared.c | 41 + ui-plain.c | 40 4 files changed, 91 insertions(+), 44 deletions(-) diff --git a/cgit.h b/cgit.h index

Re: [PATCH 1/1] about: return images in plain mode

2014-04-17 Thread Christian Hesse
Christian Hesse m...@eworm.de on Thu, 2014/04/17 15:19: --- cgit.h | 2 ++ cmd.c | 52 shared.c | 41 + ui-plain.c | 40 4 files changed, 91

Re: [PATCH 1/1] about: return images in plain mode

2014-04-30 Thread Christian Hesse
Christian Hesse l...@eworm.de on Thu, 2014/04/17 15:21: Christian Hesse m...@eworm.de on Thu, 2014/04/17 15:19: --- cgit.h | 2 ++ cmd.c | 52 shared.c | 41 + ui-plain.c | 40

Re: [PATCH 1/1] git: update for git 2.0

2014-06-28 Thread Christian Hesse
Jason A. Donenfeld ja...@zx2c4.com on Sat, 2014/06/28 15:15: Merged, thanks! Thanks! If you want to send an addition patch layering on other 2.0 changes (strip_prefix and such), feel free -- I'll be merging things. I think Lukas had planned some changes. Lukas, are you going to send in

[PATCH 1/1] remove debug fprinf() calls that sneaked in with commit 79c985

2014-06-29 Thread Christian Hesse
From: Christian Hesse m...@eworm.de --- scan-tree.c | 4 1 file changed, 4 deletions(-) diff --git a/scan-tree.c b/scan-tree.c index 87fa0c7..044bcdc 100644 --- a/scan-tree.c +++ b/scan-tree.c @@ -115,7 +115,6 @@ static void add_repo(const char *base, struct strbuf *path, repo_config_fn

Re: [PATCH 1/1] remove debug fprinf() calls that sneaked in with commit 79c985

2014-06-29 Thread Christian Hesse
Jason A. Donenfeld ja...@zx2c4.com on Sun, 2014/06/29 20:25: 2.0.1 Bleeding edge! This is last stable release, no? -- main(a){char*c=/*Schoene Gruesse */B?IJj;MEH CX:;,b;for(a/*Chris get my mail address:*/=0;b=c[a++];) putchar(b-1/(/*

Re: [PATCH 1/1] about: return images in plain mode

2014-06-30 Thread Christian Hesse
Jason A. Donenfeld ja...@zx2c4.com on Sun, 2014/06/29 23:07: It still seems a bit hackish to me. That is what I said myself. ;) I need to think about it more, or hear some other ideas on it. This is more of a proof of concept than code you should merge. If you agree this is a good idea in

certificate problem with libravatar

2014-07-03 Thread Christian Hesse
Hello everybody, looks like we have a certificate problem with libravatar email filter. For base URL we use //cdn.libravatar.org/, with is fine if cgit serves unencrypted html pages. The url evaluates to http://cdn.libravatar.org/; then. However if cgit sends an encrypted site the url is

[PATCH 1/1] git: use xz compressed archive for download

2014-08-18 Thread Christian Hesse
From: Christian Hesse m...@eworm.de --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 8306028..f6e55a7 100644 --- a/Makefile +++ b/Makefile @@ -15,7 +15,7 @@ pdfdir = $(docdir) mandir = $(prefix)/share/man SHA1_HEADER = openssl/sha.h

[PATCH 1/1] filter: fix libravatar email-filter https issue

2014-09-10 Thread Christian Hesse
From: Christian Hesse m...@eworm.de Serving cgit via https and getting avatar via http gives error messages about untrusted content. This decides whether or not to use https link by looking at the environment variable HTTPS, which is set in CGI. --- filters/email-libravatar.lua | 3 ++- 1 file

[PATCH 2/2] git: use xz compressed archive for download

2014-09-22 Thread Christian Hesse
From: Christian Hesse m...@eworm.de This saves some download bandwidth. xz compression should be available on pretty every system nowadays. --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index b0e3901..a53eff2 100644 --- a/Makefile +++ b

[PATCH 1/1] git: update for v2.3.0

2015-02-07 Thread Christian Hesse
From: Christian Hesse m...@eworm.de * sort_string_list(): rename to string_list_sort() (upstream commit 3383e199) * update read_tree_recursive callback to pass strbuf as base (upstream commit 6a0b0b6d) Signed-off-by: Christian Hesse m...@eworm.de --- Makefile | 2 +- cgit.c | 2

[PATCH 1/1] shrink cgit.png file size

2015-02-11 Thread Christian Hesse
From: Christian Hesse m...@eworm.de Ran optipng against cgit.png, which shrank file size by more than eight percent. The image (including protocol overhead) should fit into a single network packet now. Optipng optimizes filters and compression. The actual pixel results are not altered. Signed

[PATCH 1/1] ui-shared: allow remote refs in branch switcher

2015-03-18 Thread Christian Hesse
From: Christian Hesse m...@eworm.de Signed-off-by: Christian Hesse m...@eworm.de --- ui-shared.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui-shared.c b/ui-shared.c index 1dd8722..ac5a287 100644 --- a/ui-shared.c +++ b/ui-shared.c @@ -895,6 +895,8 @@ static void print_header(void

[PATCH 1/1] git: update to v2.3.5

2015-03-31 Thread Christian Hesse
From: Christian Hesse m...@eworm.de Update to git version v2.3.5, no changes required. Signed-off-by: Christian Hesse m...@eworm.de --- Makefile | 2 +- git | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 1a900f8..7f797bf 100644

[PATCH 1/1] git: update to v2.3.1

2015-02-25 Thread Christian Hesse
From: Christian Hesse m...@eworm.de Update to git version v2.3.1, no changes required. Signed-off-by: Christian Hesse m...@eworm.de --- Makefile | 2 +- git | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 03e3f7c..fce8a2c 100644

[PATCH 1/1] git: update to v2.3.4

2015-03-23 Thread Christian Hesse
From: Christian Hesse m...@eworm.de Update to git version v2.3.4, no changes required. Signed-off-by: Christian Hesse m...@eworm.de --- Makefile | 2 +- git | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 1a900f8..fef75f2 100644

[PATCH 1/1] git: update to v2.3.6

2015-04-21 Thread Christian Hesse
From: Christian Hesse m...@eworm.de Update to git version v2.3.6, no changes required. Signed-off-by: Christian Hesse m...@eworm.de --- Makefile | 2 +- git | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 1a900f8..199af73 100644

[PATCH 1/1] git: update to v2.4.0

2015-04-30 Thread Christian Hesse
From: Christian Hesse m...@eworm.de Update to git version v2.4.0, no changes required. Signed-off-by: Christian Hesse m...@eworm.de --- Makefile | 2 +- git | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 1a900f8..e5096d9 100644

[PATCH 1/1] git: update to v2.4.1

2015-05-14 Thread Christian Hesse
From: Christian Hesse m...@eworm.de Update to git version v2.4.1, no changes required. Signed-off-by: Christian Hesse m...@eworm.de --- Makefile | 2 +- git | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 1a900f8..1f84c00 100644

[PATCH 1/1] git: update to v2.4.3

2015-06-07 Thread Christian Hesse
From: Christian Hesse m...@eworm.de Update to git version v2.4.3, no changes required. Signed-off-by: Christian Hesse m...@eworm.de --- Makefile | 2 +- git | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 1f84c00..0dab624 100644

[PATCH 1/1] git: update to v2.4.5

2015-06-25 Thread Christian Hesse
From: Christian Hesse m...@eworm.de Update to git version v2.4.5, no changes required. Signed-off-by: Christian Hesse m...@eworm.de --- Makefile | 2 +- git | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 1f84c00..69a22e6 100644

[PATCH 1/1] git: update to v2.4.4

2015-06-17 Thread Christian Hesse
From: Christian Hesse m...@eworm.de Update to git version v2.4.4, no changes required. Signed-off-by: Christian Hesse m...@eworm.de --- Makefile | 2 +- git | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 1f84c00..bf3fd1a 100644

Re: mimetypes about

2015-08-17 Thread Christian Hesse
Jason A. Donenfeld ja...@zx2c4.com on Mon, 2015/08/17 14:41: Hi Christian, I've merged your series. Thanks a lot for that. Thanks a lot! Also, I wound up rewriting the mimetype-from-file function to be a lot more clear and less error prone: http://git.zx2c4.com/cgit/tree/shared.c#n564

Re: mimetypes about

2015-08-17 Thread Christian Hesse
Christian Hesse l...@eworm.de on Mon, 2015/08/17 15:00: Also, I wound up rewriting the mimetype-from-file function to be a lot more clear and less error prone: http://git.zx2c4.com/cgit/tree/shared.c#n564 Looks like that broke it for me... I will take a look at what goes wrong. Ah

[PATCH 3/3] ui-summary: send images plain for about page

2015-08-16 Thread Christian Hesse
From: Christian Hesse m...@eworm.de The about page used to display just fine, but images were broken: The binary image data was embedded in html code. Use cgit_print_plain() to send images in plain mode and make them available on about page. Signed-off-by: Christian Hesse m...@eworm.de --- ui

[PATCH 1/1] RFC: git: update to v2.5.0-rc0

2015-06-26 Thread Christian Hesse
From: Christian Hesse m...@eworm.de Update to git version v2.5.0-rc0. * Upstream commit 5455ee0573a22bb793a7083d593ae1ace909cd4c (Merge branch 'bc/object-id') changed API: for_each_ref() callback functions were taught to name the objects not with unsigned char sha1[20] but with struct

[PATCH 1/1] git: update to v2.5.0

2015-07-28 Thread Christian Hesse
From: Christian Hesse m...@eworm.de Update to git version v2.5.0. * Upstream commit 5455ee0573a22bb793a7083d593ae1ace909cd4c (Merge branch 'bc/object-id') changed API: for_each_ref() callback functions were taught to name the objects not with unsigned char sha1[20] but with struct

Re: [PATCH v2 00/22] HTTP status code improvements

2015-08-14 Thread Christian Hesse
minutes faster, so... Reviewed-by: Christian Hesse m...@eworm.de -- 8 -- Subject: [PATCH] cmd: fix command definition The previous commit removed the pre field from struct cgit_cmd but forgot to update this macro. Signed-off-by: John Keeping j...@keeping.me.uk --- cmd.c | 2 +- 1

[PATCH 2/2] about: send images plain

2015-08-14 Thread Christian Hesse
From: Christian Hesse m...@eworm.de The about page used to display just fine, but images were broken: The binary image data was embedded in html code. Use cgit_print_plain() to send images in plain mode and make them available on about page. Signed-off-by: Christian Hesse m...@eworm.de

[PATCH 2/3] about: send images plain

2015-08-14 Thread Christian Hesse
From: Christian Hesse m...@eworm.de The about page used to display just fine, but images were broken: The binary image data was embedded in html code. Use cgit_print_plain() to send images in plain mode and make them available on about page. Signed-off-by: Christian Hesse m...@eworm.de --- ui

[PATCH 2/3] refactor get_mimetype_from_file() to get_mimetype_from_qrypath()

2015-08-15 Thread Christian Hesse
From: Christian Hesse m...@eworm.de * handle mimetype within a single function + return allocated memory on success Signed-off-by: Christian Hesse m...@eworm.de --- cgit.h | 2 +- shared.c | 65 +++--- ui-plain.c | 29

[PATCH 2/6] ui-blob: fix resource leak: free before return

2015-10-10 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> Coverity-id: 13943 Signed-off-by: Christian Hesse <m...@eworm.de> --- ui-blob.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui-blob.c b/ui-blob.c index 9824c90..1ded839 100644 --- a/ui-blob.c +++ b/ui-blob.c @@ -99,6 +99,7 @@ int cgit_pri

[PATCH 4/6] ui-atom: fix resource leak: free before return

2015-10-10 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> Coverity-id: 13946 Signed-off-by: Christian Hesse <m...@eworm.de> --- ui-atom.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ui-atom.c b/ui-atom.c index d7138fb..fab4b0f 100644 --- a/ui-atom.c +++ b/ui-atom.c @@ -80,7 +80

[PATCH 5/6] ui-atom: fix resource leak: free allocation from cgit_pageurl

2015-10-10 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> Coverity-id: 13945 Signed-off-by: Christian Hesse <m...@eworm.de> --- ui-atom.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ui-atom.c b/ui-atom.c index fab4b0f..e186299 100644 --- a/ui-atom.c +++ b/ui-atom.c @@ -

[PATCH 6/6] cache: fix resource leak: close file handle before return

2015-10-10 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> Coverity-id: 13910 Signed-off-by: Christian Hesse <m...@eworm.de> --- cache.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/cache.c b/cache.c index 57c8918..b169d20 100644 --- a/cache.c +++ b/cache.c @@ -21

filter rework break about page

2015-10-11 Thread Christian Hesse
Hello everybody, commit 'filters: Simplify converters' (525c815) breaks the about page, it is simply empty. Reverting the patch restores the expected behavior. I did not yet analyze the issue. -- main(a){char*c=/*Schoene Gruesse */"B?IJj;MEH" "CX:;",b;for(a/*Chris

Re: filter rework break about page

2015-10-11 Thread Christian Hesse
Christian Hesse <l...@eworm.de> on Sun, 2015/10/11 12:06: > Hello everybody, > > commit 'filters: Simplify converters' (525c815) breaks the about page, it is > simply empty. Reverting the patch restores the expected behavior. I did not > yet analyze the issue. Ah, took me ju

Re: filter rework break about page

2015-10-11 Thread Christian Hesse
"Jason A. Donenfeld" on Sun, 2015/10/11 14:09: > What package is that from? Link to upstream? https://www.archlinux.org/packages/community/any/markdown/ http://daringfireball.net/projects/markdown/ -- main(a){char*c=/*Schoene Gruesse */"B?IJj;MEH"

Re: filter rework break about page

2015-10-12 Thread Christian Hesse
Christian Hesse <l...@eworm.de> on Mon, 2015/10/12 11:57: > May be interesting to have an option to specify a command and its options, > though. Discount [0] is just another implementation written in plain C. That > could bring some more performance improvements. > &g

Re: [PATCH 1/2] ui-stats: free without condition

2015-10-12 Thread Christian Hesse
John Keeping <j...@keeping.me.uk> on Mon, 2015/10/12 10:10: > On Mon, Oct 12, 2015 at 10:59:34AM +0200, Christian Hesse wrote: > > From: Christian Hesse <m...@eworm.de> > > > > xstrdup() returns allocated memory or NULL. It's safe to call free() > > withou

Re: filter rework break about page

2015-10-12 Thread Christian Hesse
Christian Hesse <l...@eworm.de> on Sun, 2015/10/11 18:13: > "Jason A. Donenfeld" <ja...@zx2c4.com> on Sun, 2015/10/11 14:09: > > What package is that from? Link to upstream? > > https://www.archlinux.org/packages/community/any/markdown/ > http://dar

[PATCH 1/2] ui-stats: free without condition

2015-10-12 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> xstrdup() returns allocated memory or NULL. It's safe to call free() without condition. Coverity-Id 13839 is kind of false posivtive, but this should fix it nevertheless. Coverity-Id: 13839 Signed-off-by: Christian Hesse <m...@eworm.de> --- ui

[PATCH 2/2] ui-stats: do not duplicate string

2015-10-12 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> string_list_insert() expects (const char*), so no need to duplicate and free the string. Signed-off-by: Christian Hesse <m...@eworm.de> --- ui-stats.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/ui-stats.c b/ui-s

[PATCH 1/1] filters: force python 3.x and fix options

2015-10-12 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> The python markdown module is a little bit picky when it come to options. So force python 3.x and fix the options. Documentation says about input: [...] or None (default) which will read from stdin. Signed-off-by: Christian Hesse <m...

[PATCH 1/1] filters: port syntax-highlighting.py to python 3.x

2015-10-12 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> Signed-off-by: Christian Hesse <m...@eworm.de> --- filters/syntax-highlighting.py | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/filters/syntax-highlighting.py b/filters/syntax-highlighting.py index bcf3

Re: [PATCH 1/1] filters: force python 3.x and fix options

2015-10-12 Thread Christian Hesse
"Jason A. Donenfeld" on Mon, 2015/10/12 18:34: > Python 2 works fine. But thanks for that catch with input already > defaulting to stdin. Applied that optimization. The python 3.x part was from a packager's point of view. We have other scripts that force python 3.x. For systems

Re: [PATCH 6/8] cmd: fix resource leak: free allocation from cgit_currenturl and fmtalloc

2015-10-09 Thread Christian Hesse
Ferry Huberts on Fri, 2015/10/09 14:13: > I have the experience that it sometimes misses things that are then > found in the next build. > Or that it flags a whole load of lines without issues. > It doesn't happen a lot though. Sometimes. > > Let's call it temperamental...

[PATCH 4/4] ui-plain: fix resource leak: free before assigning NULL

2015-10-09 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> Coverity-id: 13939 Signed-off-by: Christian Hesse <m...@eworm.de> --- ui-plain.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ui-plain.c b/ui-plain.c index 4c73607..e4beb99 100644 --- a/ui-plain.c +++ b/ui-plain.c @@

[PATCH 3/4] ui-plain: fix resource leak: free before return

2015-10-09 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> Coverity-id: 13940 Signed-off-by: Christian Hesse <m...@eworm.de> --- ui-plain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui-plain.c b/ui-plain.c index 0dd1a8b..4c73607 100644 --- a/ui-plain.c +++ b/ui-plain.c @@ -51,6 +51,7 @

[PATCH 1/4] ui-repolist: fix resource leak: free before return

2015-10-09 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> Coverity-id: 13931 Signed-off-by: Christian Hesse <m...@eworm.de> --- ui-repolist.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ui-repolist.c b/ui-repolist.c index ac1b3e3..4f52e0f 100644 --- a/ui-repolist.c +++ b/u

Re: [PATCH 6/8] cmd: fix resource leak: free allocation from cgit_currenturl and fmtalloc

2015-10-09 Thread Christian Hesse
"Jason A. Donenfeld" on Fri, 2015/10/09 14:03: > No coverity-id on this commit. Did you find this one yourself? Yes. No idea why coverity did not see this... -- main(a){char*c=/*Schoene Gruesse */"B?IJj;MEH" "CX:;",b;for(a/*Chris get my

[PATCH 1/1] git: update to v2.5.1

2015-08-29 Thread Christian Hesse
From: Christian Hesse m...@eworm.de Update to git version v2.5.1, no changes required. Signed-off-by: Christian Hesse m...@eworm.de --- Makefile | 2 +- git | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index a0a6615..2e7b31a 100644

[PATCH 1/1] git: update to v2.5.3

2015-09-20 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> Update to git version v2.5.3, no changes required. Signed-off-by: Christian Hesse <m...@eworm.de> --- Makefile | 2 +- git | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index a0a6615..bc

[PATCH v2 1/1] RFC: git: update to v2.7.0-rc0

2015-12-11 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> Update to git version v2.7.0-rc0. * Upstream commit ed1c9977cb1b63e4270ad8bdf967a2d02580aa08 (Remove get_object_hash.) changed API: Convert all instances of get_object_hash to use an appropriate reference to the hash member of the oid member of

[PATCH 1/1] git: update to v2.7.0

2016-01-04 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> Update to git version v2.7.0. * Upstream commit ed1c9977cb1b63e4270ad8bdf967a2d02580aa08 (Remove get_object_hash.) changed API: Convert all instances of get_object_hash to use an appropriate reference to the hash member of the oid member of

[PATCH 1/1] git: update to v2.7.1

2016-02-08 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> Update to git version v2.7.1, no changes required. Signed-off-by: Christian Hesse <m...@eworm.de> --- Makefile | 2 +- git | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 6590d8e..8b

Re: [PATCH 1/1] css: use less blurry icon for external link

2016-02-23 Thread Christian Hesse
John Keeping <j...@keeping.me.uk> on Tue, 2016/02/23 10:07: > On Tue, Feb 23, 2016 at 10:47:25AM +0100, Christian Hesse wrote: > > Your mileage may vary, but for me the old icon looks blurry. The new > > one is character 0xf08e from OTF font awsome in size 10. > > Th

[PATCH 1/1] css: replace icon for external link with one from wikipedia

2016-02-23 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> This file is licensed with GPLv2 or later, so we should be fine using it. https://commons.wikimedia.org/wiki/File:Icon_External_Link.png Signed-off-by: Christian Hesse <m...@eworm.de> --- cgit.css | 3 ++- 1 file changed, 2 insertions(+)

[PATCH 1/1] css: use less blurry icon for external link

2016-02-23 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> Your mileage may vary, but for me the old icon looks blurry. The new one is character 0xf08e from OTF font awsome in size 10. The icon color is black, gray level is adjusted via opacity. Signed-off-by: Christian Hesse <m...@eworm.de> --- cgit.cs

[PATCH 1/1] RFC: git: update to v2.8.0-rc0

2016-02-27 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> Update to git version v2.8.0-rc0. * Upstream commit 1a0c8dfd89475d6bb09ddee8c019cf0ae5b3bdc2 (strbuf: give strbuf_getline() to the "most text friendly" variant) changed API. Signed-off-by: Christian Hesse <m...@eworm.de> --- Mak

Re: [PATCH 1/1] css: use less blurry icon for external link

2016-02-23 Thread Christian Hesse
"Jason A. Donenfeld" on Tue, 2016/02/23 15:18: > Thanks. I did actually do this myself in inkscape from an svg > representation of the font, but I must have hit the anti aliasing > button or something. Also, the opacity is much better, thanks. > > I merged this, and also ran the

Re: [PATCH v2 1/1] scan-tree: handle error in git_config_from_file()

2016-03-10 Thread Christian Hesse
"Jason A. Donenfeld" on Wed, 2016/03/09 12:05: > Are repos without .git/config necessarily invalid? No. But repositories with config file available but permission denied are. Looks like we can not see the difference here... -- main(a){char*c=/*Schoene Gruesse

[PATCH v2 1/1] scan-tree: handle error in git_config_from_file()

2016-03-09 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> We can live without config, but print an error if it is not readable. --- scan-tree.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scan-tree.c b/scan-tree.c index 2e87999..bc17d14 100644 --- a/scan-tree.c +++ b/scan-

[PATCH 1/1] git: update to v2.7.4

2016-03-19 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> Update to git version v2.7.4, no changes required. Signed-off-by: Christian Hesse <m...@eworm.de> --- Makefile | 2 +- git | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index c01701c..87

Re: [PATCH 1/1] scan-tree: handle error in git_config_from_file()

2016-03-08 Thread Christian Hesse
John Keeping <j...@keeping.me.uk> on Tue, 2016/03/08 14:11: > On Tue, Mar 08, 2016 at 02:51:46PM +0100, Christian Hesse wrote: > > From: Christian Hesse <m...@eworm.de> > > > > Signed-off-by: Christian Hesse <m...@eworm.de> > > Is this solvin

Re: [PATCH 1/1] scan-tree: handle error in git_config_from_file()

2016-03-08 Thread Christian Hesse
John Keeping <j...@keeping.me.uk> on Tue, 2016/03/08 14:36: > On Tue, Mar 08, 2016 at 03:26:23PM +0100, Christian Hesse wrote: > > John Keeping <j...@keeping.me.uk> on Tue, 2016/03/08 14:11: > > > On Tue, Mar 08, 2016 at 02:51:46PM +0100, Christian Hesse wrote: &g

Re: [PATCH 1/1] scan-tree: handle error in git_config_from_file()

2016-03-08 Thread Christian Hesse
John Keeping <j...@keeping.me.uk> on Tue, 2016/03/08 14:59: > On Tue, Mar 08, 2016 at 03:54:22PM +0100, Christian Hesse wrote: > > John Keeping <j...@keeping.me.uk> on Tue, 2016/03/08 14:36: > > > On Tue, Mar 08, 2016 at 03:26:23PM +0100, Christian Hesse wr

[PATCH 1/1] git: update to v2.8.0

2016-03-28 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> Update to git version v2.8.0. * Upstream commit 1a0c8dfd89475d6bb09ddee8c019cf0ae5b3bdc2 (strbuf: give strbuf_getline() to the "most text friendly" variant) changed API. Signed-off-by: Christian Hesse <m...@eworm.de> --- M

[PATCH 1/1] git: update to v2.8.3

2016-05-19 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> Update to git version v2.8.3, no changes required. Signed-off-by: Christian Hesse <m...@eworm.de> --- Makefile | 2 +- git | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index a7aa08b..23

Re: [PATCH 1/1] ui-log: do not print empty table rows

2016-07-12 Thread Christian Hesse
Christian Hesse <l...@eworm.de> on Thu, 2016/07/07 12:54: > "Jason A. Donenfeld" <ja...@zx2c4.com> on Thu, 2016/07/07 12:28: > > Hmm, so this fixes the problem with the log highlighting, but it might > > not be a full fix: > > > > https://git.zx2c

[PATCH 1/1] RFC: git: update to v2.10.0-rc0

2016-08-15 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> Upstream continues to replace unsigned char *sha1 with struct object_id old_oid. This makes the required changes. The upstream declaration of main function changed, resulting in error: Multiple definition of `main'. An additional patch for git is re

[PATCH 1/1] RFC: git: update to v2.10.0-rc0 part 2

2016-08-15 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> Just a follow-up to replace more sha1 with oid. Signed-off-by: Christian Hesse <m...@eworm.de> --- ui-diff.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/ui-diff.c b/ui-diff.c index 0819919..173d351 100

Re: [PATCH 1/1] RFC: git: update to v2.10.0-rc0

2016-08-15 Thread Christian Hesse
John Keeping on Mon, 2016/08/15 11:09: > On Mon, Aug 15, 2016 at 10:02:39AM +, Juuso Lapinlampi wrote: > > Please keep the latest Git submodule at a stable version, e.g. 2.9.3 for > > master branch. I'm okay with this change being in a pu branch, to be > > merged to next

[PATCH v2 1/1] RFC: git: update to v2.10.0-rc0

2016-08-15 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> Upstream continues to replace unsigned char *sha1 with struct object_id old_oid. This makes the required changes. The git lib has its own main function now. Rename our main function to cmd_main, it is called from main then. Signed-off-by: Christian He

[PATCH 1/1] git: update to v2.9.3

2016-08-13 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> Update to git version v2.9.3, no changes required. Signed-off-by: Christian Hesse <m...@eworm.de> --- Makefile | 2 +- git | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 9d067d4..1f

Re: [PATCH 1/1] git: update to v2.9.2

2016-07-16 Thread Christian Hesse
Christian Hesse <l...@eworm.de> on Sat, 2016/07/16 10:45: > From: Christian Hesse <m...@eworm.de> > > Update to git version v2.9.2, no changes required. This is only a fix to the test suite, so decide on your own whether or not you want that. ;) -- main(a){char*c=

[PATCH 1/1] git: update to v2.9.1

2016-07-11 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> Update to git version v2.9.1, no changes required. Signed-off-by: Christian Hesse <m...@eworm.de> --- Makefile | 2 +- git | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index c7a57f8..9d

[PATCH 1/1] css: highlight even table rows

2016-07-06 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> This is stolen from kernel.org css [0]. [0] https://git.kernel.org/cgit-korg-0.10.1.css Signed-off-by: Christian Hesse <m...@eworm.de> --- cgit.css | 12 1 file changed, 12 insertions(+) diff --git a/cgit.css b/cgit.css index a433

Re: [PATCH 1/1] css: highlight even table rows

2016-07-07 Thread Christian Hesse
"Jason A. Donenfeld" on Thu, 2016/07/07 00:00: > This seems not to work as well on the log: > https://git.zx2c4.com/cgit/log/ Works for me... (on a local installation) Possibly this is caused but the commit graph? I will take a look. -- main(a){char*c=/*Schoene Gruesse

[PATCH 1/1] css, ui-log: highlight empty rows in commit graph, but do not hover

2016-07-07 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> Add more CSS to highlight empty rows in commit graph, but do not hover. Signed-off-by: Christian Hesse <m...@eworm.de> --- cgit.css | 8 ui-log.c | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/cgit.css b/cg

Re: [PATCH 1/1] ui-log: do not print empty table rows

2016-07-07 Thread Christian Hesse
"Jason A. Donenfeld" on Thu, 2016/07/07 12:28: > Hmm, so this fixes the problem with the log highlighting, but it might > not be a full fix: > > https://git.zx2c4.com/systemd/log/ I attached a screenshot from what it looks like currently. You speak about the rows pointed to by

[PATCH 1/1] ui-repolist: highlight section rows, but do not hover

2016-07-07 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> Signed-off-by: Christian Hesse <m...@eworm.de> --- ui-repolist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui-repolist.c b/ui-repolist.c index 30915df..bef565a 100644 --- a/ui-repolist.c +++ b/ui-repolist.c @@ -320,7 +3

[PATCH 1/1] git: update to v2.11.1

2017-02-02 Thread Christian Hesse
From: Christian Hesse <m...@eworm.de> Update to git version v2.11.1, no changes required. Signed-off-by: Christian Hesse <m...@eworm.de> --- Makefile | 2 +- git | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index fe6cc98..7b

RFC: replace 'unsigned char sha1[20]' with 'struct object_id oid'

2016-09-29 Thread Christian Hesse
) Christian Hesse (10): cgit: replace 'unsigned char sha1[20]' with 'struct object_id oid' ui-blob: replace 'unsigned char sha1[20]' with 'struct object_id oid' ui-commit: replace 'unsigned char sha1[20]' with 'struct object_id oid' ui

  1   2   3   4   >