This is to support things like go-import meta tags, which are on a
per-repo basis.
Signed-off-by: Jason A. Donenfeld <ja...@zx2c4.com>
---
This is kind of really ugly, and I'm not keen on its approach, but I
thought I'd post it to get some feedback on the general "requirement&quo
This patchset has been merged to master. Thanks for your contribution!
Jason
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Thanks, merged this.
I grabbed the commit from this email, rather than from your branch in
the repo, because this one had the signed-off-by line and the other
didn't.
Jason
___
CGit mailing list
CGit@lists.zx2c4.com
Works remarkably well. Excellent work. Example, for others on the list:
https://git.zx2c4.com/WireGuard/blame/src/noise.c
Pending objections from others, I'll merge this from jd/color-blame to
master in a few days.
Thanks for this series!
Jason
___
Just waiting on resubmission of this 4/4, then. I'll put 1-3 in a branch.
Jason
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Hi Jeff,
Oh, cool. What's your idea for accomplishing that? Planning on putting
it through the filter, buffering it, and then spitting it back out in
equal sized chunks, hoping the filter doesn't add extra new lines?
Jason
___
CGit mailing list
Right, we may very well need a more capable model.
One approach would be to get rid of all the exec stuff, and instead
have plugins, that can register themselves in all sorts of places. A
plugin would define a series of hooks and filters, which would be
directly called at the right time. We'd
Applied thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
).
Jason A. Donenfeld (4):
filter: add generic scafolding for temporarily disabling filter
filter: wire up exec_filter to enable function
filter: wire up lua_filter to enable function
ui-blame: put source lines through filter
cgit.h | 3 +++
filter.c | 46
We also move pipe_fh to be local, since it's not needed any place else.
Signed-off-by: Jason A. Donenfeld <ja...@zx2c4.com>
---
cgit.h | 1 +
filter.c | 27 +--
2 files changed, 22 insertions(+), 6 deletions(-)
diff --git a/cgit.h b/cgit.h
index 8da69e7..f
Signed-off-by: Jason A. Donenfeld <ja...@zx2c4.com>
---
filter.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/filter.c b/filter.c
index 4deb4de..7b5bef5 100644
--- a/filter.c
+++ b/filter.c
@@ -353,6 +353,15 @@ static int close_lua_filter(struct cgit_filter
We toggle the filter on and off so that the control table can avoid
going through the filter.
Signed-off-by: Jason A. Donenfeld <ja...@zx2c4.com>
---
ui-blame.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/ui-blame.c b/ui-blame.c
index 62cf431..7
Looks reasonable to me. Thanks for reporting, Tom, and thanks for the
patch John. Applied.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Merged to master. Working quite nicely:
https://git.zx2c4.com/cgit/blame/ui-shared.c
Jeff -- do we want to be passing this through the source code filter
to get highlighted lines?
___
CGit mailing list
CGit@lists.zx2c4.com
Merged, thanks!
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
On Wed, Jul 26, 2017 at 8:34 PM, Christian Hesse wrote:
>> Jason, any chance you can go through our for-jason branches and merge
>> them anytime soon?
>
> Yes, please!
Absolutely. I'm finishing up a time consuming job this week, and
mid-next week, I'll start merging.
Hey John,
Wow, that was quick. Konstantin and I were just talking about this.
I'll review this and merge things asap.
Another related thing were were discussing and I was just
investigating is the inherent buffering that our cache system uses.
When it's filling a slot, everything is buffered
Hey Jeff,
If option 1 can be done cleanly enough, that'd be fine with me.
Jason
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Looks good to me.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
On Sun, Mar 12, 2017 at 6:51 PM, John Keeping wrote:
> While I'm inclined to agree with this, in this particular case we
> explicitly encode pages as UTF-8 so there is an argument that we should
> be telling child processes that UTF-8 is the correct encoding.
That's a
Hey guys,
Sorry for the delay. I'm currently on the road traveling and won't be
properly back at my desk until the end of next week.
However, my initial reaction is that hard coding various
interpreter-specific environment variables in cgit itself is not
correct, and that this is something
Can you resubmit this series as a normal git-send-email situation?
Very hard to review as attachments like this.
Thanks,
Jason
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Excellent. Running AFL on cgit is a great idea. I'll merge and review when
I'm back at my desk on Tuesday.
On Feb 19, 2017 12:45, "John Keeping" wrote:
I set AFL [0] loose on CGit's URL input yesterday and it managed to find
one issue that leads to a segfault via a null
Seems most reasonable to simply keep it something static and not add a nob.
However, John - you raise a good point. Git's diff feature isn't
exactly stable itself, with all sorts of interesting new diffing
strategies being tried out in newer versions. So perhaps this isn't
really an feasible goal
Thanks. I'll review and merge.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Nice catch, thanks.
Merged.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Thanks for the reminder. Merged!
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Looks fine to me. Queue it up.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Hurd!
Honored to merge this.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Hi Lukas,
Seems fine to me. Queue it up.
Jason
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Jeeze louise, nice catch. Thanks. Merged.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
On Thu, Nov 24, 2016 at 6:32 PM, Petr Vorel wrote:
> Any idea how to cope with it? I thought to use this feature only if repo.name
> and repo.url
> are the same.
One way might be to always use the `name` part and not the `url`, but
to ensure that any clickable links are
4.com/keys/AB9942E6D4A4CFC3412620A749FC7012A5DE03AE.asc
Thanks to everyone who contributed to this release!
Jason Donenfeld
-BEGIN PGP SIGNATURE-
iQIzBAEBCAAdFiEEq5lC5tSkz8NBJiCnSfxwEqXeA64FAlg1HTsACgkQSfxwEqXe
A65/eA//Y0b2rVaPvwFuUbf3QEI2lm9yxgf5P2yzHGrbaHxeUjpzU5
Thanks for the reminder. In progress now.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Looks good. Queue it up!
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
I think there actually might be a trick using rlimit to implement this
type of streaming size check...
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
LGTM.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
So what's the verdict here? Do we have a double free or not?
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
I face this same problem, in fact. Unless somebody beats me to it, I'd
be interested in giving this a stab.
One issue is that cache entries are currently "streamed" into the
cache files, as they're produced. It's not trivially possible to know
how big it's going to be beforehand. This means that
Nice find, thanks. Queue 'er up.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Also looks good.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Does this ever get freed, though?
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Looks good to me.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Thanks! Queue it up.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
On Tue, Oct 4, 2016 at 9:51 AM, Christian Hesse wrote:
> + hashcpy(walk_tree_ctx->matched_oid.hash, sha1);
> + if (sha1_object_info(oid.hash, ) != OBJ_COMMIT)
> + type = sha1_object_info(oid.hash, );
> + type = sha1_object_info(oid.hash, );
> +
Also, to clarify --
The patch for cgit for this should probably be just adding
id="section_name" to the various divs. Then users' stylesheets and js
files can contain the necessary logic for which to hide and when to
hide it. That is, unless you can think of some really slick way to
roll this out
On Mon, Oct 3, 2016 at 5:44 PM, Andy Doan wrote:
> I'll work up a dynamic version this today and throw it on another Linaro
> mirror so you can compare the differences.
Great! The unicode characters ▶, ▸, ▼, and ▾ might come in handy,
depending on how you implement it.
Honestly I thought it was really ugly at first. But then I tried it
out on git.zx2c4.com and forgot about it, and now after looking at it
for a bunch of months, I don't mind it. So apparently you and
kernel.org both like this. So maybe I should merge it.
Does anybody have any objections due to
Hey John,
I see the utility of this with something like a highlight filter gone
bad. But is it safe to do this in the context of an authentication
filter? What's the failure behavior like once this patch is applied?
Jason
___
CGit mailing list
Hey Andy,
One issue with this is -- isn't this the sort of thing that would be
better taken care of with css3 or css+javascript? That is to say you
list the children of some elements as being display:none until they're
clicked, and then upon click you make it visible? This seems like it'd
be a
Hey John,
I merged all of this except the last two commits, which I'd like to
discuss a bit more. Those live in jk/collapsible-sections. I'll chime
in on the other thread about that.
Thanks,
Jason
___
CGit mailing list
CGit@lists.zx2c4.com
This looks sane to me. It results in more allocations, but I think
that's a moot point compared to the nice code simplifications and
deduplication.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Hi Ferry,
I suppose this would be something for the contrib/ section. I wouldn't
be all together opposed to filling this directory with lots of
different integrations for various project management applications,
web servers, and so forth, but one pitfall I've seen numerous times in
my projects
Hey folks,
I wanted to update you on a conversation a few of us have been having
off-list. In order to hasten the speed of development, we're making
some changes to the way things are done.
All submitted patch series will now live in feature branches. Each
feature branch will be owned by either
It looks mostly good to me. I'll get this in the next release.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
On Aug 15, 2016 12:02 PM, "Juuso Lapinlampi" wrote:
>
> Please keep the latest Git submodule at a stable version, e.g. 2.9.3 for
> master branch. I'm okay with this change being in a pu branch, to be
> merged to next and eventually master later. (Ignoring the fact that cgit
>
On Sat, Jul 16, 2016 at 12:59 AM, Richard Maw wrote:
> Signed-off-by: Richard Maw
> ---
> cgitrc.5.txt | 32
> 1 file changed, 32 insertions(+)
>
> diff --git a/cgitrc.5.txt b/cgitrc.5.txt
> index 9fcf445..6116d1b
On Sat, Jul 16, 2016 at 12:59 AM, Richard Maw wrote:
> + if (ref_exists(namespaced_note_ref.buf)) {
> + if (has_glob_specials(namespaced_note_ref.buf)) {
> + for (const char *c = namespaced_note_ref.buf;
>
On Sat, Jul 16, 2016 at 12:59 AM, Richard Maw wrote:
> + unsigned char unused[20];
> + char *namespaced_head = NULL;
> + const char *ref;
> + namespaced_head = mkpathdup("%sHEAD", get_git_namespace());
> +
On Sat, Jul 16, 2016 at 12:59 AM, Richard Maw wrote:
> -
> - ref = resolve_ref_unsafe("HEAD", 0, sha1, NULL);
> - if (!ref || !starts_with(ref, "refs/heads/"))
> + char *namespaced_head = NULL;
> +
> + if (get_git_namespace())
> +
On Sat, Jul 16, 2016 at 12:59 AM, Richard Maw wrote:
> +static int namespaced_dwim_ref_get_sha1(const char *name, unsigned char
> *sha1)
> +{
> + /* The standard git name disambiguation order is:
> +$name
> +refs/$name
> +
Thanks for the reminder! I'll take a look tomorrow morning.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
On Tue, Jul 12, 2016 at 11:16 AM, Richard <richard@gmail.com> wrote:
> On 12 July 2016 at 00:12, Jason A. Donenfeld <ja...@zx2c4.com> wrote:
>> Sorry for the churn here, but this doesn't apply, due to Lukas' recent
>> patch. Could you respin this?
>
> Su
Sorry for the churn here, but this doesn't apply, due to Lukas' recent
patch. Could you respin this?
By the way, feel free to alternatively submit this series with
git-request-pull if you've got it in a repo somewhere.
___
CGit mailing list
Merged, thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
This seems not to work as well on the log:
https://git.zx2c4.com/cgit/log/
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Seems like a more sensible approach. I'll merge this and see if
anybody complains.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Merged, thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Hey Lukas,
I appreciate that this unifies the 'v' detection code as well. I also
like the "(a==0 + b==0 + c==0) == 1" trick. I'll merge this, and base
the fixes for tags with / in them on this commit.
Thanks,
Jason
___
CGit mailing list
I merged this series, but applied John's suggestion of not doing the
extra trailing line.
Thanks Christian.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
UGH. Wrong list.
Sorry guys.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Hi guys,
I've started compiling various example scripts of `wg(8)` usage in
contrib/examples [1]. The ncat-client-server [2] one is the insecure
script folks are currently using for testing their install with demo
dot wireguard dot io. The systemd one [3] is the hairy
wgserver.service test unit
Hi Richard,
This looks like really cool work. I'll review it this week and get
back to you. Thanks for submitting.
Jason
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Hey Christian,
This is very pretty. I'll test drive it for a few days, but I like it
overall.
[image: Inline image 1]
Thanks for the patch!
Jason
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Hey Peter,
I wonder if a better way would be match the particular libc out of
uname -o. In this case, GNU libc needs -ldl. Do other libcs also need
libdl? Seems like this might be slightly cleaner.
Any opinions on this list?
Jason
___
CGit mailing
I'll try to hook this up to the lua scripting.
On holiday now in Japan, but I'll write more later when back at a real PC.
On Jun 3, 2016 10:46 PM, "Konstantin Ryabitsev" wrote:
> Hi, all:
>
> It would be handy to have a way to hide inactive repositories from the
> main index
Does that vuln apply to our usage of libgit?
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Merged, thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
This is live on git.zx2c4.com . So far it looks good to me.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
On Wed, May 11, 2016 at 7:48 PM, Juuso Lapinlampi wrote:
> CRLF is explicitly defined as the line break in the HTTP protocol
> specifications: RFC 2616 (obsolete) and RFC 7230.
But this is CGI, not HTTP.
___
CGit mailing list
Merged, thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Could we instead just remove action? Does this work both in the case
of path/to/page and path/to/page/ ? Or in the former will this wind up
requesting path/to/.?
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
On Wed, May 11, 2016 at 8:56 PM, John Keeping wrote:
> This seems like a reasonable aim, but don't we need to actually *be*
> HTML(5?) as well in order to do this? Currently we close and
> tags even though HTML is explicit that this shouldn't be done.
No, in HTML5 you can
On Wed, May 11, 2016 at 8:04 PM, Juuso Lapinlampi wrote:
>
> static const char cgit_doctype[] =
> -" -" \"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd\;>\n";
> +""\n";
Not syntactically valid C either. Test your commits before you submit.
On Wed, May 11, 2016 at 7:50 PM, Juuso Lapinlampi wrote:
> - cgit_print_docstart();
> - cgit_print_pageheader();
> + cgit_print_layout_start()
> va_start(ap, fmt);
You forgot a semicolon. Please test your commits before you submit.
Otherwise you waste
Hi Paul,
We added vcs-git per your request [1]. Now there's talk of removing it.
Could you give full justification for its existence? How is it useful?
What uses it?
Thanks,
Jason
___
CGit mailing list
CGit@lists.zx2c4.com
Merged!
It's time we grow up.
If this causes rendering errors due to compatibility modes the prior
XHTML header was triggering, we can fix those up in subsequent
commits.
___
CGit mailing list
CGit@lists.zx2c4.com
Merged, thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Can you rename this from "summary-enable-split-repo-link" to
"split-summary-repo-link"?
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Merged, thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Merged, thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Merged, thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Are repos without .git/config necessarily invalid?
zx2c4@thinkpad ~ $ mkdir abcd
zx2c4@thinkpad ~ $ cd abcd
zx2c4@thinkpad ~/abcd $ git init
Initialized empty Git repository in /home/zx2c4/abcd/.git/
zx2c4@thinkpad ~/abcd $ touch file
zx2c4@thinkpad ~/abcd $ git add file
zx2c4@thinkpad ~/abcd $
Are repos without .git/config necessarily invalid?
zx2c4@thinkpad ~ $ mkdir abcd
zx2c4@thinkpad ~ $ cd abcd
zx2c4@thinkpad ~/abcd $ git init
Initialized empty Git repository in /home/zx2c4/abcd/.git/
zx2c4@thinkpad ~/abcd $ touch file
zx2c4@thinkpad ~/abcd $ git add file
zx2c4@thinkpad ~/abcd $
Ahh, good point.
There are a couple more calls to exit that I'm investigating. This is
certainly not the nicest way to handle things...
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Welp, in the last 2 days:
krantz log # grep git-daemon messages | grep 'Connection from' | wc -l
3079
So, I guess git:// will be sticking around, alas.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Hi guys,
When caching is turned on, if we exit(0) early from a cmd, the cache
won't be properly finalized (or even sent), and we get a server error
because of blank output. I just fixed this bug with redirect:
https://git.zx2c4.com/cgit/commit/?id=e9cbdf64632fbe64d6b0c4974ac947ef954938e7
This
For the ricers out there, this might be desirable:
https://git.zx2c4.com/cgit/tree/cgit.conf?h=jd/zx2c4-deployment
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Thanks for posting that thread. I'd forgotten about that. I think my
views there are still solid:
We either use the hack from the manpage (which is what Brad's patch
does), or, so that we don't have to make compatibility infrastructure,
we simply work around this function so that we don't need
On Tue, Feb 23, 2016 at 10:45 AM, John Keeping wrote:
> It's because CGit only supports the dumb HTTP protocol whereas GitHub
> supports the smart protocol. git-http-backend(1) describes how to set
> up a webserver for to support the smart protocol.
>
> [aside: given the
101 - 200 of 431 matches
Mail list logo