Re: [PATCH v4 16/16] md2html: change css name to not conflict with highlight

2018-06-28 Thread John Keeping
On Thu, Jun 28, 2018 at 05:58:42AM +0800, Andy Green wrote: > On 06/28/2018 01:37 AM, Jason A. Donenfeld wrote: > > This seems like an obvious thing to merge, but I'm actually not so > > certain I understand its necessity. md2html uses the highlight class. > > Our css uses the highlight class.

Re: How to format the content of all markdown files, not just the about pages?

2018-12-23 Thread John Keeping
On Sun, Dec 23, 2018 at 03:25:00PM +0100, jean-christophe manciot wrote: > with the following setup, no markdown file is correctly formatted besides > the about pages: > *cgit 1.2.1-14-g55ebd5e* > *git 1:2.20.1-1* > in */etc/cgitrc*: >

Re: How to check error during syntax highlighting

2018-12-24 Thread John Keeping
On Mon, Dec 24, 2018 at 06:37:12PM +0900, Katsuya Horiuchi wrote: > I have been playing with filters, specifically syntax-highlighting.py, > in order to render markdown in tree. > However, I would see empty output when something goes wrong. > > Is it possible to check error during syntax

Re: [PATCH 1/1] RFC: git: update to v2.21.0-rc0

2019-02-07 Thread John Keeping
nce of the version bump? I don't think there's any dependency on Git changes for these. > Signed-off-by: Christian Hesse Even without the strncat changes pulled out, this looks sensible, so: Reviewed-by: John Keeping > --- > Makefile| 4 ++-- > git | 2 +- > ui-

Re: Slash after /about

2019-01-30 Thread John Keeping
On Tue, Jan 29, 2019 at 09:21:01AM +, dilyan.palau...@aegee.org wrote: > For CGI I use thttpd and it tends to remove terminating slashes in the > requests. > > cgit wants to have slash after about/ . > > So they do not work together, endless loop happens. Proposed fix: > > diff --git

Re: [PATCH] ui-shared: restrict to 15 levels

2019-05-20 Thread John Keeping
On Mon, May 20, 2019 at 09:55:06PM +0200, Jason A. Donenfeld wrote: > Perhaps a more ideal version of this would be to not print breadcrumbs > at all for paths that don't exist in the given repo at the given oid. > > Signed-off-by: Jason A. Donenfeld > Reported-by: Fydor Wire Snark > --- > I've

Re: [feature request] Provide Atom feed for tags

2019-08-15 Thread John Keeping
On Tue, Aug 13, 2019 at 06:28:24PM +, Yu Franklin wrote: > Does CGit currently provide Atom feed for tags of a repository? > Something similar to > > https://github.com/git/git/tags.atom > > I know that we have Atom feed for a branch, but not for all tags of a > certain repository. Typically

Re: Nesting repositories under a common folder?

2019-07-24 Thread John Keeping
On Wed, Jul 24, 2019 at 01:01:27PM -0500, Reuben Popp wrote: > Excuse me if this has been answered before, but is there a way to nest > repositories under a common directory visually in cgit? > > For example, > > root_directory (not a repo) > |- Project A (directory, not a repo) > | |-

Re: Nesting repositories under a common folder?

2019-07-24 Thread John Keeping
On Wed, Jul 24, 2019 at 02:05:38PM -0500, Reuben Popp wrote: > Excuse me if I sound a bit daft here... can I add javascript to cgit, or > how else would I collapse reposection classes? You can use the "head-include" directive in cgitrc to include arbitrary content in the element generated by

Re: Opening each logo-link in a separate browser tab

2020-09-10 Thread John Keeping
On Thu, Sep 10, 2020 at 11:36:10AM +0200, jean-christophe manciot wrote: > Is there a special format for that cgitrc keyword to open each > logo-link in a different tab/window? > > It could be for instance something like : > logo-link="url" target="_blank" > > where url is a valid Uniform

Re: Possible case-sensitivity issue in module-link

2020-08-29 Thread John Keeping
insensitively to avoid this problem. This may break a use case where two submodules differ only in case, but that is much less likely than a submodule name using uppercase characters. Signed-off-by: John Keeping --- shared.c | 1 + 1 file changed, 1 insertion(+) diff --git a/shared.c b/share

Re: renamed default branch, no "Idle" value on index at all

2020-08-21 Thread John Keeping
On Thu, Aug 20, 2020 at 01:07:49PM +0200, François Kooman wrote: > I switched the default branch from master to main in some of my > repositories. However, it seems cgit does not consider this when > determining "Idle" on the index page. It shows nothing in the column "Idle". > > The FAQ [1]

Re: cgit 1.2.3: lighttpd 1.4.57, AlpineLinux [edge]: using cache breaks delivery

2020-12-21 Thread John Keeping
On Mon, Dec 21, 2020 at 05:26:19PM +0100, Steffen Nurpmeso wrote: > I discovered today that cgit no longer delivers pages, and it must > have been like that for some time. The server looks show > successful delivery, the cgit cache is populated and rotated just > correctly, but all cgit delivers

Re: [PATCH] Handle tags outside of refs/tags gracefully.

2021-01-05 Thread John Keeping
not under refs/tags/ In log views, we decorate commits with tags under any ref hierarchy, which generates links to ui-tag with, for example, refs/weird/tag. By forcing a refs/tags/ prefix onto this, a 404 not found error is guaranteed. Taking inspiration from Git's ref_rev_parse_rules, let's try to resolve

Re: OpenBSD - Error reading owner-info for : No such file or directory (2)

2021-02-25 Thread John Keeping
On Thu, Feb 25, 2021 at 05:00:57PM +1000, Paul W. Rankin wrote: > I'm running cgit v1.2.3 on OpenBSD 6.8 with httpd and slowcgi. I'm > getting tons of log errors in the form: > Error reading owner-info for : No such file or directory > (2) > > I've found this Stack Overflow question >

Re: User-configurable log graph option

2021-02-19 Thread John Keeping
On Thu, Feb 18, 2021 at 02:31:26PM -0800, Kian Kasad wrote: > I'm using cgit on my website and I'm wondering if it's possible to allow > the user (i.e. the person visiting the site) to choose whether or not > the commit graph is displayed on the log page. > > If this isn't currently possible,

Re: [PATCH 0/2] Support of test results

2021-10-07 Thread John Keeping
On Mon, Oct 04, 2021 at 01:22:34PM +0300, Sergey Bronnikov wrote: > From: Sergey Bronnikov > > Git SCM allows to store information in so called notes [1] and cgit > allows to show notes that placed to default reference > ('refs/notes/commits') and attached to certain commits. It is convenient >

Re: [PATCH] cache: Tolerate short writes in print_slot

2021-10-07 Thread John Keeping
On Fri, Sep 10, 2021 at 05:18:41PM +0300, Hristo Venev wrote: > sendfile() can return after a short read/write, so we may need to call > it more than once. Furthermore, not all files support sendfile(), so we > may need to fall back to read/write. Have you seen these errors in practice, or is

Re: [PATCH] add 'go-import' meta tag if in a repo

2022-01-09 Thread John Keeping
Please include some description here about why this change is desirable. On Sat, Jan 08, 2022 at 04:55:59PM -0700, Derek Stevens wrote: > Signed-off-by: Derek Stevens > --- > ui-shared.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/ui-shared.c b/ui-shared.c > index

[PATCH] blame: add a link to the parent commit

2022-02-13 Thread John Keeping
->s_lno is mostly the right thing, but it is the line number in the post-image of the target commit whereas the link is to the parent of that commit, i.e. the pre-image of the target.) Suggested-by: Alejandro Colomar Signed-off-by: John Keeping --- ui-blame.c | 9 + 1 file changed

[PATCH] treewide: use release_commit_memory()

2022-02-13 Thread John Keeping
will correctly fill out the fields again. release_commit_memory() does not set parents to zero, so keep that for additional safety in case CGit checks this without calling parse_commit() again. Signed-off-by: John Keeping --- ui-atom.c | 3 +-- ui-log.c | 6 ++ ui-stats.c | 3 +-- 3 files

[PATCH] css: blame: reset font size for oid

2022-02-13 Thread John Keeping
of the table back into step. Signed-off-by: John Keeping --- cgit.css | 4 1 file changed, 4 insertions(+) diff --git a/cgit.css b/cgit.css index dfa144d..1b848cf 100644 --- a/cgit.css +++ b/cgit.css @@ -363,6 +363,10 @@ div#cgit table.blame td.lines > div > pre { top: 0; }

Re: [PATCH] Add "default-tab" and "root-default-tab" configuration options

2022-02-13 Thread John Keeping
On Sun, Jan 30, 2022 at 06:04:10PM +, equa wrote: > These options allow the user to specify a page to display at the root > repository/index location instead of the default summary or repository list. > > Signed-off-by: equa We need a real name for the author and sign-off here. > diff

Re: Weird interactions betwen cache and module-link

2022-03-26 Thread John Keeping
On Fri, Mar 25, 2022 at 09:44:48PM +, Gianni Ceccarelli wrote: > This patch seems to fix the problem. Nice catch! This definitely looks like an oversight. Would you like to type up a proper patch with a commit message and Signed-off-by certification? We use the same process as git.git so

Re: git notes for the Linux kernel

2022-10-18 Thread John Keeping
On Mon, Oct 17, 2022 at 01:50:04PM +0200, Vegard Nossum wrote: > I've improved the support for git notes in cgit, including the ability > to load notes from a separate repository than the one you are viewing. > > My use case is using a separate repository of git notes for the Linux > kernel to

Re: Angle brackets - < and >

2022-09-17 Thread John Keeping
On Sat, Sep 17, 2022 at 03:32:48PM +0100, Graham Perrin wrote: > Commit messages > > and > > appear OK. > > In

Re: Downloading objects hangs up around 65kB

2022-09-17 Thread John Keeping
On Fri, Sep 16, 2022 at 10:55:39PM +0300, Valdis Vītoliņš wrote: > Probably it is issue on 64-bit ARM architecture, because I tested that it > works on x86_64 virtual machine. > > Some time ago (because I haven't used HTTPS protocol for repositories > recently) downloading plain objects/blobs

Re: configuring appearance from within repository

2023-01-26 Thread John Keeping
On Thu, Jan 26, 2023 at 06:42:19PM +0100, Spam Receiver wrote: > Hey there, I recently found cgit and I'm very happy about it's > performance, ease of use and overall simplicity. There is only one > thing that I did not manage to set up yet: > > I want to configure repo-specific settings from

Re: Greater use of the HTML title (for tabs and title bars) in cgit

2022-11-06 Thread John Keeping
Hi Graham, On Sun, Nov 06, 2022 at 11:01:25AM +, Graham Perrin wrote: > for 1.0 > included: > > > * Show reverse paths in title bar so that browser tab shows filename. > > Please, are there plans to broaden/refine use of titles?

Re: cgit with busybox httpd

2023-03-06 Thread John Keeping
, 6. März 2023 um 12:41 Uhr schrieb John Keeping : > > > On Mon, Mar 06, 2023 at 11:13:10AM +0100, Andreas Mahling wrote: > > > I'm in the process to configure a cgit instance for my private network > > at home. > > > Because my internet router will be the host for git

Re: cgit with busybox httpd

2023-03-06 Thread John Keeping
On Mon, Mar 06, 2023 at 11:13:10AM +0100, Andreas Mahling wrote: > I'm in the process to configure a cgit instance for my private network at > home. > Because my internet router will be the host for git and cgit, I'm > looking for a ligthweight setup. > I would like to use busybox httpd as

Re: cgit simple-authentication.lua problem

2023-06-15 Thread John Keeping
On Thu, Jun 15, 2023 at 09:40:35AM +0200, Yazar Strulik wrote: > I need some help with getting the simple-authentication.lua running. > > I'm using gitolite as my git base with cgit as my front-end and apache2 as > the webserver. > The main cgit configuration works but it cant interpret the .lua

<    1   2   3   4   5