Re: [PATCH v2] blame: css: make blame highlight div absolute and top left

2018-06-19 Thread John Keeping
On Tue, Jun 19, 2018 at 03:11:52AM +0800, Andy Green wrote: > On June 19, 2018 2:57:47 AM GMT+08:00, John Keeping > wrote: > >On Mon, Jun 18, 2018 at 02:02:54PM +0800, Andy Green wrote: > >> Normal operation of blame view requires div.highlight to > >> have ab

Re: [PATCH v3 08/17] ui-blame: free read_sha1_file() buffer after use

2018-06-19 Thread John Keeping
On Tue, Jun 19, 2018 at 05:02:07PM +0800, Andy Green wrote: > Signed-off-by: Andy Green Pushed to jk/for-jason (after rebasing onto master). > --- > ui-blame.c |5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/ui-blame.c b/ui-blame.c > index 8b56554..37e2c68

Re: [PATCH v3 01/17] manpage: fix sorting order

2018-06-19 Thread John Keeping
On Tue, Jun 19, 2018 at 05:01:31PM +0800, Andy Green wrote: > You maybe didn't know you had OCD until you saw an > alpha sorted list that has stuff out of order in it. > > Signed-off-by: Andy Green Reviewed-by: John Keeping > --- > c

Re: [PATCH v3 05/17] Parse render filters from the config

2018-06-19 Thread John Keeping
On Tue, Jun 19, 2018 at 05:01:51PM +0800, Andy Green wrote: > From: John Keeping > > Render filters will be used to present rendered content in the tree > view, for example to display Markdown source rendered as HTML. > > We will add support for using these from the tree vie

Re: [PATCH v3 12/17] ui-tree: render any matching README file in tree view

2018-06-19 Thread John Keeping
me files rendering them inline. There's only one now, the commit message isn't quite accurate any more! > Signed-off-by: Andy Green > Reviewed-by: John Keeping > --- > ui-tree.c | 53 - > 1 file changed, 52 insertions(+), 1 deleti

Re: [PATCH v3 15/17] ui-shared: deduplicate some code in repolink

2018-06-19 Thread John Keeping
On Tue, Jun 19, 2018 at 05:02:42PM +0800, Andy Green wrote: > 8 lines of code are duplicated in repolink, clean it > so the common code appears once > > Signed-off-by: Andy Green Reviewed-by: John Keeping > --- > ui-shared.c | 26 ++ > 1 file c

Re: [PATCH v3 16/17] ui-shared: add helper for generating non-urlencoded links

2018-06-19 Thread John Keeping
On Tue, Jun 19, 2018 at 05:02:47PM +0800, Andy Green wrote: > We are going to have to produce plain links in the next patch. > But depending on config, the links are not simple. > > Reproduce the logic in repolink() to generate correctly- > formatted links in a strbuf, without urlencoding, in a

Re: [PATCH 1/1] snapshot: strip bit from struct cgit_snapshot_format

2018-06-09 Thread John Keeping
On Sat, Jun 09, 2018 at 12:11:11AM +0200, Christian Hesse wrote: > From: Christian Hesse > > We had a static bit value in struct cgit_snapshot_format. We do not rely > on it and things can be calculated on the fly. So strip it. > > Signed-off-by: Christian Hesse > --- > cgit.c| 3 ++-

Re: [PATCH 1/1] ui-log: highlight annotated tags in different color

2018-06-05 Thread John Keeping
On Tue, Jun 05, 2018 at 12:47:52PM +0200, Christian Hesse wrote: > Signed-off-by: Christian Hesse Can you say a little about why this is desirable as a feature? > --- > cgit.css | 8 > ui-log.c | 7 ++- > 2 files changed, 14 insertions(+), 1 deletion(-) > > diff --git a/cgit.css

Re: [PATCH v2 1/1] ui-log: highlight annotated tags in different color

2018-06-05 Thread John Keeping
wed-by: John Keeping > Signed-off-by: Christian Hesse > --- > cgit.css | 8 > ui-log.c | 6 +- > 2 files changed, 13 insertions(+), 1 deletion(-) > > diff --git a/cgit.css b/cgit.css > index 217a05a..05c4530 100644 > --- a/cgit.css > +++ b/cgit.css > @@ -

Re: [PATCH v4 00/16] Render READMEs inline in tree view

2018-06-27 Thread John Keeping
Hi Jason, On Wed, Jun 27, 2018 at 07:18:57PM +0200, Jason A. Donenfeld wrote: > With the current state of this series, cgit would have the following options: > > - render. > - inline-readme > - render-filter This one is only a concept, not a configuration value (just a note since I couldn't

Re: Fancier Source view [Was: Re: [PATCH v4 00/16] Render READMEs inline in tree view]

2018-06-27 Thread John Keeping
On Wed, Jun 27, 2018 at 07:26:13PM +0200, Jason A. Donenfeld wrote: > Splitting out this issue into a different thread, because I think it's > orthogonal to the other topic. > > On Wed, Jun 27, 2018 at 7:18 PM Jason A. Donenfeld wrote: > > In adding rendering of arbitrary files in blob view,

Re: [PATCH v4 11/16] md2html: add asset mapping

2018-06-27 Thread John Keeping
On Wed, Jun 27, 2018 at 07:32:56PM +0200, Jason A. Donenfeld wrote: > On Wed, Jun 20, 2018 at 12:13 PM Andy Green wrote: > > > md2html > > > The trailing "/" is important. > > Can we make it not important? That is, if the type is always > explicitly a directory, treat it as such using

Re: [PATCH v3 1/1] snapshot: support tar signature for compressed tar

2018-06-27 Thread John Keeping
On Wed, Jun 27, 2018 at 06:34:56PM +0200, Jason A. Donenfeld wrote: > I've merged all the surrounding changes, but I'm not quite satisfied > with the implementation of this one. > > > + for (f_tar = cgit_snapshot_formats; strcmp(f_tar->suffix, ".tar") > > != 0; f_tar++) > > +

Re: [PATCH v2 1/5] config: add js

2018-06-23 Thread John Keeping
On Thu, Jun 21, 2018 at 05:34:49PM +0800, Andy Green wrote: > Just like the config allows setting css URL path, > add a config for setting the js URL path > > Signed-off-by: Andy Green > --- > diff --git a/cgitrc.5.txt b/cgitrc.5.txt > index 99fc799..a692aa5 100644 > --- a/cgitrc.5.txt > +++

Re: [PATCH v2 2/5] cgit.js: introduce

2018-06-23 Thread John Keeping
On Thu, Jun 21, 2018 at 05:34:54PM +0800, Andy Green wrote: > Similar to how cgit.css is handled, we will also provide and > reference a cgit.js for javascript from now on. > > Signed-off-by: Andy Green > --- I think we can merge this and the previous patch, along with the change to output a

Re: [PATCH v2 3/5] ui-shared: introduce line range highlight javascript

2018-06-23 Thread John Keeping
On Thu, Jun 21, 2018 at 05:34:59PM +0800, Andy Green wrote: > This adds a small css class, a clientside js function in > cgit.js, and ajs inline script caller in ui-shared > functions to interpret the # part of the URL > on the client, and apply a highlight to filtered source. > > Unlike blame

Re: [PATCH] noheader: place branch combo on tabs if no header

2018-06-23 Thread John Keeping
s line if noheader=1. It doesn't > change anything if noheader is not set. > > Signed-off-by: Andy Green This makes noheader=1 a lot more usable! I wonder if the branch combo should be somewhere to the right of the main tabs, but I don't feel strongly either way. Reviewed-by:

Re: [PATCH v4 00/16] Render READMEs inline in tree view

2018-06-23 Thread John Keeping
view > md2html: add asset postfix arg > ui-shared: deduplicate some code in repolink > ui-shared: add helper for generating non-urlencoded links > render: adapt for providing extra filter args for plain > md2html: change css name to not conflict with highl

Re: [PATCH 2/2] ui-shared: emit root-desc-html and repo.desc-html after their text counterparts

2018-06-23 Thread John Keeping
On Sat, Jun 23, 2018 at 06:33:38PM +0800, Andy Green wrote: > > > On 06/23/2018 06:28 PM, John Keeping wrote: > > On Thu, Jun 21, 2018 at 02:46:47PM +0800, Andy Green wrote: > >> Where root-desc and repo.desc are used in the header region, also > >> emit t

Re: [PATCH 2/2] ui-shared: emit root-desc-html and repo.desc-html after their text counterparts

2018-06-23 Thread John Keeping
On Thu, Jun 21, 2018 at 02:46:47PM +0800, Andy Green wrote: > Where root-desc and repo.desc are used in the header region, also > emit their html counterparts afterwards if they are defined. > > Where root-desc are repo.desc are used outside the header, > eg in the repo list, leave it as it is

Re: [PATCH 2/2] ui-shared: emit root-desc-html and repo.desc-html after their text counterparts

2018-06-23 Thread John Keeping
On Sat, Jun 23, 2018 at 07:08:08PM +0800, Andy Green wrote: > > > On 06/23/2018 06:53 PM, John Keeping wrote: > > On Sat, Jun 23, 2018 at 06:33:38PM +0800, Andy Green wrote: > >> > >> > >> On 06/23/2018 06:28 PM, John Keeping wrote: > >>>

Re: [PATCH v3 6/6] line-range-highlight: copy URL to clipboard on click

2018-06-24 Thread John Keeping
On Sun, Jun 24, 2018 at 11:06:45PM +0800, Andy Green wrote: > On June 24, 2018 9:39:35 PM GMT+08:00, John Keeping > wrote: > >On Sun, Jun 24, 2018 at 08:00:08PM +0800, Andy Green wrote: > >> On June 24, 2018 7:42:33 PM GMT+08:00, John Keeping > > wrote: > >>

Re: cache-size implementation downsides

2018-06-20 Thread John Keeping
On Wed, Jun 20, 2018 at 08:01:11AM +0200, Christian Hesse wrote: > John Keeping on Sat, 2018/06/16 16:46: > > -- >8 -- > > Subject: [PATCH] cache: close race window when unlocking slots > > You should add a "From:" line for easy git-am. ;) "git am --sci

Re: md2html is inoperative

2018-06-30 Thread John Keeping
On Thu, Jun 28, 2018 at 12:50:49PM +0200, jean-christophe manciot wrote: > On Ubuntu 18.10 cosmic > cgit 1.1+git2.10.2-3build1 > python3: 3.6.5-3 > python3-docutils: 0.14+dfsg-3 > python3-markdown: 2.6.9-1 > python3-pygments: 2.2.0+dfsg-1 > > In /etc/cgitrc: >

Re: [PATCH 0/3] Add support for git's mailmap.

2017-10-28 Thread John Keeping
On Tue, Oct 24, 2017 at 10:55:21AM -0400, Jason A. Smith wrote: > Seeing a lot of recent activity I checked the upstream and see that the > patch I first submitted over a year ago has still not been merged. I > already had to rebase it once several months ago to fix conflicts, I > don't want to

Re: [PATCH] extra-head-content: introduce another option for meta tags

2018-02-17 Thread John Keeping
On Mon, Feb 12, 2018 at 11:34:53PM +0100, Jason A. Donenfeld wrote: > This is to support things like go-import meta tags, which are on a > per-repo basis. > > Signed-off-by: Jason A. Donenfeld > --- > This is kind of really ugly, and I'm not keen on its approach, but I > thought

Re: [PATCH v2 14/15] md2html-add-asset-postfix-arg

2018-06-19 Thread John Keeping
On Tue, Jun 19, 2018 at 11:55:35AM +0800, Andy Green wrote: > > > On 06/19/2018 03:21 AM, John Keeping wrote: > > On Mon, Jun 18, 2018 at 10:58:26AM +0800, Andy Green wrote: > > >> class AssetMappingExtension(markdown.extensions.Extension): > >> &g

Re: How to apply about-formatting.sh to appropriate tree files

2018-08-11 Thread John Keeping
On Sat, Aug 11, 2018 at 01:51:09PM +0200, jean-christophe manciot wrote: > I could not find a way with v1.2.1 to get any markdown/html files formatted > correctly when read from the tree. > I already successfully use the > "about-filter=/usr/local/lib/cgit/filters/about-formatting.sh" setting in >

Re: git-fsck complains about cgit repo

2018-08-15 Thread John Keeping
On Wed, Aug 15, 2018 at 09:32:18AM -0400, Konstantin Ryabitsev wrote: > Since cgit is mirrored to git.kernel.org, which gets routine fsck > treatment, I started getting the following error reports: > > error: bad config line 5 in blob .gitmodules > error in blob

Re: [PATCH 1/1] RFC: git: update to v2.19.0-rc0

2018-08-21 Thread John Keeping
On Tue, Aug 21, 2018 at 09:21:14AM +0200, Christian Hesse wrote: > From: Christian Hesse > > Changelog to be writting... :) More comments below, but it looks like there's a lot of unrelated cleanups here. I think only the the_repository parameter addition is required for Git 2.19. The other

Re: [PATCH 1/1] filters: generate anchor links from markdown

2018-08-25 Thread John Keeping
On Fri, Jul 13, 2018 at 09:48:27PM +0200, Christian Hesse wrote: > From: Christian Hesse > > This makes the markdown filter generate anchor links for headings. > > Signed-off-by: Christian Hesse > --- > filters/html-converters/md2html | 17 +++-- > 1 file changed, 15

Re: The logo of the about page is never shown although it is displayed on all other pages

2018-08-25 Thread John Keeping
On Sat, Aug 25, 2018 at 09:41:44AM +0200, jean-christophe manciot wrote: > I use *v1.2.1* with the patch regarding the table of contents > > . > I have the following setup:

Re: The logo of the about page is never shown although it is displayed on all other pages

2018-08-25 Thread John Keeping
cache issue somewhere, whether that's CGit or your browser or somewhere in between. If the cache TTL was originally longer, then that will have been included in the HTTP Expires header on earlier results so it's possible that the older response was still cached based on the previous TTL. > On S

Re: [PATCH 1/1] filters: generate anchor links from markdown

2018-08-25 Thread John Keeping
On Sat, Aug 25, 2018 at 11:11:39AM -0600, Jason A. Donenfeld wrote: > The effect is just anchor links, but it doesn't add an actual ToC, right? >From the docs [0], it looks like it will add an actual ToC if you have a placeholder in the document to request one. But if you don't have that, then

Re: [PATCH 1/1] css: Change #git font-size to 13px

2018-08-26 Thread John Keeping
On Sun, Aug 26, 2018 at 02:59:36PM +0200, Petr Vorel wrote: > Previous size font-size 10pt (which is 13.px) hide underscore, > when used with highlight with background-color on modified lines. > Here underscore of crypto_blkcipher is hidden on by background color of > newly added line. > >

Re: [PATCH] Record repo.snapshot-prefix in the per-repo config

2018-07-17 Thread John Keeping
On Tue, Jul 17, 2018 at 12:38:22PM -0400, Konstantin Ryabitsev wrote: > Even if we find snapshot-prefix in the repo configuration, we are not > writing it out into the rc- file, so setting the value does not have any > effect. > > Signed-off-by: Konstantin Ryabitsev Reviewed-b

Re: RFE: changelog between two revisions

2018-07-24 Thread John Keeping
On Tue, Jul 24, 2018 at 03:14:49PM -0400, Konstantin Ryabitsev wrote: > A very minor feature request -- it would be nice if there was a way to > limit /log/ view to only changes between two revisions. In other words, > I was looking for a way to replicate this file: > >

Re: [PATCH v4 00/16] Render READMEs inline in tree view

2018-07-03 Thread John Keeping
On Tue, Jul 03, 2018 at 09:34:26PM +0200, Jason A. Donenfeld wrote: > On Thu, Jun 28, 2018 at 10:29 AM John Keeping wrote: > > Yeah, I don't think there's any way to avoid exec'ing twice in source > > view - we need to run the source filter for output and we need the > > ren

Re: NGINX and linux

2018-03-01 Thread John Keeping
On Wed, Feb 28, 2018 at 08:37:17PM -0500, Rolan Pichler wrote: > The README is for APACHE and unix systems. Would there be a way to get this > working with nginx and on linux Nginx doesn't support CGI directly, so you need to use fcgiwrap or an equivalent as a wrapper to run CGit. I found this

Re: About or readme formatting for subfolders

2018-03-30 Thread John Keeping
On Tue, Mar 20, 2018 at 07:40:33PM +0300, Alex Ivanov wrote: > Currently about tab is only for readme file in root folder. Is it > possible to show it for subfolders with readme files also? Or other > way show say readme.mkd (markdown) preformatted in file preview > (unless one clicks plain) You

Re: RFC: snapshot tarball information in refs/notes/snapshots

2018-03-30 Thread John Keeping
On Wed, Mar 21, 2018 at 10:03:11AM -0400, Konstantin Ryabitsev wrote: > It would be easy to load and parse refs/notes/cgitrc, and the security > implications shouldn't be much different than loading the same from > gitconfig. Based on this comment, I had a go at just wiring up config parsing to

Re: RFC: snapshot tarball information in refs/notes/snapshots

2018-03-30 Thread John Keeping
On Fri, Mar 30, 2018 at 11:38:38AM -0400, Konstantin Ryabitsev wrote: > On Fri, Mar 30, 2018 at 12:53:57PM +0100, John Keeping wrote: > > Unfortunately there is one big gotcha I encountered doing this, which is > > that we don't have the repository set up when

[PATCH 2/2] Add "snapshot-prefix" repo configuration

2018-03-31 Thread John Keeping
=linux Signed-off-by: John Keeping <j...@keeping.me.uk> --- cgit.c | 2 ++ cgit.h | 1 + cgitrc.5.txt | 7 +++ ui-refs.c| 2 +- ui-shared.c | 10 +- ui-shared.h | 1 + 6 files changed, 21 insertions(+), 2 deletions(-) diff --git a/cgit.c b/cgit.c index b

[PATCH 0/2] Custom snapshot prefix

2018-03-31 Thread John Keeping
missed something here! John Keeping (2): ui-shared: pass repo object to print_snapshot_links() Add "snapshot-prefix" repo configuration cgit.c | 2 ++ cgit.h | 1 + cgitrc.5.txt | 7 +++ ui-commit.c | 3 +-- ui-refs.c| 2 +- ui-shared.c | 16 ++

[PATCH 1/2] ui-shared: pass repo object to print_snapshot_links()

2018-03-31 Thread John Keeping
Both call sites of cgit_print_snapshot_links() use the same values for the snapshot mask and repository name, which are derived from the cgit_repo structure so let's pass in the structure and access the fields directly. Signed-off-by: John Keeping <j...@keeping.me.uk> --- ui-commit.c | 3 +

[PATCH v2 3/3] Add "snapshot-prefix" repo configuration

2018-03-31 Thread John Keeping
=linux Signed-off-by: John Keeping <j...@keeping.me.uk> --- v2: - also update request handling in ui-snapshot.c cgit.c| 2 ++ cgit.h| 1 + cgitrc.5.txt | 7 +++ ui-refs.c | 2 +- ui-shared.c | 10 +- ui-shared.h | 1 + ui-snapshot.c | 4 ++-- 7

[PATCH v2 1/3] ui-shared: pass repo object to print_snapshot_links()

2018-03-31 Thread John Keeping
Both call sites of cgit_print_snapshot_links() use the same values for the snapshot mask and repository name, which are derived from the cgit_repo structure so let's pass in the structure and access the fields directly. Signed-off-by: John Keeping <j...@keeping.me.uk> --- v2: unchange

[PATCH v2 0/3] Custom snapshot prefix

2018-03-31 Thread John Keeping
It turns out I should have tested whether downloads with a custom prefix actually work... they didn't! v2 adds a new refactoring patch in the middle and ensures that we update the request handling logic in the final patch. John Keeping (3): ui-shared: pass repo object to print_snapshot_links

[PATCH v2 2/3] ui-snapshot: pass repo into get_ref_from_filename()

2018-03-31 Thread John Keeping
Prepare to allow a custom snapshot prefix. Signed-off-by: John Keeping <j...@keeping.me.uk> --- v2: new patch ui-snapshot.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ui-snapshot.c b/ui-snapshot.c index b2d95f7..237a75f 100644 --- a/ui-snapshot.c ++

[RFC/PATCH 0/7] Snapshot signatures

2018-03-31 Thread John Keeping
builds on my "Custom snapshot prefix" series [1]. The final patch is the one that I expect feedback on; there's definitely a lack of documentation but there's no point in writing that if this approach is vetoed. [1] https://lists.zx2c4.com/pipermail/cgit/2018-March/003767.html John Keeping

[RFC/PATCH 1/7] ui-refs: remove unnecessary sanity check

2018-03-31 Thread John Keeping
There is no way for refinfo::refname to be null, and Git will prevent zero-length refs so this check is unnecessary. Signed-off-by: John Keeping <j...@keeping.me.uk> --- ui-refs.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/ui-refs.c b/ui-refs.c index 50d9d30..7b95e8b 100644 --

[RFC/PATCH 6/7] ui-refs: use shared function to print tag downloads

2018-03-31 Thread John Keeping
cgit_compose_snapshot_prefix() is identical to print_tag_downloads(), so remove the latter and use the function from ui-shared.c instead. Signed-off-by: John Keeping <j...@keeping.me.uk> --- ui-refs.c | 27 +-- 1 file changed, 1 insertion(+), 26 deletions(-) diff

[RFC/PATCH 3/7] ui-shared: rename parameter to cgit_print_snapshot_links()

2018-03-31 Thread John Keeping
This is expected to be a ref not a hex object ID, so name it more appropriately. Signed-off-by: John Keeping <j...@keeping.me.uk> --- ui-shared.c | 4 ++-- ui-shared.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ui-shared.c b/ui-shared.c index 47b8dc9..0375006

[RFC/PATCH 2/7] ui-shared: remove unused parameter

2018-03-31 Thread John Keeping
The "head" parameter to cgit_print_snapshot_links() is never used, so remove it. Signed-off-by: John Keeping <j...@keeping.me.uk> --- ui-commit.c | 2 +- ui-shared.c | 3 +-- ui-shared.h | 2 +- ui-tag.c| 2 +- 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/

[RFC/PATCH 4/7] ui-shared: use the same snapshot logic as ui-refs

2018-03-31 Thread John Keeping
Make snapshot links in the commit UI use the same prefix algorithm as those in the summary UI, so that refs starting with the snapshot prefix are used as-is rather than composed with the prefix repeated. Signed-off-by: John Keeping <j...@keeping.me.uk> --- ui-shared.c | 8 +++-

[PATCH] ui-snapshot: filter permitted snapshot requests

2018-03-31 Thread John Keeping
Currently the snapshots configuration option only filters which links are displayed, not which snapshots may be generated and downloaded. Apply the filter to requests as well to ensure that the system policy is enforced. Signed-off-by: John Keeping <j...@keeping.me.uk> --- ui-snapshot

[RFC/PATCH 5/7] ui-shared: pass separator in to cgit_print_snapshot_links()

2018-03-31 Thread John Keeping
cgit_print_snapshot_links() is almost identical to print_tag_downloads(), so let's extract the difference to a parameter in preparation for removing print_tag_downloads() in the next commit. Signed-off-by: John Keeping <j...@keeping.me.uk> --- ui-commit.c | 2 +- ui-shared.c | 5 +++

[RFC/PATCH 7/7] snapshot: support archive signatures

2018-03-31 Thread John Keeping
y simply appending ".asc" to the archive URL. Signed-off-by: John Keeping <j...@keeping.me.uk> --- cgit.h| 2 ++ ui-shared.c | 7 ++ ui-snapshot.c | 76 ++- 3 files changed, 84 insertions(+), 1 deletion(-) di

Re: Default view

2018-03-19 Thread John Keeping
On Mon, Mar 19, 2018 at 10:01:58PM +0300, Alex Ivanov wrote: > How to set a default view? When I open repo link a summary view is > opened by default, but I want to have tree view as default. You'll have to patch CGit if you want to do that, out of the box you can set enable-index-links=1 in your

Re: [PATCH v3 1/6] config: add js

2018-06-24 Thread John Keeping
ed-off-by: Andy Green For the code changes, Reviewed-by: John Keeping One comment on the documentation below... > --- > diff --git a/cgitrc.5.txt b/cgitrc.5.txt > index 99fc799..bdd799f 100644 > --- a/cgitrc.5.txt > +++ b/cgitrc.5.txt > @@ -248,6 +248,12 @@ inline-readme:: >

Re: [PATCH v3 2/6] ui-shared: line range highlight: introduce javascript

2018-06-24 Thread John Keeping
The subject is "ui-shared: ..." but should be "cgit.js" now I think. On Sun, Jun 24, 2018 at 10:44:34AM +0800, Andy Green wrote: > diff --git a/cgit.js b/cgit.js > index e69de29..501c98f 100644 > --- a/cgit.js > +++ b/cgit.js > @@ -0,0 +1,53 @@ > +function cgit_line_range_highlight() > +{ > +

Re: [PATCH v3 5/6] line-range-highlight: onclick handler and range selection

2018-06-24 Thread John Keeping
On Sun, Jun 24, 2018 at 10:44:49AM +0800, Andy Green wrote: > This allows the user to select line ranges simply by clicking on the > line number links. > > - No selected highlit line, or a range already selected, causes the > click to highlight just the clicked line as usual. > > - Clicking on

Re: [PATCH v3 6/6] line-range-highlight: copy URL to clipboard on click

2018-06-24 Thread John Keeping
On Sun, Jun 24, 2018 at 10:44:54AM +0800, Andy Green wrote: > Since the only reason to click on the line number links > is to get the corresponding #URL to share, this patch > makes that process more convenient by copying the > highlit area, be it a single line or a range, to the > clipboard on

Re: [PATCH] cgit.css: add dynamic age update

2018-06-24 Thread John Keeping
Subject should be "cgit.js: " not cgit.css! On Sun, Jun 24, 2018 at 03:59:51PM +0800, Andy Green wrote: > This patch updates the emitted "ages" dynamically on the client side. > > After updating on completion of the document load, it sets a timer > to update according to the smallest age it

Re: [PATCH v3 6/6] line-range-highlight: copy URL to clipboard on click

2018-06-24 Thread John Keeping
On Sun, Jun 24, 2018 at 08:00:08PM +0800, Andy Green wrote: > > > On June 24, 2018 7:42:33 PM GMT+08:00, John Keeping > wrote: > >On Sun, Jun 24, 2018 at 10:44:54AM +0800, Andy Green wrote: > >> Since the only reason to click on the line number links > >&

Re: [PATCH v4 00/16] Render READMEs inline in tree view

2018-06-28 Thread John Keeping
On Thu, Jun 28, 2018 at 01:22:34AM +0200, Jason A. Donenfeld wrote: > Hey John, > > Thanks tons for your input, as always. > > On Wed, Jun 27, 2018 at 9:51 PM John Keeping wrote: > > - It is desirable to have the existing source view in addition to the > > r

Re: [PATCH v4 16/16] md2html: change css name to not conflict with highlight

2018-06-28 Thread John Keeping
On Thu, Jun 28, 2018 at 05:58:42AM +0800, Andy Green wrote: > On 06/28/2018 01:37 AM, Jason A. Donenfeld wrote: > > This seems like an obvious thing to merge, but I'm actually not so > > certain I understand its necessity. md2html uses the highlight class. > > Our css uses the highlight class.

Re: How to format the content of all markdown files, not just the about pages?

2018-12-23 Thread John Keeping
On Sun, Dec 23, 2018 at 03:25:00PM +0100, jean-christophe manciot wrote: > with the following setup, no markdown file is correctly formatted besides > the about pages: > *cgit 1.2.1-14-g55ebd5e* > *git 1:2.20.1-1* > in */etc/cgitrc*: >

Re: How to check error during syntax highlighting

2018-12-24 Thread John Keeping
On Mon, Dec 24, 2018 at 06:37:12PM +0900, Katsuya Horiuchi wrote: > I have been playing with filters, specifically syntax-highlighting.py, > in order to render markdown in tree. > However, I would see empty output when something goes wrong. > > Is it possible to check error during syntax

Re: [PATCH 1/1] RFC: git: update to v2.21.0-rc0

2019-02-07 Thread John Keeping
nce of the version bump? I don't think there's any dependency on Git changes for these. > Signed-off-by: Christian Hesse Even without the strncat changes pulled out, this looks sensible, so: Reviewed-by: John Keeping > --- > Makefile| 4 ++-- > git | 2 +- > ui-

Re: Slash after /about

2019-01-30 Thread John Keeping
On Tue, Jan 29, 2019 at 09:21:01AM +, dilyan.palau...@aegee.org wrote: > For CGI I use thttpd and it tends to remove terminating slashes in the > requests. > > cgit wants to have slash after about/ . > > So they do not work together, endless loop happens. Proposed fix: > > diff --git

Re: [PATCH] ui-shared: restrict to 15 levels

2019-05-20 Thread John Keeping
On Mon, May 20, 2019 at 09:55:06PM +0200, Jason A. Donenfeld wrote: > Perhaps a more ideal version of this would be to not print breadcrumbs > at all for paths that don't exist in the given repo at the given oid. > > Signed-off-by: Jason A. Donenfeld > Reported-by: Fydor Wire Snark > --- > I've

Re: [feature request] Provide Atom feed for tags

2019-08-15 Thread John Keeping
On Tue, Aug 13, 2019 at 06:28:24PM +, Yu Franklin wrote: > Does CGit currently provide Atom feed for tags of a repository? > Something similar to > > https://github.com/git/git/tags.atom > > I know that we have Atom feed for a branch, but not for all tags of a > certain repository. Typically

Re: [PATCH] Make default pages configurable

2019-08-15 Thread John Keeping
On Tue, Aug 13, 2019 at 07:22:21PM +0200, Naaam Favier wrote: > This adds two configuration options, "default-page" and > "default-page-repo", allowing to change the default page for > the whole site and repositories, respectively. > A few changes were required to make this work, namely: > - the

Re: Nesting repositories under a common folder?

2019-07-24 Thread John Keeping
On Wed, Jul 24, 2019 at 01:01:27PM -0500, Reuben Popp wrote: > Excuse me if this has been answered before, but is there a way to nest > repositories under a common directory visually in cgit? > > For example, > > root_directory (not a repo) > |- Project A (directory, not a repo) > | |-

Re: Nesting repositories under a common folder?

2019-07-24 Thread John Keeping
On Wed, Jul 24, 2019 at 02:05:38PM -0500, Reuben Popp wrote: > Excuse me if I sound a bit daft here... can I add javascript to cgit, or > how else would I collapse reposection classes? You can use the "head-include" directive in cgitrc to include arbitrary content in the element generated by

<    1   2   3   4   5