Re: [feature request] Provide Atom feed for tags

2019-08-15 Thread John Keeping
On Tue, Aug 13, 2019 at 06:28:24PM +, Yu Franklin wrote: > Does CGit currently provide Atom feed for tags of a repository? > Something similar to > > https://github.com/git/git/tags.atom > > I know that we have Atom feed for a branch, but not for all tags of a > certain repository. Typically

Re: [PATCH] Make default pages configurable

2019-08-15 Thread John Keeping
On Tue, Aug 13, 2019 at 07:22:21PM +0200, Naaam Favier wrote: > This adds two configuration options, "default-page" and > "default-page-repo", allowing to change the default page for > the whole site and repositories, respectively. > A few changes were required to make this work, namely: > - the

Re: Nesting repositories under a common folder?

2019-07-24 Thread John Keeping
On Wed, Jul 24, 2019 at 02:05:38PM -0500, Reuben Popp wrote: > Excuse me if I sound a bit daft here... can I add javascript to cgit, or > how else would I collapse reposection classes? You can use the "head-include" directive in cgitrc to include arbitrary content in the element generated by

Re: Nesting repositories under a common folder?

2019-07-24 Thread John Keeping
On Wed, Jul 24, 2019 at 01:01:27PM -0500, Reuben Popp wrote: > Excuse me if this has been answered before, but is there a way to nest > repositories under a common directory visually in cgit? > > For example, > > root_directory (not a repo) > |- Project A (directory, not a repo) > | |-

Re: [PATCH] ui-shared: restrict to 15 levels

2019-05-20 Thread John Keeping
On Mon, May 20, 2019 at 09:55:06PM +0200, Jason A. Donenfeld wrote: > Perhaps a more ideal version of this would be to not print breadcrumbs > at all for paths that don't exist in the given repo at the given oid. > > Signed-off-by: Jason A. Donenfeld > Reported-by: Fydor Wire Snark > --- > I've

Re: [PATCH 1/1] RFC: git: update to v2.21.0-rc0

2019-02-07 Thread John Keeping
nce of the version bump? I don't think there's any dependency on Git changes for these. > Signed-off-by: Christian Hesse Even without the strncat changes pulled out, this looks sensible, so: Reviewed-by: John Keeping > --- > Makefile| 4 ++-- > git | 2 +- > ui-

Re: Slash after /about

2019-01-30 Thread John Keeping
On Tue, Jan 29, 2019 at 09:21:01AM +, dilyan.palau...@aegee.org wrote: > For CGI I use thttpd and it tends to remove terminating slashes in the > requests. > > cgit wants to have slash after about/ . > > So they do not work together, endless loop happens. Proposed fix: > > diff --git

Re: How to check error during syntax highlighting

2018-12-24 Thread John Keeping
On Mon, Dec 24, 2018 at 06:37:12PM +0900, Katsuya Horiuchi wrote: > I have been playing with filters, specifically syntax-highlighting.py, > in order to render markdown in tree. > However, I would see empty output when something goes wrong. > > Is it possible to check error during syntax

Re: How to format the content of all markdown files, not just the about pages?

2018-12-23 Thread John Keeping
On Sun, Dec 23, 2018 at 03:25:00PM +0100, jean-christophe manciot wrote: > with the following setup, no markdown file is correctly formatted besides > the about pages: > *cgit 1.2.1-14-g55ebd5e* > *git 1:2.20.1-1* > in */etc/cgitrc*: >

Re: [PATCH 1/1] css: Change #git font-size to 13px

2018-08-26 Thread John Keeping
On Sun, Aug 26, 2018 at 02:59:36PM +0200, Petr Vorel wrote: > Previous size font-size 10pt (which is 13.px) hide underscore, > when used with highlight with background-color on modified lines. > Here underscore of crypto_blkcipher is hidden on by background color of > newly added line. > >

Re: [PATCH 1/1] filters: generate anchor links from markdown

2018-08-25 Thread John Keeping
On Sat, Aug 25, 2018 at 11:11:39AM -0600, Jason A. Donenfeld wrote: > The effect is just anchor links, but it doesn't add an actual ToC, right? >From the docs [0], it looks like it will add an actual ToC if you have a placeholder in the document to request one. But if you don't have that, then

Re: The logo of the about page is never shown although it is displayed on all other pages

2018-08-25 Thread John Keeping
cache issue somewhere, whether that's CGit or your browser or somewhere in between. If the cache TTL was originally longer, then that will have been included in the HTTP Expires header on earlier results so it's possible that the older response was still cached based on the previous TTL. > On S

Re: The logo of the about page is never shown although it is displayed on all other pages

2018-08-25 Thread John Keeping
On Sat, Aug 25, 2018 at 09:41:44AM +0200, jean-christophe manciot wrote: > I use *v1.2.1* with the patch regarding the table of contents > > . > I have the following setup:

Re: [PATCH 1/1] filters: generate anchor links from markdown

2018-08-25 Thread John Keeping
On Fri, Jul 13, 2018 at 09:48:27PM +0200, Christian Hesse wrote: > From: Christian Hesse > > This makes the markdown filter generate anchor links for headings. > > Signed-off-by: Christian Hesse > --- > filters/html-converters/md2html | 17 +++-- > 1 file changed, 15

Re: [PATCH 1/1] RFC: git: update to v2.19.0-rc0

2018-08-21 Thread John Keeping
On Tue, Aug 21, 2018 at 09:21:14AM +0200, Christian Hesse wrote: > From: Christian Hesse > > Changelog to be writting... :) More comments below, but it looks like there's a lot of unrelated cleanups here. I think only the the_repository parameter addition is required for Git 2.19. The other

Re: git-fsck complains about cgit repo

2018-08-15 Thread John Keeping
On Wed, Aug 15, 2018 at 09:32:18AM -0400, Konstantin Ryabitsev wrote: > Since cgit is mirrored to git.kernel.org, which gets routine fsck > treatment, I started getting the following error reports: > > error: bad config line 5 in blob .gitmodules > error in blob

Re: How to apply about-formatting.sh to appropriate tree files

2018-08-11 Thread John Keeping
On Sat, Aug 11, 2018 at 01:51:09PM +0200, jean-christophe manciot wrote: > I could not find a way with v1.2.1 to get any markdown/html files formatted > correctly when read from the tree. > I already successfully use the > "about-filter=/usr/local/lib/cgit/filters/about-formatting.sh" setting in >

Re: RFE: changelog between two revisions

2018-07-24 Thread John Keeping
On Tue, Jul 24, 2018 at 03:14:49PM -0400, Konstantin Ryabitsev wrote: > A very minor feature request -- it would be nice if there was a way to > limit /log/ view to only changes between two revisions. In other words, > I was looking for a way to replicate this file: > >

Re: [PATCH] Record repo.snapshot-prefix in the per-repo config

2018-07-17 Thread John Keeping
On Tue, Jul 17, 2018 at 12:38:22PM -0400, Konstantin Ryabitsev wrote: > Even if we find snapshot-prefix in the repo configuration, we are not > writing it out into the rc- file, so setting the value does not have any > effect. > > Signed-off-by: Konstantin Ryabitsev Reviewed-b

Re: [PATCH v4 00/16] Render READMEs inline in tree view

2018-07-03 Thread John Keeping
On Tue, Jul 03, 2018 at 09:34:26PM +0200, Jason A. Donenfeld wrote: > On Thu, Jun 28, 2018 at 10:29 AM John Keeping wrote: > > Yeah, I don't think there's any way to avoid exec'ing twice in source > > view - we need to run the source filter for output and we need the > > ren

Re: md2html is inoperative

2018-06-30 Thread John Keeping
On Thu, Jun 28, 2018 at 12:50:49PM +0200, jean-christophe manciot wrote: > On Ubuntu 18.10 cosmic > cgit 1.1+git2.10.2-3build1 > python3: 3.6.5-3 > python3-docutils: 0.14+dfsg-3 > python3-markdown: 2.6.9-1 > python3-pygments: 2.2.0+dfsg-1 > > In /etc/cgitrc: >

Re: [PATCH v4 16/16] md2html: change css name to not conflict with highlight

2018-06-28 Thread John Keeping
On Thu, Jun 28, 2018 at 05:58:42AM +0800, Andy Green wrote: > On 06/28/2018 01:37 AM, Jason A. Donenfeld wrote: > > This seems like an obvious thing to merge, but I'm actually not so > > certain I understand its necessity. md2html uses the highlight class. > > Our css uses the highlight class.

Re: [PATCH v4 00/16] Render READMEs inline in tree view

2018-06-28 Thread John Keeping
On Thu, Jun 28, 2018 at 01:22:34AM +0200, Jason A. Donenfeld wrote: > Hey John, > > Thanks tons for your input, as always. > > On Wed, Jun 27, 2018 at 9:51 PM John Keeping wrote: > > - It is desirable to have the existing source view in addition to the > > r

Re: [PATCH v3 1/1] snapshot: support tar signature for compressed tar

2018-06-27 Thread John Keeping
On Wed, Jun 27, 2018 at 06:34:56PM +0200, Jason A. Donenfeld wrote: > I've merged all the surrounding changes, but I'm not quite satisfied > with the implementation of this one. > > > + for (f_tar = cgit_snapshot_formats; strcmp(f_tar->suffix, ".tar") > > != 0; f_tar++) > > +

Re: Fancier Source view [Was: Re: [PATCH v4 00/16] Render READMEs inline in tree view]

2018-06-27 Thread John Keeping
On Wed, Jun 27, 2018 at 07:26:13PM +0200, Jason A. Donenfeld wrote: > Splitting out this issue into a different thread, because I think it's > orthogonal to the other topic. > > On Wed, Jun 27, 2018 at 7:18 PM Jason A. Donenfeld wrote: > > In adding rendering of arbitrary files in blob view,

Re: [PATCH v4 11/16] md2html: add asset mapping

2018-06-27 Thread John Keeping
On Wed, Jun 27, 2018 at 07:32:56PM +0200, Jason A. Donenfeld wrote: > On Wed, Jun 20, 2018 at 12:13 PM Andy Green wrote: > > > md2html > > > The trailing "/" is important. > > Can we make it not important? That is, if the type is always > explicitly a directory, treat it as such using

Re: [PATCH v4 00/16] Render READMEs inline in tree view

2018-06-27 Thread John Keeping
Hi Jason, On Wed, Jun 27, 2018 at 07:18:57PM +0200, Jason A. Donenfeld wrote: > With the current state of this series, cgit would have the following options: > > - render. > - inline-readme > - render-filter This one is only a concept, not a configuration value (just a note since I couldn't

Re: [PATCH v3 6/6] line-range-highlight: copy URL to clipboard on click

2018-06-24 Thread John Keeping
On Sun, Jun 24, 2018 at 11:06:45PM +0800, Andy Green wrote: > On June 24, 2018 9:39:35 PM GMT+08:00, John Keeping > wrote: > >On Sun, Jun 24, 2018 at 08:00:08PM +0800, Andy Green wrote: > >> On June 24, 2018 7:42:33 PM GMT+08:00, John Keeping > > wrote: > >>

Re: [PATCH v3 6/6] line-range-highlight: copy URL to clipboard on click

2018-06-24 Thread John Keeping
On Sun, Jun 24, 2018 at 08:00:08PM +0800, Andy Green wrote: > > > On June 24, 2018 7:42:33 PM GMT+08:00, John Keeping > wrote: > >On Sun, Jun 24, 2018 at 10:44:54AM +0800, Andy Green wrote: > >> Since the only reason to click on the line number links > >&

Re: [PATCH] cgit.css: add dynamic age update

2018-06-24 Thread John Keeping
Subject should be "cgit.js: " not cgit.css! On Sun, Jun 24, 2018 at 03:59:51PM +0800, Andy Green wrote: > This patch updates the emitted "ages" dynamically on the client side. > > After updating on completion of the document load, it sets a timer > to update according to the smallest age it

Re: [PATCH v3 6/6] line-range-highlight: copy URL to clipboard on click

2018-06-24 Thread John Keeping
On Sun, Jun 24, 2018 at 10:44:54AM +0800, Andy Green wrote: > Since the only reason to click on the line number links > is to get the corresponding #URL to share, this patch > makes that process more convenient by copying the > highlit area, be it a single line or a range, to the > clipboard on

Re: [PATCH v3 5/6] line-range-highlight: onclick handler and range selection

2018-06-24 Thread John Keeping
On Sun, Jun 24, 2018 at 10:44:49AM +0800, Andy Green wrote: > This allows the user to select line ranges simply by clicking on the > line number links. > > - No selected highlit line, or a range already selected, causes the > click to highlight just the clicked line as usual. > > - Clicking on

Re: [PATCH v3 2/6] ui-shared: line range highlight: introduce javascript

2018-06-24 Thread John Keeping
The subject is "ui-shared: ..." but should be "cgit.js" now I think. On Sun, Jun 24, 2018 at 10:44:34AM +0800, Andy Green wrote: > diff --git a/cgit.js b/cgit.js > index e69de29..501c98f 100644 > --- a/cgit.js > +++ b/cgit.js > @@ -0,0 +1,53 @@ > +function cgit_line_range_highlight() > +{ > +

Re: [PATCH v3 1/6] config: add js

2018-06-24 Thread John Keeping
ed-off-by: Andy Green For the code changes, Reviewed-by: John Keeping One comment on the documentation below... > --- > diff --git a/cgitrc.5.txt b/cgitrc.5.txt > index 99fc799..bdd799f 100644 > --- a/cgitrc.5.txt > +++ b/cgitrc.5.txt > @@ -248,6 +248,12 @@ inline-readme:: >

Re: [PATCH 2/2] ui-shared: emit root-desc-html and repo.desc-html after their text counterparts

2018-06-23 Thread John Keeping
On Sat, Jun 23, 2018 at 07:08:08PM +0800, Andy Green wrote: > > > On 06/23/2018 06:53 PM, John Keeping wrote: > > On Sat, Jun 23, 2018 at 06:33:38PM +0800, Andy Green wrote: > >> > >> > >> On 06/23/2018 06:28 PM, John Keeping wrote: > >>>

Re: [PATCH v4 00/16] Render READMEs inline in tree view

2018-06-23 Thread John Keeping
view > md2html: add asset postfix arg > ui-shared: deduplicate some code in repolink > ui-shared: add helper for generating non-urlencoded links > render: adapt for providing extra filter args for plain > md2html: change css name to not conflict with highl

Re: [PATCH 2/2] ui-shared: emit root-desc-html and repo.desc-html after their text counterparts

2018-06-23 Thread John Keeping
On Sat, Jun 23, 2018 at 06:33:38PM +0800, Andy Green wrote: > > > On 06/23/2018 06:28 PM, John Keeping wrote: > > On Thu, Jun 21, 2018 at 02:46:47PM +0800, Andy Green wrote: > >> Where root-desc and repo.desc are used in the header region, also > >> emit t

Re: [PATCH] noheader: place branch combo on tabs if no header

2018-06-23 Thread John Keeping
s line if noheader=1. It doesn't > change anything if noheader is not set. > > Signed-off-by: Andy Green This makes noheader=1 a lot more usable! I wonder if the branch combo should be somewhere to the right of the main tabs, but I don't feel strongly either way. Reviewed-by:

Re: [PATCH 2/2] ui-shared: emit root-desc-html and repo.desc-html after their text counterparts

2018-06-23 Thread John Keeping
On Thu, Jun 21, 2018 at 02:46:47PM +0800, Andy Green wrote: > Where root-desc and repo.desc are used in the header region, also > emit their html counterparts afterwards if they are defined. > > Where root-desc are repo.desc are used outside the header, > eg in the repo list, leave it as it is

Re: [PATCH v2 1/5] config: add js

2018-06-23 Thread John Keeping
On Thu, Jun 21, 2018 at 05:34:49PM +0800, Andy Green wrote: > Just like the config allows setting css URL path, > add a config for setting the js URL path > > Signed-off-by: Andy Green > --- > diff --git a/cgitrc.5.txt b/cgitrc.5.txt > index 99fc799..a692aa5 100644 > --- a/cgitrc.5.txt > +++

Re: [PATCH v2 2/5] cgit.js: introduce

2018-06-23 Thread John Keeping
On Thu, Jun 21, 2018 at 05:34:54PM +0800, Andy Green wrote: > Similar to how cgit.css is handled, we will also provide and > reference a cgit.js for javascript from now on. > > Signed-off-by: Andy Green > --- I think we can merge this and the previous patch, along with the change to output a

Re: [PATCH v2 3/5] ui-shared: introduce line range highlight javascript

2018-06-23 Thread John Keeping
On Thu, Jun 21, 2018 at 05:34:59PM +0800, Andy Green wrote: > This adds a small css class, a clientside js function in > cgit.js, and ajs inline script caller in ui-shared > functions to interpret the # part of the URL > on the client, and apply a highlight to filtered source. > > Unlike blame

Re: cache-size implementation downsides

2018-06-20 Thread John Keeping
On Wed, Jun 20, 2018 at 08:01:11AM +0200, Christian Hesse wrote: > John Keeping on Sat, 2018/06/16 16:46: > > -- >8 -- > > Subject: [PATCH] cache: close race window when unlocking slots > > You should add a "From:" line for easy git-am. ;) "git am --sci

Re: cache-size implementation downsides

2018-06-19 Thread John Keeping
On Sat, Jun 16, 2018 at 04:46:21PM +0100, John Keeping wrote: > On Wed, Jun 13, 2018 at 03:02:42PM -0400, Konstantin Ryabitsev wrote: > > 2. I have witnessed cache corruption due to collisions (which is > > a bug in itself). One of our frontends was hit by a lot of agressi

Re: [PATCH v3 17/17] render: adapt for providing extra filter args for plain

2018-06-19 Thread John Keeping
; "/cgit/plain/doc-assets/overview.png?h=mybranch" > > If the same document is viewed from a different rev in cgit, the > processed markdown url will change to match the cgit context, even > though the markdown relative URL is the same for all versions. > > Signed-

Re: [PATCH v3 16/17] ui-shared: add helper for generating non-urlencoded links

2018-06-19 Thread John Keeping
On Tue, Jun 19, 2018 at 05:02:47PM +0800, Andy Green wrote: > We are going to have to produce plain links in the next patch. > But depending on config, the links are not simple. > > Reproduce the logic in repolink() to generate correctly- > formatted links in a strbuf, without urlencoding, in a

Re: [PATCH v3 12/17] ui-tree: render any matching README file in tree view

2018-06-19 Thread John Keeping
me files rendering them inline. There's only one now, the commit message isn't quite accurate any more! > Signed-off-by: Andy Green > Reviewed-by: John Keeping > --- > ui-tree.c | 53 - > 1 file changed, 52 insertions(+), 1 deleti

Re: [PATCH v3 15/17] ui-shared: deduplicate some code in repolink

2018-06-19 Thread John Keeping
On Tue, Jun 19, 2018 at 05:02:42PM +0800, Andy Green wrote: > 8 lines of code are duplicated in repolink, clean it > so the common code appears once > > Signed-off-by: Andy Green Reviewed-by: John Keeping > --- > ui-shared.c | 26 ++ > 1 file c

Re: [PATCH v3 08/17] ui-blame: free read_sha1_file() buffer after use

2018-06-19 Thread John Keeping
On Tue, Jun 19, 2018 at 05:02:07PM +0800, Andy Green wrote: > Signed-off-by: Andy Green Pushed to jk/for-jason (after rebasing onto master). > --- > ui-blame.c |5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/ui-blame.c b/ui-blame.c > index 8b56554..37e2c68

Re: [PATCH v3 05/17] Parse render filters from the config

2018-06-19 Thread John Keeping
On Tue, Jun 19, 2018 at 05:01:51PM +0800, Andy Green wrote: > From: John Keeping > > Render filters will be used to present rendered content in the tree > view, for example to display Markdown source rendered as HTML. > > We will add support for using these from the tree vie

Re: [PATCH v3 01/17] manpage: fix sorting order

2018-06-19 Thread John Keeping
On Tue, Jun 19, 2018 at 05:01:31PM +0800, Andy Green wrote: > You maybe didn't know you had OCD until you saw an > alpha sorted list that has stuff out of order in it. > > Signed-off-by: Andy Green Reviewed-by: John Keeping > --- > c

Re: [PATCH v2] blame: css: make blame highlight div absolute and top left

2018-06-19 Thread John Keeping
On Tue, Jun 19, 2018 at 03:11:52AM +0800, Andy Green wrote: > On June 19, 2018 2:57:47 AM GMT+08:00, John Keeping > wrote: > >On Mon, Jun 18, 2018 at 02:02:54PM +0800, Andy Green wrote: > >> Normal operation of blame view requires div.highlight to > >> have ab

Re: [PATCH v2 14/15] md2html-add-asset-postfix-arg

2018-06-19 Thread John Keeping
On Tue, Jun 19, 2018 at 11:55:35AM +0800, Andy Green wrote: > > > On 06/19/2018 03:21 AM, John Keeping wrote: > > On Mon, Jun 18, 2018 at 10:58:26AM +0800, Andy Green wrote: > > >> class AssetMappingExtension(markdown.extensions.Extension): > >> &g

Re: [PATCH v2 12/15] ui-tree: render any matching README file in tree view

2018-06-19 Thread John Keeping
On Tue, Jun 19, 2018 at 09:55:18AM +0800, Andy Green wrote: > > > On 06/19/2018 03:36 AM, John Keeping wrote: > > On Mon, Jun 18, 2018 at 10:58:15AM +0800, Andy Green wrote: > >> While listing the items in tree view, we collect a list > >> of any filenames that m

Re: [PATCH v2 12/15] ui-tree: render any matching README file in tree view

2018-06-18 Thread John Keeping
me files rendering them inline. > > Signed-off-by: Andy Green A couple of minor style points below, but this looks good. With or without the style changes: Reviewed-by: John Keeping > --- > ui-tree.c | 60 +++- > 1

Re: [PATCH v2 10/15] config: add global inline-readme list

2018-06-18 Thread John Keeping
On Mon, Jun 18, 2018 at 10:58:05AM +0800, Andy Green wrote: > Allows the user to specify a list of filenames that should be > rendered inline with tree view, if present in the directory. > > Signed-off-by: Andy Green > --- > diff --git a/cgitrc.5.txt b/cgitrc.5.txt > index a1560eb..37858af

Re: [PATCH v2 11/15] config: add repo inline-readme list

2018-06-18 Thread John Keeping
but other than that this looks good. Reviewed-by: John Keeping > --- > cgit.c |6 ++ > cgit.h |1 + > cgitrc.5.txt | 10 ++ > shared.c |2 ++ > 4 files changed, 19 insertions(+) > > diff --git a/cgit.c b/cgit.c > index 4ffd

Re: [PATCH v2 15/15] render: adapt for providing extra filter args for plain

2018-06-18 Thread John Keeping
On Mon, Jun 18, 2018 at 10:58:31AM +0800, Andy Green wrote: > This changes the render filter exec part to provide a second > and third argument, which are used by md2html to fix up the url > path for "plain" for the repo, eg, "/cgit/plain/" and > "?h=mybranch", as required by the modifications to

Re: [PATCH v2 14/15] md2html-add-asset-postfix-arg

2018-06-18 Thread John Keeping
On Mon, Jun 18, 2018 at 10:58:26AM +0800, Andy Green wrote: > Extend md2html with a third argument for URL postfix, like "?h=mybranch" > > Signed-off-by: Andy Green > --- > filters/html-converters/md2html | 17 +++-- > 1 file changed, 11 insertions(+), 6 deletions(-) > > diff

Re: [PATCH v2 04/15] Add source page

2018-06-18 Thread John Keeping
On Mon, Jun 18, 2018 at 10:57:35AM +0800, Andy Green wrote: > From: John Keeping > > We are about to introduce rendering of content for the tree view. This > source page will allow bypassing the renderer and accessing the content > of the current tree view. > > Signed

Re: [PATCH v2] blame: css: make blame highlight div absolute and top left

2018-06-18 Thread John Keeping
On Mon, Jun 18, 2018 at 02:02:54PM +0800, Andy Green wrote: > Normal operation of blame view requires div.highlight to > have absolute position and set to its parent's top left > for me. > > Otherwise the grey background boxes indicating the extent of > the patch in the lines td displace the

Re: [PATCH 1/1] global: remove functionality we deprecated for cgit v1.0

2018-06-18 Thread John Keeping
On Mon, Jun 18, 2018 at 11:51:41AM +0200, Christian Hesse wrote: > From: Christian Hesse > > The man page states these were deprecated for v1.0. We are past v1.1, > so remove the functionality. > > Signed-off-by: Christian Hesse Reviewed-by: John Keeping > ---

Re: [PATCH] Update COPYING

2018-06-17 Thread John Keeping
ly non-whitespace changes are the updated FSF address and two > references to the L in LGPL changed from Library to Lesser. > > ¹ https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt Missing sign-off. Acked-by: John Keeping > --- > This will help users & distributors who

Re: Rendering of README.md inline with inner tree view dirs

2018-06-16 Thread John Keeping
On Sat, Jun 16, 2018 at 03:12:09PM +0100, John Keeping wrote: > > >> 3) You can see on the top level of the tree, the README.md references > > >> > > >> > > >> > > >> This url format works in github. In the cgit About view, this re

Re: [RFC PATCH] Makefile: work around parallel make issues in docs

2018-06-16 Thread John Keeping
Hi Todd, On Sat, Jun 16, 2018 at 12:32:06PM -0400, Todd Zullinger wrote: > John Keeping wrote: > > How about the patch below instead? It's a bigger change to the output > > format for HTML, but as a side effect it fixes the parallel build. > > It does, but only if the tar

Re: Bug: cgit shows empty pages, when viewing Tag-Only-Repo

2018-06-16 Thread John Keeping
newest tag as the default head [1]. This is a separate pass because we want to prefer branches if there are any. [1] In fact, we allow any ref at this point because we want to avoid falsely claiming that the repository is empty when it isn't. Signed-off-by: John Keeping --- cgit.c | 46

Re: [PATCH] ui-tag: Fix inconsistent capitalization

2018-06-16 Thread John Keeping
On Sun, Jun 10, 2018 at 06:28:49PM -0400, Jon DeVree wrote: > Way back in 2009 all of these were lower cased except this one > occurrence. > > Signed-off-by: Jon DeVree Thanks! I've picked this up in jk/for-jason. > --- > ui-tag.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH 1/1] snapshot: support special value 'all' to enable all formats

2018-06-16 Thread John Keeping
On Thu, Jun 07, 2018 at 10:05:50PM +0200, Christian Hesse wrote: > From: Christian Hesse > > Signed-off-by: Christian Hesse Reviewed-by: John Keeping > --- > cgitrc.5.txt | 1 + > shared.c | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/cgitrc.5

Re: Translation

2018-06-16 Thread John Keeping
On Mon, Jun 04, 2018 at 10:24:24AM +0200, Malte Kiefer wrote: > first of all I want to say thank you for this amazing software. > I start to using it, and I really like it. > > Then I wanted to inquire with you if you think about offering cgit in > multiple languages? > I would like to translate

[PATCH] cgitrc.5: fix auth filter return value documentation

2018-06-16 Thread John Keeping
We don't treat all return values as invalid! Signed-off-by: John Keeping --- cgitrc.5.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cgitrc.5.txt b/cgitrc.5.txt index 4da166c..3e53bbd 100644 --- a/cgitrc.5.txt +++ b/cgitrc.5.txt @@ -715,7 +715,7 @@ auth filter

Re: [PATCH] Encode value and field before calculating cookie digest, the same way secure_value() does

2018-06-16 Thread John Keeping
On Thu, Apr 12, 2018 at 08:54:31PM +0300, thev...@gmail.com wrote: > From: Vlad Safronov > > Bugfix: Encode value and field before calculating cookie digest, the same way > as secure_value() does > so validating will work correctly on encoded values. Missing sign-off (see [1] for what this

Re: [PATCH] expand environmentvariables in root-title and root-descr

2018-06-16 Thread John Keeping
On Thu, Apr 12, 2018 at 11:19:12AM +0200, b.laes...@pengutronix.de wrote: > From: Björn Lässig > > For having personanlized cgit configuration i need to use > > root-desc=$REMOTE_USER@$HTTP_HOST Missing sign-off (see [1] for what this means). Also, this needs a corresponding change in

Re: Adding short commit id to repo Log tab

2018-06-16 Thread John Keeping
Sorry for the delay responding. On Wed, Apr 11, 2018 at 12:00:28PM +0300, Vlad wrote: > I think adding short (7 chars) commit id to repository Log tab output > might be more useful than file or line count.. > > I have examined the code, it it not easy to add an extra column > to the output. > >

Re: [PATCH 1/1] RFC: git: update to v2.18.0-rc2

2018-06-16 Thread John Keeping
int_dir_entry > print_object > single_tree_cb > walk_tree > write_tree_link > > And finally we use new upstream functions that were added for > struct object_id: > > hashcpy -> oidcpy > sha1_to_hex -> oid_to_hex > > Signed-off-by: Christian Hesse With

Re: cache-size implementation downsides

2018-06-16 Thread John Keeping
orary stdout FD into struct cache_slot. Signed-off-by: John Keeping --- cache.c | 37 ++--- 1 file changed, 14 insertions(+), 23 deletions(-) diff --git a/cache.c b/cache.c index 0901e6e..2c70be7 100644 --- a/cache.c +++ b/cache.c @@ -29,6 +29,7 @@ struct cache_s

Re: [PATCH 10/11] config: add tree-readme list

2018-06-16 Thread John Keeping
On Wed, Jun 13, 2018 at 10:02:20AM +0800, Andy Green wrote: > Allows the user to specify a list of filenames that should be > rendered inline with tree view, if present in the directory. > > Signed-off-by: Andy Green As mentioned in reply to the cover leter, I think this needs to be a repo

Re: [PATCH 09/11] ui-tree: ls_tail: add walk table param

2018-06-16 Thread John Keeping
On Wed, Jun 13, 2018 at 10:02:15AM +0800, Andy Green wrote: > Arrange that walk_tree_ctx is available in ls_tail, we > will make use of it shortly. > > Signed-off-by: Andy Green Reviewed-by: John Keeping > --- > ui-tree.c |6 +++--- > 1 file changed, 3 inser

Re: [PATCH 08/11] ui-tree: print_object: add is_inline param

2018-06-16 Thread John Keeping
On Wed, Jun 13, 2018 at 10:02:10AM +0800, Andy Green wrote: > We will reuse print_object to render things inline shortly. > > Add a parameter that lets us adapt its behaviour slightly > for that case. > > Signed-off-by: Andy Green > --- > ui-tree.c |7 --- > 1 file changed, 4

Re: [PATCH 05/11] ui-tree: use render fileters to display content

2018-06-16 Thread John Keeping
If you're including these patches in your series, please fix my typo in the subject ("fileters" has a stray 'e') :-) On Wed, Jun 13, 2018 at 10:01:55AM +0800, Andy Green wrote: > From: John Keeping > > This allows applying filters to files in the repository, for example t

Re: [PATCH 06/11] ui-tree: free read_sha1_file() buffer after use

2018-06-16 Thread John Keeping
On Wed, Jun 13, 2018 at 10:02:00AM +0800, Andy Green wrote: > Free up the buffer allocated in read_sha1_file() > > Signed-off-by: Andy Green Reviewed-by: John Keeping I've extracted this from the series and pushed it on my for-jason branch: https://git.zx2c4.com/cgit/log/?h=jk/

Re: [PATCH 07/11] ui-blame: free read_sha1_file() buffer after use

2018-06-16 Thread John Keeping
On Wed, Jun 13, 2018 at 10:02:05AM +0800, Andy Green wrote: > Signed-off-by: Andy Green > --- > ui-blame.c |3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/ui-blame.c b/ui-blame.c > index 17e2d60..a5c7d69 100644 > --- a/ui-blame.c > +++ b/ui-blame.c > @@ -206,6 +206,9 @@ static

Re: [PATCH 00/11] Render READMEs inline in tree view

2018-06-16 Thread John Keeping
On Thu, Jun 14, 2018 at 11:47:41AM +0800, Andy Green wrote: > On 06/13/2018 10:01 AM, Andy Green wrote: > > The following series adds config to allow rendering of > > selected READMEs inline after the tree view, where > > present in the directory being viewed. > > > > It builds on John Keeping's

Re: [PATCH 1/2] gcc8.1: fix strncpy bounds warnings

2018-06-16 Thread John Keeping
On Sat, Jun 16, 2018 at 09:12:08PM +0800, Andy Green wrote: > > > On June 16, 2018 9:04:48 PM GMT+08:00, John Keeping > wrote: > >On Wed, Jun 13, 2018 at 07:33:59AM +0800, Andy Green wrote: > >> These warnings are coming on default Fedora 28 build and proba

Re: Rendering of README.md inline with inner tree view dirs

2018-06-16 Thread John Keeping
On Wed, Jun 13, 2018 at 09:47:38AM +0800, Andy Green wrote: > > > On 06/12/2018 05:31 PM, John Keeping wrote: > > On Tue, Jun 12, 2018 at 01:53:27PM +0800, Andy Green wrote: > >> On 06/11/2018 11:38 PM, John Keeping wrote: > >>> On Mon, Jun 11, 2018 a

Re: [PATCH 2/2] gcc8.1: fix strcat warning

2018-06-16 Thread John Keeping
; > Make the code do the padding explicitly. > > Signed-off-by: Andy Green Reviewed-by: John Keeping > --- > ui-ssdiff.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/ui-ssdiff.c b/ui-ssdiff.c > index 7f261ed..e520b95 10064

[PATCH 2/2] shared: use strbuf for expanding macros

2018-06-16 Thread John Keeping
Avoid a fixed size buffer by using struct strbuf to build the expanded value. Signed-off-by: John Keeping --- shared.c | 73 +--- 1 file changed, 27 insertions(+), 46 deletions(-) diff --git a/shared.c b/shared.c index 32d0f46..6ce3990 100644

[PATCH 1/2] shared: allocate return value from expand_macros()

2018-06-16 Thread John Keeping
In preparation for switching the implementation of expand_macros away from a static buffer, return an allocated buffer and update all callers to release it. Signed-off-by: John Keeping --- cgit.c | 33 +++-- shared.c| 5 ++--- ui-shared.c | 9 ++--- 3

Re: [PATCH 1/2] gcc8.1: fix strncpy bounds warnings

2018-06-16 Thread John Keeping
On Wed, Jun 13, 2018 at 07:33:59AM +0800, Andy Green wrote: > These warnings are coming on default Fedora 28 build and probably others > using gcc 8.1 > > ../shared.c: In function ‘expand_macro’: > ../shared.c:483:3: warning: ‘strncpy’ specified bound depends on the length > of the source

Re: [RFC PATCH] Makefile: work around parallel make issues in docs

2018-06-16 Thread John Keeping
On Sat, Jun 16, 2018 at 01:38:31AM -0400, Todd Zullinger wrote: > When make is run with multiple jobs, doc-man and doc-html fail. The a2x > command tries to write %.5.xml for each invocation, overwriting each > other. > > Work around this by copying %.5 to %.5+ in doc-man. This is a rather >

Re: Rendering of README.md inline with inner tree view dirs

2018-06-12 Thread John Keeping
On Tue, Jun 12, 2018 at 05:27:09PM +0800, Andy Green wrote: > > > On June 12, 2018 5:24:37 PM GMT+08:00, John Keeping > wrote: > >On Tue, Jun 12, 2018 at 10:35:25AM +0200, Christian Hesse wrote: > >> Andy Green on Tue, 2018/06/12 13:53: > >> > 5) I get

Re: Rendering of README.md inline with inner tree view dirs

2018-06-12 Thread John Keeping
On Tue, Jun 12, 2018 at 01:53:27PM +0800, Andy Green wrote: > On 06/11/2018 11:38 PM, John Keeping wrote: > > On Mon, Jun 11, 2018 at 04:05:38PM +0800, Andy Green wrote: > > >> I think what github did comes into its own when you are in the mode of > >> comi

Re: Rendering of README.md inline with inner tree view dirs

2018-06-12 Thread John Keeping
On Tue, Jun 12, 2018 at 10:35:25AM +0200, Christian Hesse wrote: > Andy Green on Tue, 2018/06/12 13:53: > > 5) I get some gcc 8.1 warnings, I made a couple of patches to get around > > them. In a couple of places, the code seemed legit really. > > I do see these on Arch as well. :) > Did not

Re: Rendering of README.md inline with inner tree view dirs

2018-06-11 Thread John Keeping
README.md as > >>>> github does. This is quite a small thing but very useful, eg > >>>> > >>>> https://github.com/warmcat/libwebsockets/tree/master/minimal-examples > >>>> > >>>> vs > >>>&g

Re: [PATCH 1/1] snapshot: strip bit from struct cgit_snapshot_format

2018-06-09 Thread John Keeping
On Sat, Jun 09, 2018 at 12:11:11AM +0200, Christian Hesse wrote: > From: Christian Hesse > > We had a static bit value in struct cgit_snapshot_format. We do not rely > on it and things can be calculated on the fly. So strip it. > > Signed-off-by: Christian Hesse > --- > cgit.c| 3 ++-

Re: [PATCH v2 2/2] snapshot: support tar signature for compressed tar

2018-06-07 Thread John Keeping
On Thu, Jun 07, 2018 at 05:14:52PM +0200, Christian Hesse wrote: > From: Christian Hesse > > This adds support for kernel.org style signatures where the uncompressed > tar archive is signed and compressed later. The signature is valid for > all tar* snapshots. > > We have a filter which

Re: [PATCH 1/1] snapshot: support tar signature for compressed tar

2018-06-07 Thread John Keeping
On Thu, Jun 07, 2018 at 02:15:34PM +0200, Christian Hesse wrote: > From: Christian Hesse > > This adds support for kernel.org style signatures where the uncompressed > tar archive is signed and compressed later. The signature is valid for > all tar* snapshots. > > Signed-off-by: Christian Hesse

Re: Custom snapshot prefix & Snapshot signatures

2018-06-07 Thread John Keeping
gree with Konstantin, though: Binary compressed data may change over > time with more recent algorithms. So I will reply with an extra patch that > allows to push tar signatures to git notes that can be downloaded for > compressed tar snapshots. > > Custom snapshot prefix [0]:

Re: [PATCH v2 1/1] ui-log: highlight annotated tags in different color

2018-06-05 Thread John Keeping
wed-by: John Keeping > Signed-off-by: Christian Hesse > --- > cgit.css | 8 > ui-log.c | 6 +- > 2 files changed, 13 insertions(+), 1 deletion(-) > > diff --git a/cgit.css b/cgit.css > index 217a05a..05c4530 100644 > --- a/cgit.css > +++ b/cgit.css > @@ -

Re: [PATCH 1/1] ui-log: highlight annotated tags in different color

2018-06-05 Thread John Keeping
On Tue, Jun 05, 2018 at 12:47:52PM +0200, Christian Hesse wrote: > Signed-off-by: Christian Hesse Can you say a little about why this is desirable as a feature? > --- > cgit.css | 8 > ui-log.c | 7 ++- > 2 files changed, 14 insertions(+), 1 deletion(-) > > diff --git a/cgit.css

[RFC/PATCH 5/7] ui-shared: pass separator in to cgit_print_snapshot_links()

2018-03-31 Thread John Keeping
cgit_print_snapshot_links() is almost identical to print_tag_downloads(), so let's extract the difference to a parameter in preparation for removing print_tag_downloads() in the next commit. Signed-off-by: John Keeping <j...@keeping.me.uk> --- ui-commit.c | 2 +- ui-shared.c | 5 +++

  1   2   3   4   5   >