Re: Cannot apply about patches anymore

2019-06-26 Thread Jason A. Donenfeld
ch/about-link has these: https://git.zx2c4.com/cgit/patch/?id=5f215cec80c9ba08d80eeb4c23880537ca66f9d3 https://git.zx2c4.com/cgit/patch/?id=2fd38313e75fb4240c85c253292144f4fc299cc9 ___ CGit mailing list CGit@lists.zx2c4.com

[ANNOUNCE] git.zx2c4.com ssh host fingerprints changed

2019-06-21 Thread Jason A. Donenfeld
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi contributors, I've you push to git.zx2c4.com over ssh, you'll notice the ssh fingerprints have changed. The valid new ones are: SHA256:9os9asMrVeuWNlQmsmpA6bfcgFIwr5e0psYJYVBekUM SHA256:frea6X2uzWJ3m0w5/qMKuXpbRgvvQIsFqotWCWkbR4M

[PATCH] ui-shared: restrict to 15 levels

2019-05-20 Thread Jason A. Donenfeld
Perhaps a more ideal version of this would be to not print breadcrumbs at all for paths that don't exist in the given repo at the given oid. Signed-off-by: Jason A. Donenfeld Reported-by: Fydor Wire Snark --- I've committed this, and it works. But if anyone would like to give the implementation

Re: [PATCH] ui-diff, ui-tag: don't use htmlf with non-formatted strings

2019-02-22 Thread Jason A. Donenfeld
Thanks, merged. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH] ui-ssdiff: resolve HTML5 validation errors

2019-02-22 Thread Jason A. Donenfeld
Merged, thanks. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH] Update links and use https where available

2019-02-22 Thread Jason A. Donenfeld
Merged, thanks. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/2] ui-ssdiff: ban strncat()

2019-02-09 Thread Jason A. Donenfeld
You sure those statements are the same? Snprintf doesn't append like strncat. Wouldn't strlcat be the more apt replacement? -- Sent from my telephone. On Fri, Feb 8, 2019, 22:49 Christian Hesse From: Christian Hesse > > Git version v2.21.0 marks strncat() as banned (commit >

Re: [PATCH 1/1] global: male 'char *path' const where possible

2019-01-02 Thread Jason A. Donenfeld
Seems reasonable. Queue it up. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH] ui-shared: fix segfault in cgit_set_title_from_path

2019-01-01 Thread Jason A. Donenfeld
Hah, bad timing, I just rewrote this myself and was about to push. But thanks anyway! ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/1] git: update to v2.20.0

2018-12-09 Thread Jason A. Donenfeld
Merged, thanks. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/1] cgitrc: handle value "0" for max-repo-count

2018-12-06 Thread Jason A. Donenfeld
That seems very reasonable. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/1] git: use xz compressed archive for download

2018-11-20 Thread Jason A. Donenfeld
Thanks, merged. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/1] cgitrc: handle value "0" for max-repo-count

2018-10-18 Thread Jason A. Donenfeld
Hey Christian, We should indeed introduce some sanitation helpers to deal with these in the general case. API suggestion: type_t parse_int(const char *str, type_t min, type_t max, type_t fallback_if_invalid); What would you think of that? Regards, Jason

Re: [PATCH 1/1] git: update to v2.19.0

2018-09-10 Thread Jason A. Donenfeld
Thanks Christian. Feel free to queue this all up in a for-jason branch. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/1] filters: generate anchor links from markdown

2018-08-25 Thread Jason A. Donenfeld
Sounds pretty useful and hard to see downsides, then. Feel free to queue this up in a for-jason. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/1] filters: generate anchor links from markdown

2018-08-25 Thread Jason A. Donenfeld
The effect is just anchor links, but it doesn't add an actual ToC, right? ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [ANNOUNCE] CGIT v1.2.1 Released

2018-08-03 Thread Jason A. Donenfeld
On Fri, Aug 3, 2018 at 5:12 PM Jason A. Donenfeld wrote: > * A fix for a critical directory traversal vulnerability, when > `enable-http-clone=1` is not turned off, discovered by Jann Horn. > This is pretty nasty and all users must update immediately. This has been assigned CVE-2

Re: [ANNOUNCE] CGIT v1.2.1 Released

2018-08-03 Thread Jason A. Donenfeld
On Fri, Aug 3, 2018 at 7:06 PM Todd Zullinger wrote: > Yikes, thanks for the heads-up! Do you know if there is a > CVE assigned for this issue yet? I've requested one. > It sounds like it affects > all releases from 0.8 through 1.2, right? Yes. ___

[ANNOUNCE] CGIT v1.2.1 Released

2018-08-03 Thread Jason A. Donenfeld
. This release contains commits from: Jason A. Donenfeld and Konstantin Ryabitsev. == Downloading == This release is available in compressed tarball form here: https://git.zx2c4.com/cgit/snapshot/cgit-1.2.1.tar.xz SHA2-256: 3c547c146340fb16d4134326e7524bfb28ffa681284f1e3914bde1c27a9182bf BLAKE2b-256

Re: a gopher version of cgit

2018-08-02 Thread Jason A. Donenfeld
That's super! Thanks for sharing this here. Clever name too. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH] Record repo.snapshot-prefix in the per-repo config

2018-07-17 Thread Jason A. Donenfeld
Thanks! Applied. Jason ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: Release plan for 1.2

2018-07-13 Thread Jason A. Donenfeld
Great, thanks Konstantin. I'll release right away. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH] Update COPYING

2018-07-10 Thread Jason A. Donenfeld
Applied, thanks. And I've retained your use of the ยน character in the commit message, as it might prove to be useful for detecting various UTF-8 breakage down the road. ___ CGit mailing list CGit@lists.zx2c4.com

Security pitfalls of .tar.asc

2018-07-04 Thread Jason A. Donenfeld
cgit-1.1.tar.xz $ gpg --verify cgit-1.1.tar.asc gpg: assuming signed data in 'cgit-1.1.tar' gpg: Signature made Thu 05 Jul 2018 02:34:20 AM CEST gpg:using RSA key AB9942E6D4A4CFC3412620A749FC7012A5DE03AE gpg:issuer "ja...@zx2c4.com" gpg: Good signature f

Release plan for 1.2

2018-07-03 Thread Jason A. Donenfeld
Hey guys, Seeing as there hasn't been a release for a while, it seems prudent that we get one out fairly soon. Indeed there have been a lot of new things added and code refactored since 1.1. There's still the possibility of getting the render view improvements ready for 1.2 -- if those are

Re: [PATCH] native inline gravatar

2018-07-03 Thread Jason A. Donenfeld
On Wed, Jul 4, 2018 at 2:44 AM Andy Green wrote: > > looked at in depth. (See the list archives.) Our last conclusion from > > examining it was that so much of libgit is not re-entrant, and so we'd > > need to move to something like libgit2 for this to be feasible. Too > > many globals, etc. > >

Re: [PATCH] native inline gravatar

2018-07-03 Thread Jason A. Donenfeld
On Wed, Jul 4, 2018 at 2:28 AM Andy Green wrote: > I looked at it, but there's no md5 api in JS... you have to do it by > hand in JS. It's possible but I think it might be slow if it hits a > page of 50 different email addresses. MD5 is really fast and fits easily into javascript's integer

Re: [PATCH] native inline gravatar

2018-07-03 Thread Jason A. Donenfeld
On Wed, Jul 4, 2018 at 2:01 AM Andy Green wrote: > doesn't use any filters for syntax highlight and markdown render, it's > all done in clientside JS. The gravatar is done using this patch. If you're into doing things clientside, you could do gravatar clientside too of course... > This of

Re: [PATCH v2 02/15] gcc8.1: fix strncat warning

2018-07-03 Thread Jason A. Donenfeld
On Wed, Jul 4, 2018 at 1:48 AM Andy Green wrote: > $ rpm -q gcc > gcc-8.1.1-1.fc28.x86_64 > > It's the current package on Fedora 28. 8.1.1, thanks. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH] native inline gravatar

2018-07-03 Thread Jason A. Donenfeld
Sorry, but not a chance something like this can be accepted. This is exactly the reason we put the time into making the Lua scripting support. Is your reason for implementing this C performance? In that case, could you send some performance metrics and some details about your performance

Re: [PATCH v2 02/15] gcc8.1: fix strncat warning

2018-07-03 Thread Jason A. Donenfeld
Hi Andy, I can't actually reproduce this with gcc 8.1.0. Could you send me the output of your `gcc -v`? Thanks, Jason ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH v4 00/16] Render READMEs inline in tree view

2018-07-03 Thread Jason A. Donenfeld
On Tue, Jul 3, 2018 at 9:53 PM John Keeping wrote: > If I can have one more bikeshed... I wonder if "about-content" is better > than "about-readme", the latter feels a bit like we're saying this same > thing twice. Bikeshed granted. :) Yes, that sounds sensible.

Re: [PATCH v4 00/16] Render READMEs inline in tree view

2018-07-03 Thread Jason A. Donenfeld
Hey John, On Thu, Jun 28, 2018 at 10:29 AM John Keeping wrote: > Yeah, I don't think there's any way to avoid exec'ing twice in source > view - we need to run the source filter for output and we need the > render filter to tell us whether we should output a link to the rendered > content. Let's

Re: [PATCH v3 1/1] snapshot: support tar signature for compressed tar

2018-07-03 Thread Jason A. Donenfeld
I've merged a variant of the patch, and it appears to be working well. Thanks guys! ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/1] css: darken the footer

2018-07-03 Thread Jason A. Donenfeld
On Mon, Jul 2, 2018 at 9:11 AM Christian Hesse wrote: > > Christian Hesse on Fri, 2018/06/08 07:21: > > From: Christian Hesse > > > > The footer was nearly invisible, hard to read at best. Let's make it > > a bit darker. > > This stayed in ch/for-jason. Any feedback? Fairly subjective, but I

Re: [PATCH v5 6/6] line-range-highlight: copy URL to clipboard UI

2018-06-27 Thread Jason A. Donenfeld
On Thu, Jun 28, 2018 at 1:24 AM Andy Green wrote: > Can you help me understand what is "clearly superior" and "right way" > about the [...] menu in github? > > Since you seem to be asking me to implement it? > > What put me off it was there's only one useful option on it, and it > requires and

Re: [PATCH v4 00/16] Render READMEs inline in tree view

2018-06-27 Thread Jason A. Donenfeld
Hey John, Thanks tons for your input, as always. On Wed, Jun 27, 2018 at 9:51 PM John Keeping wrote: > - It is desirable to have the existing source view in addition to the > rendered content, preferably with syntax highlighting via the source > filter; for example Markdown, HTML or SVG can

Re: [PATCH v4 00/16] Render READMEs inline in tree view

2018-06-27 Thread Jason A. Donenfeld
Hi Andy, I'm happy to engage technically here in order to find the best way of going about this. However, > Nobody is paying me to do it and I don't have an endless budget of time > to lavish on it (and it seems, neither do you...). > If cgit can't do what I need in a reasonable timescale, even

Re: [PATCH v5 6/6] line-range-highlight: copy URL to clipboard UI

2018-06-27 Thread Jason A. Donenfeld
Nack. If we're going to add something like this, the github GUI for it is clearly superior and the right way of going about things, with the elegant [...] menu. Jason ___ CGit mailing list CGit@lists.zx2c4.com

Re: [PATCH v5 2/6] cgit.js: line range highlight: introduce javascript

2018-06-27 Thread Jason A. Donenfeld
Hi Andy, I'm super hesitant about the Pandora's box that introducing javascript implies, but perhaps there's no use in fighting the future. A few notes: - Your js needs the copyright line like the rest of the project. - Rather than awkwardly namespacing global methods, wrap everything inside a

Re: [PATCH v4 13/16] ui-shared: deduplicate some code in repolink

2018-06-27 Thread Jason A. Donenfeld
And, reverted. The code is not the same; this broke tests. html_url_arg != html_url_path. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH v4 16/16] md2html: change css name to not conflict with highlight

2018-06-27 Thread Jason A. Donenfeld
Hi Andy, This seems like an obvious thing to merge, but I'm actually not so certain I understand its necessity. md2html uses the highlight class. Our css uses the highlight class. You're saying this conflicts with something? From where? Third-party CSS? If that's the case, and if it's a serious

Re: [PATCH v4 11/16] md2html: add asset mapping

2018-06-27 Thread Jason A. Donenfeld
On Wed, Jun 20, 2018 at 12:13 PM Andy Green wrote: > md2html > The trailing "/" is important. Can we make it not important? That is, if the type is always explicitly a directory, treat it as such using the usual file name joining logic. Alternatively, and perhaps better, don't

Re: [PATCH v4 13/16] ui-shared: deduplicate some code in repolink

2018-06-27 Thread Jason A. Donenfeld
Merged, thanks. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH v4 01/16] manpage: fix sorting order

2018-06-27 Thread Jason A. Donenfeld
Merged, thanks. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH v4 02/16] Use string list strdup_strings for mimetypes

2018-06-27 Thread Jason A. Donenfeld
Thanks John, merged. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Fancier Source view [Was: Re: [PATCH v4 00/16] Render READMEs inline in tree view]

2018-06-27 Thread Jason A. Donenfeld
Splitting out this issue into a different thread, because I think it's orthogonal to the other topic. On Wed, Jun 27, 2018 at 7:18 PM Jason A. Donenfeld wrote: > In adding rendering of arbitrary files in blob view, this is > essentially a fancy source view, with the one caveat

Re: [PATCH v4 00/16] Render READMEs inline in tree view

2018-06-27 Thread Jason A. Donenfeld
Hey Andy, Thanks for this patchset. It looks like this is shaping up into a nice direction. However, I'm a bit concerned about our nobs becoming slightly overlapping and incoherent, and I think that with this series, we should also unify how we handle rendering. With the current state of this

Re: [PATCH 1/1] RFC: git: update to v2.18.0-rc2

2018-06-16 Thread Jason A. Donenfeld
On Sat, Jun 16, 2018 at 6:14 PM John Keeping wrote: > But we still have a few mentions of sha1 in our code. Most of this is > sha1 and sha2 in struct cgit_query, but these aren't actually hashes > most of the time, they can be any object reference that Git understands, > so I think we should

Re: [RFC PATCH] Makefile: work around parallel make issues in docs

2018-06-16 Thread Jason A. Donenfeld
Hey John, That seems like a reasonable approach. Feel free to queue it up in jk/for-jason. Jason ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH v3 1/1] print git version string in footer

2018-06-06 Thread Jason A. Donenfeld
LGTM. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/1] print git version string in footer

2018-06-04 Thread Jason A. Donenfeld
Hey Christian, I like this idea and I'll probably merge it, because it seems handy. On the other hand, there's some argument to be made for not wearing your security bugs on your sleeves by revealing version numbers by default. I'm wondering what motivated it for you, though. Jason

Re: Upcoming release?

2018-04-26 Thread Jason A. Donenfeld
On Thu, Apr 26, 2018 at 2:19 PM, Christian Hesse <l...@eworm.de> wrote: > "Jason A. Donenfeld" <ja...@zx2c4.com> on Thu, 2018/03/22 20:16: >> Hi Terry, >> >> I'm traveling now, but I'll push out a release when I'm home mid April. > > Any news o

Re: NGINX and linux

2018-04-03 Thread Jason A. Donenfeld
I run uwsgi+cgit on the actual cgit cgit repo. Here's the setup: krantz ~ # cat /etc/nginx/sites/cgit.conf server { listen 443 ssl http2; listen [::]:443 ssl http2; server_name git.zx2c4.com; access_log /var/log/nginx/cgit.access_log main; error_log

Re: Upcoming release?

2018-03-22 Thread Jason A. Donenfeld
Hi Terry, I'm traveling now, but I'll push out a release when I'm home mid April. Jason -- Sent from my telephone. On Thu, Mar 22, 2018, 13:07 Dunnigan, Terrence J < terrence.j.dunni...@boeing.com> wrote: > Hi all, > > > > I was wondering if there was an ETA for the next release of cgit? I am

Re: RFC: snapshot tarball information in refs/notes/snapshots

2018-03-21 Thread Jason A. Donenfeld
Hey Konstantin, That sounds like a potentially good idea. Though it does point to the larger question: should notes be used in general for configuring more parts of cgit in an ad-hoc manner? Is there a useful generalization of this mechanism we should consider? We already have four different

Re: [PATCH] doc: use consistent id's when generating html files

2018-02-20 Thread Jason A. Donenfeld
This time you forgot the... just kidding. Applied, thanks. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH/wiki] Update Fedora package link

2018-02-20 Thread Jason A. Donenfeld
Thanks. Pushed. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH] doc: use consistent id's when generating html files

2018-02-20 Thread Jason A. Donenfeld
Seems reasonable to me. Can you resubmit with your `Signed-off-by:`? Jason ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

[PATCH] extra-head-content: introduce another option for meta tags

2018-02-12 Thread Jason A. Donenfeld
This is to support things like go-import meta tags, which are on a per-repo basis. Signed-off-by: Jason A. Donenfeld <ja...@zx2c4.com> --- This is kind of really ugly, and I'm not keen on its approach, but I thought I'd post it to get some feedback on the general "requirement&quo

Re: [PATCH 0/4] Add ui-blame syntax highlighting

2018-01-19 Thread Jason A. Donenfeld
This patchset has been merged to master. Thanks for your contribution! Jason ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/1] git: update to v2.16.0

2018-01-19 Thread Jason A. Donenfeld
Thanks, merged this. I grabbed the commit from this email, rather than from your branch in the repo, because this one had the signed-off-by line and the other didn't. Jason ___ CGit mailing list CGit@lists.zx2c4.com

Re: [PATCH 4/4 v3] ui-blame: Allow syntax highlighting

2017-10-29 Thread Jason A. Donenfeld
Works remarkably well. Excellent work. Example, for others on the list: https://git.zx2c4.com/WireGuard/blame/src/noise.c Pending objections from others, I'll merge this from jd/color-blame to master in a few days. Thanks for this series! Jason ___

Re: [PATCH 4/4] ui-blame: Allow syntax highlighting

2017-10-24 Thread Jason A. Donenfeld
Just waiting on resubmission of this 4/4, then. I'll put 1-3 in a branch. Jason ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 0/4] adding color to ui-blame

2017-10-15 Thread Jason A. Donenfeld
Hi Jeff, Oh, cool. What's your idea for accomplishing that? Planning on putting it through the filter, buffering it, and then spitting it back out in equal sized chunks, hoping the filter doesn't add extra new lines? Jason ___ CGit mailing list

Re: [PATCH 0/4] adding color to ui-blame

2017-10-15 Thread Jason A. Donenfeld
Right, we may very well need a more capable model. One approach would be to get rid of all the exec stuff, and instead have plugins, that can register themselves in all sorts of places. A plugin would define a series of hooks and filters, which would be directly called at the right time. We'd

Re: [PATCH] Spelling fixes

2017-10-15 Thread Jason A. Donenfeld
Applied thanks. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH] Use type='search' for the search box

2017-10-15 Thread Jason A. Donenfeld
Applied thanks. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

[PATCH 0/4] adding color to ui-blame

2017-10-14 Thread Jason A. Donenfeld
). Jason A. Donenfeld (4): filter: add generic scafolding for temporarily disabling filter filter: wire up exec_filter to enable function filter: wire up lua_filter to enable function ui-blame: put source lines through filter cgit.h | 3 +++ filter.c | 46

[PATCH 1/4] filter: add generic scafolding for temporarily disabling filter

2017-10-14 Thread Jason A. Donenfeld
Signed-off-by: Jason A. Donenfeld <ja...@zx2c4.com> --- cgit.h | 2 ++ filter.c | 9 +++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/cgit.h b/cgit.h index 005ae63..8da69e7 100644 --- a/cgit.h +++ b/cgit.h @@ -61,6 +61,7 @@ typedef enum { struct cgit_

[PATCH 2/4] filter: wire up exec_filter to enable function

2017-10-14 Thread Jason A. Donenfeld
We also move pipe_fh to be local, since it's not needed any place else. Signed-off-by: Jason A. Donenfeld <ja...@zx2c4.com> --- cgit.h | 1 + filter.c | 27 +-- 2 files changed, 22 insertions(+), 6 deletions(-) diff --git a/cgit.h b/cgit.h index 8da69e7..f

[PATCH 3/4] filter: wire up lua_filter to enable function

2017-10-14 Thread Jason A. Donenfeld
Signed-off-by: Jason A. Donenfeld <ja...@zx2c4.com> --- filter.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/filter.c b/filter.c index 4deb4de..7b5bef5 100644 --- a/filter.c +++ b/filter.c @@ -353,6 +353,15 @@ static int close_lua_filter(struct cgit_filter

[PATCH 4/4] ui-blame: put source lines through filter

2017-10-14 Thread Jason A. Donenfeld
We toggle the filter on and off so that the control table can avoid going through the filter. Signed-off-by: Jason A. Donenfeld <ja...@zx2c4.com> --- ui-blame.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/ui-blame.c b/ui-blame.c index 62cf431..7

Re: [PATCH] parsing: don't clear existing state with empty input

2017-10-14 Thread Jason A. Donenfeld
Looks reasonable to me. Thanks for reporting, Tom, and thanks for the patch John. Applied. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 0/5] Add ui-blame

2017-10-03 Thread Jason A. Donenfeld
Merged to master. Working quite nicely: https://git.zx2c4.com/cgit/blame/ui-shared.c Jeff -- do we want to be passing this through the source code filter to get highlighted lines? ___ CGit mailing list CGit@lists.zx2c4.com

Re: [PATCH 0/5] Add ui-blame

2017-10-03 Thread Jason A. Donenfeld
Hi John, Alright, I'll pull from your branch rather than Christian's then. Thanks to all three of you in any case! Jason ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 0/5] Add ui-blame

2017-10-01 Thread Jason A. Donenfeld
Jeff -- thanks for your hard work on this. John -- thanks for the review. If you'd like to put this in a for-jason branch, I'll get to merging it soon. Jason ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH v2] Use https for submodule

2017-09-21 Thread Jason A. Donenfeld
Merged, thanks! ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/1] ui-repolist: remove unused variable

2017-07-26 Thread Jason A. Donenfeld
On Wed, Jul 26, 2017 at 8:34 PM, Christian Hesse wrote: >> Jason, any chance you can go through our for-jason branches and merge >> them anytime soon? > > Yes, please! Absolutely. I'm finishing up a time consuming job this week, and mid-next week, I'll start merging.

Re: [PATCH] cache: flush stdio before restoring FDs

2017-04-24 Thread Jason A. Donenfeld
Hey John, Wow, that was quick. Konstantin and I were just talking about this. I'll review this and merge things asap. Another related thing were were discussing and I was just investigating is the inherent buffering that our cache system uses. When it's filling a slot, everything is buffered

Re: Blame

2017-04-19 Thread Jason A. Donenfeld
Hey Jeff, If option 1 can be done cleanly enough, that'd be fine with me. Jason ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH] Remove unused variable from sort_section()

2017-04-05 Thread Jason A. Donenfeld
Looks good to me. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH] filter: set environment variable PYTHONIOENCODING to utf-8

2017-03-17 Thread Jason A. Donenfeld
On Sun, Mar 12, 2017 at 6:51 PM, John Keeping wrote: > While I'm inclined to agree with this, in this particular case we > explicitly encode pages as UTF-8 so there is an argument that we should > be telling child processes that UTF-8 is the correct encoding. That's a

Re: [PATCH] filter: set environment variable PYTHONIOENCODING to utf-8

2017-03-12 Thread Jason A. Donenfeld
Hey guys, Sorry for the delay. I'm currently on the road traveling and won't be properly back at my desk until the end of next week. However, my initial reaction is that hard coding various interpreter-specific environment variables in cgit itself is not correct, and that this is something

Re: [PATCH 1/3] filter: introduce cgit_open_email_filter() wrapper

2017-02-25 Thread Jason A. Donenfeld
Can you resubmit this series as a normal git-send-email situation? Very hard to review as attachments like this. Thanks, Jason ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 0/3] Fix segfault found by AFL

2017-02-19 Thread Jason A. Donenfeld
Excellent. Running AFL on cgit is a great idea. I'll merge and review when I'm back at my desk on Tuesday. On Feb 19, 2017 12:45, "John Keeping" wrote: I set AFL [0] loose on CGit's URL input yesterday and it managed to find one issue that leads to a segfault via a null

Re: patch links do not have stable checksums

2017-02-18 Thread Jason A. Donenfeld
Seems most reasonable to simply keep it something static and not add a nob. However, John - you raise a good point. Git's diff feature isn't exactly stable itself, with all sorts of interesting new diffing strategies being tried out in newer versions. So perhaps this isn't really an feasible goal

Re: [PULL] Fix escaping in atom output

2017-02-18 Thread Jason A. Donenfeld
Thanks. I'll review and merge. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH] ui-patch: fix segfault when a path prefix is passed

2017-01-22 Thread Jason A. Donenfeld
Nice catch, thanks. Merged. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/1] git: update to v2.11.0

2017-01-02 Thread Jason A. Donenfeld
Thanks for the reminder. Merged! ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/1] git: update to v2.11.0

2016-11-30 Thread Jason A. Donenfeld
Looks fine to me. Queue it up. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH] Link with -ldl on GNU Hurd

2016-11-25 Thread Jason A. Donenfeld
Hurd! Honored to merge this. ___ CGit mailing list CGit@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH] Fix crash when using path limit

2016-11-24 Thread Jason A. Donenfeld
Hi Lukas, Seems fine to me. Queue it up. Jason ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [ANNOUNCE] CGIT v1.1 Released

2016-11-24 Thread Jason A. Donenfeld
Jeeze louise, nice catch. Thanks. Merged. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH v5 1/1] ui-shared: allow to split the repository link

2016-11-24 Thread Jason A. Donenfeld
On Thu, Nov 24, 2016 at 6:32 PM, Petr Vorel wrote: > Any idea how to cope with it? I thought to use this feature only if repo.name > and repo.url > are the same. One way might be to always use the `name` part and not the `url`, but to ensure that any clickable links are

[ANNOUNCE] CGIT v1.1 Released

2016-11-22 Thread Jason A. Donenfeld
4.com/keys/AB9942E6D4A4CFC3412620A749FC7012A5DE03AE.asc Thanks to everyone who contributed to this release! Jason Donenfeld -BEGIN PGP SIGNATURE- iQIzBAEBCAAdFiEEq5lC5tSkz8NBJiCnSfxwEqXeA64FAlg1HTsACgkQSfxwEqXe A65/eA//Y0b2rVaPvwFuUbf3QEI2lm9yxgf5P2yzHGrbaHxeUjpzU5

Re: Tag new release

2016-11-22 Thread Jason A. Donenfeld
Thanks for the reminder. In progress now. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/1] git: update to v2.10.2

2016-11-06 Thread Jason A. Donenfeld
Looks good. Queue it up! ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: RFC: don't cache objects larger than X

2016-10-17 Thread Jason A. Donenfeld
I think there actually might be a trick using rlimit to implement this type of streaming size check... ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 2/3] shared: remove unused function strrpart()

2016-10-12 Thread Jason A. Donenfeld
LGTM. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

  1   2   3   4   5   >