On Fri, May 26, 2023 at 4:17 PM Christian Hesse wrote:
>
> Christian Hesse on Fri, 2023/05/26 16:06:
> > > Like string_list_split(), except that string is split in-place: the
> > > delimiter characters in string are overwritten with NULs, and the
> > > new string_list_items point into string
On Fri, May 26, 2023 at 1:07 PM Christian Hesse wrote:
> @@ -564,9 +566,11 @@ char *get_mimetype_for_filename(const char *filename)
> while (fgets(line, sizeof(line), file)) {
> if (!line[0] || line[0] == '#')
> continue;
> - mimetype
It still feels like the table shading is now way too dark in dark
mode. For all those various grays, there might be some transformation
to consider where you want the same distance from black that it
formerly had from white.
On Wed, Jan 11, 2023 at 09:56:30PM +0100, Jason A. Donenfeld wrote:
> It looks like the issue is that the string class for the light theme is:
>
> .highlight .s {
> color: #dd2200;
> background-color: #fff0f0;
> }
>
> But for the dark theme it's:
>
> @med
On Thu, Jan 12, 2023 at 1:33 AM Samuel Lidén Borell wrote:
>
> Oops. I made a last minute change of the themes, and that broke things. Looks
> like some theme combinations don't work well.
>
> I will send an updated patch with a working theme combo + a comment about
> this.
>
> It could also be
It looks like the issue is that the string class for the light theme is:
.highlight .s {
color: #dd2200;
background-color: #fff0f0;
}
But for the dark theme it's:
@media (prefers-color-scheme: dark)
.highlight .s {
color: #e6db74;
}
And so it winds up using the dark color, but with
Hmm. I applied this on the git.zx2c4.com server to test it, and
strings are somewhat illegible: https://git.zx2c4.com/cgit/tree/cgit.c
Signed-off-by: Jason A. Donenfeld
---
ui-shared.c | 8
1 file changed, 8 insertions(+)
diff --git a/ui-shared.c b/ui-shared.c
index 11aed19..baea6f2 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -770,6 +770,10 @@ static void print_rel_vcs_link(const char *url)
static int
Hi Samuel,
This also needs to be done for css. I'll send a v2 and apply it.
Jason
Those got merged to master, long overdue.
Hi Samuel,
On Sun, Jan 1, 2023 at 10:41 PM Samuel Lidén Borell wrote:
>
> Modern browsers have a "dark mode" preference, which enables alternate
> CSS rules on web sites that support this.
>
> This patch adds an optional dark color scheme, that can be copied into
> cgit.css. The color scheme is
Fixed in the master branch now.
Applied, thanks.
Jason
Wondering what the purpose of this is? Why would you prefer this
format over the other one?
On Sat, May 7, 2022 at 11:32 PM Hristo Venev wrote:
> I submitted it earlier today.
>
> https://lists.zx2c4.com/pipermail/cgit/2022-May/004723.html
Thanks. Went to spam because the DKIM signature failed.
Jason
Hi Hristo,
On Thu, Oct 7, 2021 at 5:45 PM Hristo Venev wrote:
> I will fix this in v2.
I'm finally culling patches for cgit. Did you want to submit a v2 of this patch?
Jason
Thanks guys. I'll get these merged to master branch in the coming two
weeks and cut a new release.
Jason
Hi,
The IRC channels #wireguard, #cgit, and #pass will now be on Libera.Chat in
official capacity. This means that you can now connect with other users and
developers of these projects by pointing your IRC client at:
Server: irc.libera.chat
Port: 6697 with TLS (aka "ssl" or "secure
Applied, thanks.
On Tue, Dec 29, 2020 at 7:22 PM Ulrich Spörlein wrote:
>
> On Tue, 2020-12-29 at 12:37:43 +0100, Jason A. Donenfeld wrote:
> >This is for the tag UI, though. Aren't tags supposed to live in
> >refs/tags/ by definition?
> >
> >Special casing "refs/&q
This is for the tag UI, though. Aren't tags supposed to live in
refs/tags/ by definition?
Special casing "refs/" also winds up breaking repositories that
accidentally push tags literally named 'refs/tags/something'. I've
seen this happen quite a few times in the real world.
Applied, thanks. Merged ch/for-jason too.
We'll also need to take a look at the http clone backend and related
documentation...
On Wed, Oct 21, 2020 at 9:37 PM Christian Hesse wrote:
>
> "Jason A. Donenfeld" on Wed, 2020/10/21 17:35:
> > Thanks! I've applied these. Next step I guess will be adding some
> > sha256 repos to the test suite.
>
> How complex do you want these tests to be
Applied, thanks.
Nice catch. Applied, thanks.
I'd be happy to take a patch for this, actually.
Something to focus on would be making sure malicious users can't
inject HTML into cgit through it somehow.
Also, https://git.zx2c4.com/sha256-oid-test/
Thanks! I've applied these. Next step I guess will be adding some
sha256 repos to the test suite. If everything works, I'll cut a new
release. Then, with the upcoming git releases, we'll start testing
behavior for hybrid repos, once upstream git supports those.
Thanks for this. It'll be curious to give this a spin with a sha256 repo...
On Mon, Oct 19, 2020 at 8:36 PM Christian Hesse wrote:
>
> From: Christian Hesse
>
> Update to git version v2.29.0, this requires changes for these
> upstream commits:
>
> * dbbcd44fb47347a3fdbee88ea21805b7f4ac0b98
>
Hi Pedro,
Yes the list is still open, and I've seen your patches.
Jason
Thanks. Feel free to queue it up.
/listinfo/cgit
== ChangeLog v1.2.3 ==
14 files changed, 183 insertions(+), 26 deletions(-)
This patch updates us to git 2.25.1, augments our tests, adds support for
lzip and zstd, and fixes a crash in when following logs.
This release contains commits from: Jason A. Donenfeld, Christian Hesse
verytime we want access to maybe_tree. Thankfully, the commit.cocci
script takes care of creating mostly-correct patches that we could then
fix up, resulting in this commit here.
Fixes: 255b78f ("git: update to v2.18.0")
Cc: Christian Hesse
Signed-off-by: Jason A. Donenfeld
---
ui-blame
Looks good, queue it up, thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Wow, thanks for doing this. I had just been discussing this with
Unit193, who submitted a similar but not as complete patch a few days
ago to me on IRC.
We had been discussing which compression level to pass to zstd or to
leave it as default. I think Unit193 had some thoughts on that, so
CC'ing
Applied, thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Thanks. Can you resubmit this with your Signed-off-by: line?
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Merged, thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Applied, thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
fix numerous bugs, update our lua dependencies, and bump to git
version 2.25.
This release contains commits from: Jason A. Donenfeld, Christian Hesse, and
Chris Mayo.
== Downloading ==
This release is available in compressed tarball form here:
https://git.zx2c4.com/cgit/snapshot/cgit-1.2.2.tar.xz
What's the purpose of this exactly? No justification in the commit
message. Is this simply to make testing against different upstream
gits simpler?
Jason
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Patch looks good. Thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
On Wed, Dec 11, 2019 at 10:59 AM Jason A. Donenfeld wrote:
>
> That's a good idea. Thanks. Queue it up.
Actually, wait.
Wouldn't it be better to do this as:
`strace true >/dev/null 2>&1 || { skip_all`
___
CGit mailing list
CGit
That's a good idea. Thanks. Queue it up.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
LGTM
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Thanks, stick it in ch/for-jason and I'll merge it for next release.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
ch/about-link has these:
https://git.zx2c4.com/cgit/patch/?id=5f215cec80c9ba08d80eeb4c23880537ca66f9d3
https://git.zx2c4.com/cgit/patch/?id=2fd38313e75fb4240c85c253292144f4fc299cc9
___
CGit mailing list
CGit@lists.zx2c4.com
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Hi contributors,
I've you push to git.zx2c4.com over ssh, you'll notice the ssh fingerprints
have changed. The valid new ones are:
SHA256:9os9asMrVeuWNlQmsmpA6bfcgFIwr5e0psYJYVBekUM
SHA256:frea6X2uzWJ3m0w5/qMKuXpbRgvvQIsFqotWCWkbR4M
Perhaps a more ideal version of this would be to not print breadcrumbs
at all for paths that don't exist in the given repo at the given oid.
Signed-off-by: Jason A. Donenfeld
Reported-by: Fydor Wire Snark
---
I've committed this, and it works. But if anyone would like to give the
implementation
Thanks, merged.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Merged, thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
You sure those statements are the same? Snprintf doesn't append like
strncat. Wouldn't strlcat be the more apt replacement?
--
Sent from my telephone.
On Fri, Feb 8, 2019, 22:49 Christian Hesse From: Christian Hesse
>
> Git version v2.21.0 marks strncat() as banned (commit
>
Seems reasonable. Queue it up.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Hah, bad timing, I just rewrote this myself and was about to push. But
thanks anyway!
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Merged, thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
That seems very reasonable.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Thanks, merged.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Hey Christian,
We should indeed introduce some sanitation helpers to deal with these
in the general case. API suggestion:
type_t parse_int(const char *str, type_t min, type_t max, type_t
fallback_if_invalid);
What would you think of that?
Regards,
Jason
Thanks Christian. Feel free to queue this all up in a for-jason branch.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Sounds pretty useful and hard to see downsides, then. Feel free to
queue this up in a for-jason.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
The effect is just anchor links, but it doesn't add an actual ToC, right?
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
On Fri, Aug 3, 2018 at 5:12 PM Jason A. Donenfeld wrote:
> * A fix for a critical directory traversal vulnerability, when
> `enable-http-clone=1` is not turned off, discovered by Jann Horn.
> This is pretty nasty and all users must update immediately.
This has been assigned CVE-2
On Fri, Aug 3, 2018 at 7:06 PM Todd Zullinger wrote:
> Yikes, thanks for the heads-up! Do you know if there is a
> CVE assigned for this issue yet?
I've requested one.
> It sounds like it affects
> all releases from 0.8 through 1.2, right?
Yes.
___
.
This release contains commits from: Jason A. Donenfeld and Konstantin
Ryabitsev.
== Downloading ==
This release is available in compressed tarball form here:
https://git.zx2c4.com/cgit/snapshot/cgit-1.2.1.tar.xz
SHA2-256: 3c547c146340fb16d4134326e7524bfb28ffa681284f1e3914bde1c27a9182bf
BLAKE2b-256
Thanks! Applied.
Jason
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Great, thanks Konstantin. I'll release right away.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Applied, thanks.
And I've retained your use of the ¹ character in the commit message,
as it might prove to be useful for detecting various UTF-8 breakage
down the road.
___
CGit mailing list
CGit@lists.zx2c4.com
cgit-1.1.tar.xz
$ gpg --verify cgit-1.1.tar.asc
gpg: assuming signed data in 'cgit-1.1.tar'
gpg: Signature made Thu 05 Jul 2018 02:34:20 AM CEST
gpg:using RSA key AB9942E6D4A4CFC3412620A749FC7012A5DE03AE
gpg:issuer "ja...@zx2c4.com"
gpg: Good signature f
Hey guys,
Seeing as there hasn't been a release for a while, it seems prudent
that we get one out fairly soon. Indeed there have been a lot of new
things added and code refactored since 1.1. There's still the
possibility of getting the render view improvements ready for 1.2 --
if those are
On Wed, Jul 4, 2018 at 2:44 AM Andy Green wrote:
> > looked at in depth. (See the list archives.) Our last conclusion from
> > examining it was that so much of libgit is not re-entrant, and so we'd
> > need to move to something like libgit2 for this to be feasible. Too
> > many globals, etc.
>
>
On Wed, Jul 4, 2018 at 2:01 AM Andy Green wrote:
> doesn't use any filters for syntax highlight and markdown render, it's
> all done in clientside JS. The gravatar is done using this patch.
If you're into doing things clientside, you could do gravatar
clientside too of course...
> This of
On Wed, Jul 4, 2018 at 1:48 AM Andy Green wrote:
> $ rpm -q gcc
> gcc-8.1.1-1.fc28.x86_64
>
> It's the current package on Fedora 28.
8.1.1, thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Sorry, but not a chance something like this can be accepted. This is
exactly the reason we put the time into making the Lua scripting
support. Is your reason for implementing this C performance? In that
case, could you send some performance metrics and some details about
your performance
Hi Andy,
I can't actually reproduce this with gcc 8.1.0. Could you send me the
output of your `gcc -v`?
Thanks,
Jason
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
On Tue, Jul 3, 2018 at 9:53 PM John Keeping wrote:
> If I can have one more bikeshed... I wonder if "about-content" is better
> than "about-readme", the latter feels a bit like we're saying this same
> thing twice.
Bikeshed granted. :) Yes, that sounds sensible.
Hey John,
On Thu, Jun 28, 2018 at 10:29 AM John Keeping wrote:
> Yeah, I don't think there's any way to avoid exec'ing twice in source
> view - we need to run the source filter for output and we need the
> render filter to tell us whether we should output a link to the rendered
> content.
Let's
I've merged a variant of the patch, and it appears to be working well.
Thanks guys!
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
On Mon, Jul 2, 2018 at 9:11 AM Christian Hesse wrote:
>
> Christian Hesse on Fri, 2018/06/08 07:21:
> > From: Christian Hesse
> >
> > The footer was nearly invisible, hard to read at best. Let's make it
> > a bit darker.
>
> This stayed in ch/for-jason. Any feedback?
Fairly subjective, but I
On Thu, Jun 28, 2018 at 1:24 AM Andy Green wrote:
> Can you help me understand what is "clearly superior" and "right way"
> about the [...] menu in github?
>
> Since you seem to be asking me to implement it?
>
> What put me off it was there's only one useful option on it, and it
> requires and
Hey John,
Thanks tons for your input, as always.
On Wed, Jun 27, 2018 at 9:51 PM John Keeping wrote:
> - It is desirable to have the existing source view in addition to the
> rendered content, preferably with syntax highlighting via the source
> filter; for example Markdown, HTML or SVG can
Hi Andy,
I'm happy to engage technically here in order to find the best way of
going about this. However,
> Nobody is paying me to do it and I don't have an endless budget of time
> to lavish on it (and it seems, neither do you...).
> If cgit can't do what I need in a reasonable timescale, even
Nack. If we're going to add something like this, the github GUI for it
is clearly superior and the right way of going about things, with the
elegant [...] menu.
Jason
___
CGit mailing list
CGit@lists.zx2c4.com
Hi Andy,
I'm super hesitant about the Pandora's box that introducing javascript
implies, but perhaps there's no use in fighting the future.
A few notes:
- Your js needs the copyright line like the rest of the project.
- Rather than awkwardly namespacing global methods, wrap everything
inside a
And, reverted.
The code is not the same; this broke tests. html_url_arg != html_url_path.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Hi Andy,
This seems like an obvious thing to merge, but I'm actually not so
certain I understand its necessity. md2html uses the highlight class.
Our css uses the highlight class. You're saying this conflicts with
something? From where? Third-party CSS? If that's the case, and if
it's a serious
Merged, thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Thanks John, merged.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Splitting out this issue into a different thread, because I think it's
orthogonal to the other topic.
On Wed, Jun 27, 2018 at 7:18 PM Jason A. Donenfeld wrote:
> In adding rendering of arbitrary files in blob view, this is
> essentially a fancy source view, with the one caveat
Hey Andy,
Thanks for this patchset. It looks like this is shaping up into a nice
direction. However, I'm a bit concerned about our nobs becoming
slightly overlapping and incoherent, and I think that with this
series, we should also unify how we handle rendering.
With the current state of this
On Sat, Jun 16, 2018 at 6:14 PM John Keeping wrote:
> But we still have a few mentions of sha1 in our code. Most of this is
> sha1 and sha2 in struct cgit_query, but these aren't actually hashes
> most of the time, they can be any object reference that Git understands,
> so I think we should
Hey John,
That seems like a reasonable approach. Feel free to queue it up in jk/for-jason.
Jason
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
LGTM.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
On Thu, Apr 26, 2018 at 2:19 PM, Christian Hesse <l...@eworm.de> wrote:
> "Jason A. Donenfeld" <ja...@zx2c4.com> on Thu, 2018/03/22 20:16:
>> Hi Terry,
>>
>> I'm traveling now, but I'll push out a release when I'm home mid April.
>
> Any news o
I run uwsgi+cgit on the actual cgit cgit repo. Here's the setup:
krantz ~ # cat /etc/nginx/sites/cgit.conf
server {
listen 443 ssl http2;
listen [::]:443 ssl http2;
server_name git.zx2c4.com;
access_log /var/log/nginx/cgit.access_log main;
error_log
Hi Terry,
I'm traveling now, but I'll push out a release when I'm home mid April.
Jason
--
Sent from my telephone.
On Thu, Mar 22, 2018, 13:07 Dunnigan, Terrence J <
terrence.j.dunni...@boeing.com> wrote:
> Hi all,
>
>
>
> I was wondering if there was an ETA for the next release of cgit? I am
Hey Konstantin,
That sounds like a potentially good idea. Though it does point to the
larger question: should notes be used in general for configuring more
parts of cgit in an ad-hoc manner? Is there a useful generalization of
this mechanism we should consider? We already have four different
This time you forgot the... just kidding.
Applied, thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Thanks. Pushed.
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
Seems reasonable to me. Can you resubmit with your `Signed-off-by:`?
Jason
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
1 - 100 of 431 matches
Mail list logo
