Hi,
> The title attribute was being set to the same value as the anchor
> element text.
> Signed-off-by: Chris Mayo
Reviewed-by: Petr Vorel
Good idea.
Kind regards,
Petr
___
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.co
+ add CSS formatting.
Signed-off-by: Petr Vorel
---
cgit.css | 5 +
ui-log.c | 4 +++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/cgit.css b/cgit.css
index d4aadbf..ca74508 100644
--- a/cgit.css
+++ b/cgit.css
@@ -893,3 +893,8 @@ div#cgit table.ssdiff td.space {
div#cgit
Hi,
> in commit list in Author columns in summary, refs and log pages.
Change v1->v2:
removed forgotten html_txt(ref->commit->author) from ui-refs.c.
Kind regards,
Petr
___
CGit mailing list
CGit@lists.zx2c4.com
in commit list in Author columns in summary, refs and log pages.
Signed-off-by: Petr Vorel
---
ui-log.c| 2 +-
ui-refs.c | 6 +++---
ui-shared.c | 7 +++
ui-shared.h | 1 +
4 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/ui-log.c b/ui-log.c
index d696e20..3fdc2a2
in commit list in Author columns in summary, refs and log pages.
Signed-off-by: Petr Vorel
---
ui-log.c| 2 +-
ui-refs.c | 5 +++--
ui-shared.c | 7 +++
ui-shared.h | 1 +
4 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/ui-log.c b/ui-log.c
index d696e20..3fdc2a2 100644
Hi John,
> > > This found on kernel cgit, tested locally. See:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-4.14/crypto-vmx-use-skcipher-for-ctr-fallback.patch
> > Which browser do you see this with?
> > I've tried Firefox 61.0 and Chromium
Hi John,
> > This found on kernel cgit, tested locally. See:
> > https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-4.14/crypto-vmx-use-skcipher-for-ctr-fallback.patch
> Which browser do you see this with?
> I've tried Firefox 61.0 and Chromium 69.0.3497.42
;
+ struct crypto_skcipher *fallback;
struct aes_key enc_key;
};
Signed-off-by: Petr Vorel
---
This found on kernel cgit, tested locally. See:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-4.14/crypto-vmx-use-skcipher-for-ctr-fallback.patch
Kind
Hi Jason,
> Teach cgit split the repository link in the top of repository "summary"
> view. This emulates the same behaviour as it's in gitweb.
> This behaviour is not implemented for repositories which have
> "repo.name" set different than "repo.url&qu
Hi John,
> It's the return value of cgit_repourl() that needs to be freed, not the
> name. You'll need a new local variable for the result of calling
> cgit_repourl() which then needs to be freed in the loop.
Thanks! Fixed in v9.
I ignored t0103-log.sh test failures you mentioned while
Teach cgit split the repository link in the top of repository "summary"
view. This emulates the same behaviour as it's in gitweb.
This behaviour is not implemented for repositories which have
"repo.name" set different than "repo.url".
Signed-off-by: Petr Vorel <
Hi,
> Teach cgit split the repository link in the top of repository "summary"
> view. This emulates the same behaviour as it's in gitweb.
> This behaviour is not implemented for repositories which have
> "repo.name" set different than "repo.url&qu
Hi John,
> > Thanks for your review John. Are we there yet? :-)
> I just noticed one more thing...
> > + html_link_open(cgit_repourl(name), NULL, NULL);
> The value returned by cgit_repourl() should be freed.
Thanks for info, fixed in v8.
Kind regards,
Petr
Teach cgit split the repository link in the top of repository "summary"
view. This emulates the same behaviour as it's in gitweb.
This behaviour is not implemented for repositories which have
"repo.name" set different than "repo.url".
Signed-off-by: Petr Vorel <
Teach cgit split the repository link in the top of repository "summary"
view. This emulates the same behaviour as it's in gitweb.
This behaviour is not implemented for repositories which have
"repo.name" set different than "repo.url".
Signed-off-by: Petr Vorel <
Teach cgit split the repository link in the top of repository "summary"
view. This emulates the same behaviour as it's in gitweb.
This behaviour is not implemented for repositories which have
"repo.name" set different than "repo.url".
Signed-off-by: Petr Vorel <
;summary"
> view. This emulates the same behaviour as it's in gitweb.
> This behaviour is not implemented for repositories which have
> "repo.name" set different than "repo.url".
> This feature is controlled by a new config variable:
> "split-summary-rep
new config variable:
"summary-enable-split-repo-link" (disabled by default).
Signed-off-by: Petr Vorel <petr.vo...@gmail.com>
---
v3: New config variable "summary-enable-split-repo-link", minor cleanup.
v2: Minor cleanup.
---
cgit.c | 3 +++
cgit.h | 1
Dear John,
> > We may just have to bail out of this feature if the two variables differ.
> Is it really the best way from UI/UX POV? Inconsistency isn't nice :-(. I'd
> like to try
> to have this feature either on or off for each repository.
You were right, it doesn't make much sense to split
Dear John,
Please, have a look at v2 (just minor cleanup), I'll answer there.
Kind regards,
Petr
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Signed-off-by: Petr Vorel <petr.vo...@gmail.com>
---
The only missing feature from gitweb: clickable any directory in between. It's
very handy, if you have lots of repos (local AOSP repositories).
If you don't like it hardcoded, I can prepare patch with configuration option.
v2: minor c
Signed-off-by: Petr Vorel <petr.vo...@gmail.com>
---
The only missing feature from gitweb: clickable any directory in between. It's
very handy, if you have lots of repos (local AOSP repositories).
If you don't like it hardcoded, I can prepare patch with configuration option.
---
ui-shared.
22 matches
Mail list logo
