Re: [PATCH v4 00/16] Render READMEs inline in tree view

2018-07-03 Thread Jason A. Donenfeld
On Tue, Jul 3, 2018 at 9:53 PM John Keeping wrote: > If I can have one more bikeshed... I wonder if "about-content" is better > than "about-readme", the latter feels a bit like we're saying this same > thing twice. Bikeshed granted. :) Yes, that sounds sensible.

Re: [PATCH v4 00/16] Render READMEs inline in tree view

2018-07-03 Thread John Keeping
On Tue, Jul 03, 2018 at 09:34:26PM +0200, Jason A. Donenfeld wrote: > On Thu, Jun 28, 2018 at 10:29 AM John Keeping wrote: > > Yeah, I don't think there's any way to avoid exec'ing twice in source > > view - we need to run the source filter for output and we need the > > render filter to tell us

Re: [PATCH v4 00/16] Render READMEs inline in tree view

2018-07-03 Thread Jason A. Donenfeld
Hey John, On Thu, Jun 28, 2018 at 10:29 AM John Keeping wrote: > Yeah, I don't think there's any way to avoid exec'ing twice in source > view - we need to run the source filter for output and we need the > render filter to tell us whether we should output a link to the rendered > content. Let's

Re: [PATCH v4 00/16] Render READMEs inline in tree view

2018-06-28 Thread John Keeping
On Thu, Jun 28, 2018 at 01:22:34AM +0200, Jason A. Donenfeld wrote: > Hey John, > > Thanks tons for your input, as always. > > On Wed, Jun 27, 2018 at 9:51 PM John Keeping wrote: > > - It is desirable to have the existing source view in addition to the > > rendered content, preferably with

Re: [PATCH v4 00/16] Render READMEs inline in tree view

2018-06-27 Thread Jason A. Donenfeld
Hey John, Thanks tons for your input, as always. On Wed, Jun 27, 2018 at 9:51 PM John Keeping wrote: > - It is desirable to have the existing source view in addition to the > rendered content, preferably with syntax highlighting via the source > filter; for example Markdown, HTML or SVG can

Re: [PATCH v4 00/16] Render READMEs inline in tree view

2018-06-27 Thread Andy Green
On 06/28/2018 06:46 AM, Jason A. Donenfeld wrote: Hi Andy, I'm happy to engage technically here in order to find the best way of going about this. However, Nobody is paying me to do it and I don't have an endless budget of time to lavish on it (and it seems, neither do you...). If cgit

Re: [PATCH v4 00/16] Render READMEs inline in tree view

2018-06-27 Thread Andy Green
On 06/28/2018 03:51 AM, John Keeping wrote: Hi Jason, On Wed, Jun 27, 2018 at 07:18:57PM +0200, Jason A. Donenfeld wrote: With the current state of this series, cgit would have the following options: - render. - inline-readme - render-filter This one is only a concept, not a

Re: [PATCH v4 00/16] Render READMEs inline in tree view

2018-06-27 Thread Jason A. Donenfeld
Hi Andy, I'm happy to engage technically here in order to find the best way of going about this. However, > Nobody is paying me to do it and I don't have an endless budget of time > to lavish on it (and it seems, neither do you...). > If cgit can't do what I need in a reasonable timescale, even

Re: [PATCH v4 00/16] Render READMEs inline in tree view

2018-06-27 Thread Andy Green
On 06/28/2018 01:18 AM, Jason A. Donenfeld wrote: Hey Andy, Thanks for this patchset. It looks like this is shaping up into a nice direction. However, I'm a bit concerned about our nobs becoming slightly overlapping and incoherent, and I think that with this series, we should also unify how

Re: Fancier Source view [Was: Re: [PATCH v4 00/16] Render READMEs inline in tree view]

2018-06-27 Thread John Keeping
On Wed, Jun 27, 2018 at 07:26:13PM +0200, Jason A. Donenfeld wrote: > Splitting out this issue into a different thread, because I think it's > orthogonal to the other topic. > > On Wed, Jun 27, 2018 at 7:18 PM Jason A. Donenfeld wrote: > > In adding rendering of arbitrary files in blob view,

Re: [PATCH v4 00/16] Render READMEs inline in tree view

2018-06-27 Thread John Keeping
Hi Jason, On Wed, Jun 27, 2018 at 07:18:57PM +0200, Jason A. Donenfeld wrote: > With the current state of this series, cgit would have the following options: > > - render. > - inline-readme > - render-filter This one is only a concept, not a configuration value (just a note since I couldn't

Fancier Source view [Was: Re: [PATCH v4 00/16] Render READMEs inline in tree view]

2018-06-27 Thread Jason A. Donenfeld
Splitting out this issue into a different thread, because I think it's orthogonal to the other topic. On Wed, Jun 27, 2018 at 7:18 PM Jason A. Donenfeld wrote: > In adding rendering of arbitrary files in blob view, this is > essentially a fancy source view, with the one caveat of our >

Re: [PATCH v4 00/16] Render READMEs inline in tree view

2018-06-27 Thread Jason A. Donenfeld
Hey Andy, Thanks for this patchset. It looks like this is shaping up into a nice direction. However, I'm a bit concerned about our nobs becoming slightly overlapping and incoherent, and I think that with this series, we should also unify how we handle rendering. With the current state of this

Re: [PATCH v4 00/16] Render READMEs inline in tree view

2018-06-23 Thread Andy Green
On 06/23/2018 07:04 PM, John Keeping wrote: On Wed, Jun 20, 2018 at 06:11:57PM +0800, Andy Green wrote: The following series adds config to allow rendering of selected READMEs inline after the tree view, where present in the directory being viewed. Particularly you can use completely

Re: [PATCH v4 00/16] Render READMEs inline in tree view

2018-06-23 Thread John Keeping
On Wed, Jun 20, 2018 at 06:11:57PM +0800, Andy Green wrote: > The following series adds config to allow rendering of > selected READMEs inline after the tree view, where > present in the directory being viewed. > > Particularly you can use completely relative markdown to > inline pictures served