Re: git notes for the Linux kernel
On Mon, Oct 17, 2022 at 01:50:04PM +0200, Vegard Nossum wrote: > I've improved the support for git notes in cgit, including the ability > to load notes from a separate repository than the one you are viewing. > > My use case is using a separate repository of git notes for the Linux > kernel to annotate commits with extra cross-referencing information such > as e.g.: > > - lore links to patch submissions matching the patch, > - references to subsequent fixes (if the current commit is buggy) > - mitre links to CVEs > - references to backports in stable/LTS This sounds useful, but... > My hope is that these notes can eventually be displayed on > git.kernel.org -- at least, we've found the notes invaluable and a huge > time saver in different types of kernel work. (I'm still in the process > of working out how to release these notes and/or the scripts generating > them, but that's a different topic.) > > I tried to submit the git.git patches upstream, but they were rejected > by the maintainer for not being general enough: > https://lore.kernel.org/git/20220802075401.2393-1-vegard.nos...@oracle.com/ ... this likely blocks inclusion in CGit as I don't think there's any desire to maintain a fork of git.git Parts of this series look like they make sense regardless of the separate repo option - patch 2 looks unrelated and the repo.notes_ref config option is potentially useful to keep the CGit config separate from gitconfig (although it should be "repo.notes-ref" for consistency with other config keys). Are you interested in splitting those parts out? Regards, John
Re: git notes for the Linux kernel
On 10/17/22 13:50, Vegard Nossum wrote: cgit patches will follow in replies to this email -- the two prerequisite git.git patches are available at the git mailing list link above and should apply cleanly to v2.38.0. Looks like the list rejected 2 of the patches for containing HTML, when those were actually plaintext emails with patches tweaking cgit's HTML generation code -- maybe something to look into, as that doesn't seem too unusual for patches on this mailing list. Anyway, also attaching a tarball with all the patches here, assuming that makes it through the filter! Vegard notes.tar.bz2 Description: application/bzip
git notes for the Linux kernel
Hi cgit maintainers, I've improved the support for git notes in cgit, including the ability to load notes from a separate repository than the one you are viewing. My use case is using a separate repository of git notes for the Linux kernel to annotate commits with extra cross-referencing information such as e.g.: - lore links to patch submissions matching the patch, - references to subsequent fixes (if the current commit is buggy) - mitre links to CVEs - references to backports in stable/LTS My hope is that these notes can eventually be displayed on git.kernel.org -- at least, we've found the notes invaluable and a huge time saver in different types of kernel work. (I'm still in the process of working out how to release these notes and/or the scripts generating them, but that's a different topic.) I tried to submit the git.git patches upstream, but they were rejected by the maintainer for not being general enough: https://lore.kernel.org/git/20220802075401.2393-1-vegard.nos...@oracle.com/ I will unfortunately not be able to implement the git maintainer's suggestion, so I'll just offer up my git and cgit patches here, in case cgit would still like this functionality; it would mean having to maintain and carry the extra 2 git.git patches. I would be happy to continue forward-porting those patches, however, as this is something I will need to do for our internal use anyway. Here is a screenshot of cgit with Linux kernel notes in action: https://vegard.github.io/cgit/6399f1fae4ec.png cgit patches will follow in replies to this email -- the two prerequisite git.git patches are available at the git mailing list link above and should apply cleanly to v2.38.0. Thanks, Vegard
