Re: [PATCH] cgit: ignore SIGPIPE

2016-10-02 Thread John Keeping
On Sat, Oct 01, 2016 at 10:52:11PM +0200, Jason A. Donenfeld wrote: > I see the utility of this with something like a highlight filter gone > bad. But is it safe to do this in the context of an authentication > filter? What's the failure behavior like once this patch is applied? If we ignore

Re: [PATCH] cgit: ignore SIGPIPE

2016-10-01 Thread Jason A. Donenfeld
Hey John, I see the utility of this with something like a highlight filter gone bad. But is it safe to do this in the context of an authentication filter? What's the failure behavior like once this patch is applied? Jason ___ CGit mailing list

[PATCH] cgit: ignore SIGPIPE

2016-10-01 Thread John Keeping
We check the return value from write() and die with an error message, so the only effects of using the default SIGPIPE handler is to suppress the error message and change the exit status. Web servers tend to ignore the exit code, so it is likely to be more helpful to administrators if we print